Request hosting for amazon-ecs-plugin

[Phu Nguyen Anh]

Hi,
I've made a plugin for dynamically provision a slave on Amazon ECS, could I host it on jenkins?
My information:
- Github plugin name: amazon-ecs-plugin
- Personal Github ID: phuna
- Github repository: https://github.com/phuna/amazon-ecs-plugin

The plugin is still simple but works (per my test), best if jenkins master is in the same VPC with ECS' container instances. Any suggestions are very much appreciate.

Best regards,
Phu

[Ullrich Hafner]

How does it differ from https://wiki.jenkins-ci.org/display/JENKINS/Amazon+EC2+Plugin?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/612ddd18-8947-4334-9e17-39b600cd4ce1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Nguyen Anh Phu]

I haven't tried the EC2 plugin you mentioned but I think it uses EC2 instances as slaves directly, whilst my plugin uses docker containers inside EC2 instances as slaves (via ECS' API). Theoretically using ECS gives us more control on resource utilization, e.g. in simplest case we can, when launching slave, check which instance has enough resource to launch. We can also implement more complex scheduler than that.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/F3kP3q2uriQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/ECAEBC9E-2CAD-48FA-A1BC-CBE75862BDD2%40gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Nguyen Anh Phu

[Nguyen Anh Phu]

Hi, so doesn't it sound different? :)

--

Nguyen Anh Phu

[Nguyen Anh Phu]

Hi,

Any feedback for this? I'd like to know if it's OK or not or should I improve it to provide better benefit to the community.

Thanks,

--

Nguyen Anh Phu

[Ullrich Hafner]

I think the name should clearly indicate what is different from the existing one. 

On the other hand, couldn’t these two approaches combined into *one* plug-in?

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAAkRrg4L1WDrae_Hqb_aCiHgBw2uNxtCUyFwVJCcKNO8vJfeOg%40mail.gmail.com.

[Nguyen Anh Phu]

Hi Ullrich,

A name of amazon-container-service would make it looks clearer?

To combine them into one is a good idea which I'll discuss with Amazon EC2's maintainers. Anyway I think for now other people can already have benefit of using this plugin for their jenkins environment.

Best regards,

Phu

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/A4A4D19A-8BB8-4127-8D3E-0C04CB547C90%40gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Nguyen Anh Phu

[domi]

something like: “for now its better to release it that way” - we hear this a lot, but experience clearly shows: in most of the cases plugins will never be merged again after they are separated

my 2cent

Domi

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAAkRrg6o%2B6h5%3DUTK05cBvP5d%3DA%3DLD2%2BBD6JupaMX-YUoKi2%3DTg%40mail.gmail.com.

[Nguyen Anh Phu]

I don't know that the fact is that bad, but OK I'll check the merging possibility first.

Phu

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/C8590116-44DC-489A-97F7-F613F7604851%40fortysix.ch.

For more options, visit https://groups.google.com/d/optout.

--

Nguyen Anh Phu

[Ali Khan]

Hi,

I think it is a very a good plugin solving different problem from ec2 plugin. In fact it is more like the jenkins docker plugin. The issue it solved for me is that we have jenkins master running as ECS container, now I need to spin up on-demand jenkins slave as another ecs container to run a job and then take down the slave once the job is finished.

I would also like it to support the ecs api from the command line on jenkins master instead of using the authentication via ECSCloud.

In my case I can not provide the EC2 authentication info, instead aws cli is configured on the jenkins master. So I would like to spin up the jenkins slave via cli. I would fork this to add the cli capability.

thanks

Ali

[Francis Upton]

Hi all,

I'm the maintainer of the EC2 plugin and I had a look at the ECS plugin to see if there is anything in common and it appears after looking a few minutes that there really is not much. I would certainly be happy to entertain extending the EC2 plugin to support the ECS service if it makes sense from a user model perspective (if there is enough benefit in using some of the EC2 configuration to help out). I welcome further discussion or pull requests.

Francis

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/24831da9-ae59-47f6-9475-043a32556c4d%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Cell 510 432 1589

[Nguyen Anh Phu]

Hi Francis, Ali,

One of the integration that I can think of is to have EC2 plugin starts a Container Instance (EC2 instance with ECS agent inside) instead of a "normal" EC2 instance. After that flow would be the same as what amazon-ecs-plugin is doing now: Use ECS API to start a task which itself creates a Jenkins slave, run Jenkins build, then tear down that slave.

@Ali,

Would you mind making a PR for your CLI? I think it will be helpful to have another option to not put credential in Jenkins' configuration.

Best regards,

Phu

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CADVu73P13sSA6q4dWjSf1Ye%3DFjTLVkm%2BHenKJMVc8Wwtfyib4w%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Nguyen Anh Phu

[Ali Khan]

Hi Phu,

I have created a pull request for the default authentication. I have also made some further improvements. I am now using this in my project.

thanks and best regards

Ali

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAAkRrg6-e4PYUOxr2yJ_r%2Bjn1P4-E%2Bp5rfhz0yKQtdxfZmnQKA%40mail.gmail.com.

[Nguyen Anh Phu]

Thank you Ali, let's continue discussion about that PR on github.

Best regards,

Phu

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CABYrWPaxj_3eubkGqXrPRpQ4EKP6OAecwUa7zfCs6uixzQRTfw%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Nguyen Anh Phu