patch to use Sip status and cseq method properly

19 views
Skip to first unread message

David Villasmil

unread,
Nov 30, 2016, 8:49:39 AM11/30/16
to Homer Developers
Hello,

The way sipcapture now works, for requests it inserts the actual method name into the "method" field. But for replies, it inserts the SIP Status (i.e. 200, 407) into the "method" field.
It would be better to extract the actual method name from the CSEQ header and insert it into the "method" field, as well as adding a "status" field to the tables and inserting there the actual SIP Status.

I've made a patch for sipcapture.c and resulCtrl.js and modified homer_mysql_rotate.pl to add the mentioned field.

the result in db is like:


And the UI is:



This is my first time contributing homer, how should I do this? I've already signed the contributor's doc.

Thanks and regards,

David Villasmil

Lorenzo Mangani

unread,
Nov 30, 2016, 8:52:23 AM11/30/16
to home...@googlegroups.com
Hi David!

First of all, thanks for your effort shaping this contribution! The best way to submit it is to fork the relevant repositories on github, apply your changes, and submit a Pull Request.

The community will sure be happy to review and fine tune any detail to make sure its a good fit under all aspects.

Looking forward to that, and feel free to ask here if any support is useful, 


Kind Regards,

Lorenzo Mangani
Managing Director and Core Dev

QXIP BV - Capture Engineering
Amsterdam, The Netherlands

Mobile: +31 6 4603-2730

Find our more about HOMER, PCAPTURE, CAPTAGENT and all our Services and Solutions at http://qxip.net 

CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential or legally privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of this original message. 

--
You received this message because you are subscribed to the Google Groups "Homer Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to homer-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

David Villasmil

unread,
Nov 30, 2016, 9:30:39 AM11/30/16
to home...@googlegroups.com
Hello Lorenzo,

Thanks for replying.
I got a question, the patch on sipcapture.c would need to be pull-requested to kamailio, correct?

Regards,

David Villasmil

On Wed, Nov 30, 2016 at 2:52 PM, Lorenzo Mangani <lorenzo...@gmail.com> wrote:
Hi David!

First of all, thanks for your effort shaping this contribution! The best way to submit it is to fork the relevant repositories on github, apply your changes, and submit a Pull Request.

The community will sure be happy to review and fine tune any detail to make sure its a good fit under all aspects.

Looking forward to that, and feel free to ask here if any support is useful, 


Kind Regards,

Lorenzo Mangani
Managing Director and Core Dev

QXIP BV - Capture Engineering
Amsterdam, The Netherlands

Mobile: +31 6 4603-2730

Find our more about HOMER, PCAPTURE, CAPTAGENT and all our Services and Solutions at http://qxip.net 

CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential or legally privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of this original message. 

On Wed, Nov 30, 2016 at 2:49 PM, David Villasmil <david.villasmil.work@gmail.com> wrote:
Hello,

The way sipcapture now works, for requests it inserts the actual method name into the "method" field. But for replies, it inserts the SIP Status (i.e. 200, 407) into the "method" field.
It would be better to extract the actual method name from the CSEQ header and insert it into the "method" field, as well as adding a "status" field to the tables and inserting there the actual SIP Status.

I've made a patch for sipcapture.c and resulCtrl.js and modified homer_mysql_rotate.pl to add the mentioned field.

the result in db is like:


And the UI is:



This is my first time contributing homer, how should I do this? I've already signed the contributor's doc.

Thanks and regards,

David Villasmil

--
You received this message because you are subscribed to the Google Groups "Homer Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to homer-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "Homer Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/homer-dev/KWfIeROXdvg/unsubscribe.
To unsubscribe from this group and all its topics, send an email to homer-dev+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

ᐧ

Lorenzo Mangani

unread,
Nov 30, 2016, 10:02:37 AM11/30/16
to home...@googlegroups.com
Hi David,

That's correct indeed - Ideally the change should be backward compatible for those with existing setups or ad-hoc settings.
Maybe one of our senior developers on the list can comment on this or bridge this over if approved for inclusion... 
also this should be covered across all platforms HEP server platforms so... let's hear the voice of the list ;)


Kind Regards,

Lorenzo Mangani
Managing Director and Core Dev

QXIP BV - Capture Engineering
Amsterdam, The Netherlands

Mobile: +31 6 4603-2730

Find our more about HOMER, PCAPTURE, CAPTAGENT and all our Services and Solutions at http://qxip.net 

CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential or legally privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of this original message. 

On Wed, Nov 30, 2016 at 3:30 PM, David Villasmil <david.vill...@gmail.com> wrote:
Hello Lorenzo,

Thanks for replying.
I got a question, the patch on sipcapture.c would need to be pull-requested to kamailio, correct?

Regards,

David Villasmil

On Wed, Nov 30, 2016 at 2:52 PM, Lorenzo Mangani <lorenzo...@gmail.com> wrote:
Hi David!

First of all, thanks for your effort shaping this contribution! The best way to submit it is to fork the relevant repositories on github, apply your changes, and submit a Pull Request.

The community will sure be happy to review and fine tune any detail to make sure its a good fit under all aspects.

Looking forward to that, and feel free to ask here if any support is useful, 


Kind Regards,

Lorenzo Mangani
Managing Director and Core Dev

QXIP BV - Capture Engineering
Amsterdam, The Netherlands

Mobile: +31 6 4603-2730

Find our more about HOMER, PCAPTURE, CAPTAGENT and all our Services and Solutions at http://qxip.net 

CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential or legally privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of this original message. 

Reply all
Reply to author
Forward
0 new messages