SCSS syntax highlighting

[Kurt Emch]

Hi Ivan,

I created a fork of highlight.js to add Sass (scss) support. I have it working so far, but am hoping to find some contributors to make a little more solid. https://github.com/kemch/highlight.js

Depending on the contents of the test, I get some conflicts with CSS (because they're so similar), and haven't quite figured out the best way to handle the way sass nests definitions. Also, it would be a little more future-proof if it could utilize regular expressions more, as I am using keywords.

Kurt

[Ivan Sagalaev]

Hi Kurt,

It's usually a good idea to merge even the basic support into master, it
makes it more visible for potential contributors.

I'll try to look at your branch both for nests and conflicts with CSS
sometime next week. I have quite a backlog of highlight.js related
things to work through.

[Kurt Emch]

Ivan, Great I'll continue to work in my branch as I make improvements. Thanks! 

--

--
Kurt

[marcvangend]

Hi,

I don't mean to be pushy, but is there any progress on this? I could really use SCSS highlighting.

Thanks, Marc

Op dinsdag 29 januari 2013 06:15:13 UTC+1 schreef Kurt Emch het volgende:

[Ivan Sagalaev]

Kurt never sent a pull request and his last commit into the branch was
about 2 months ago. However there seems to be done a significant amount
of work and I think the best way forward is for someone familiar with
SCSS to fork Kurt's branch and finish it.

[Kurt Emch]

Thanks for reminding me about this. The SCSS syntax highlighting in my branch works as expected. It could use some improvement I'm sure as I've only used it on a couple posts of mine since.

Ivan, could we get it into the main branch to increase exposure to contributors?

[Ivan Sagalaev]

Sure! Create a pull request on GitHub from your branch[1] (this is
usually how a maintainer knows if a fork is ready to be merged).

[1]: https://help.github.com/articles/using-pull-requests

[Marc van Gend]

Thanks, good to see the renewed energy here. I'll be happy to test it once it's merged into the main repo.

2013/3/25 Ivan Sagalaev <man...@softwaremaniacs.org>

Sure! Create a pull request on GitHub from your branch[1] (this is usually how a maintainer knows if a fork is ready to be merged).

[1]: https://help.github.com/articles/using-pull-requests

--
You received this message because you are subscribed to the Google Groups "highlight.js" group.
To unsubscribe from this group and stop receiving emails from it, send an email to highlightjs+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Ivan Sagalaev]

� and it's in. Just merged the fork into master.

[Marc van Gend]

Nice. Hope to find some time to test it later today.

Op 27 mrt. 2013 06:54 schreef "Ivan Sagalaev" <man...@softwaremaniacs.org> het volgende:

… and it's in. Just merged the fork into master.

[Kurt Emch]

Awesome, by all means!

--
You received this message because you are subscribed to a topic in the Google Groups "highlight.js" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/highlightjs/Se27UZ3Ofrc/unsubscribe?hl=en.
To unsubscribe from this group and all its topics, send an email to highlightjs...@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.
 
 

--
Kurt