Upgrade validation-api dependency to 1.1.0.Final

[Ali Akhtar]

gwt-user has a dependency to an older version of javax-validation:validation-api. This is causing a lot of issues, and causing builds to break with Dropwizard. See: http://stackoverflow.com/questions/36568756/maven-dependency-management-being-ignored-at-test-time-works-at-runtime

Please upgrade to the latest version in snapshot.

[Thomas Broyer]

On Tuesday, April 12, 2016 at 11:21:39 AM UTC+2, Ali Akhtar wrote:

gwt-user has a dependency to an older version of javax-validation:validation-api. This is causing a lot of issues, and causing builds to break with Dropwizard. See: http://stackoverflow.com/questions/36568756/maven-dependency-management-being-ignored-at-test-time-works-at-runtime

Split client-side and server-side code into distinct Maven modules. You want distinct classpaths for distinct build tasks, the way to make it happen with Maven is to use distinct modules.

 

Please upgrade to the latest version in snapshot.

That's not how things go. Many have asked already, and some have started providing patches, but nobody finished the work. You're welcome to try and go the last few miles if you feel brave enough; or just restructure your Maven project to follow Maven best practices.

I think if we could, we'd remove the dependency altogether by splitting javax.validation support out into a third-party lib; but unfortunately javax.validation has crept into other parts of the codebase (request factory, editors, themselves now deeply interleaved with widgets). Splitting is possible, but demand some efforts, and it's easier to just use separate classpaths when invoking GWT to avoid conflicts with server-side dependencies. I'm still hopeful that we'll one day replace the build system with something easier to maintain and allowing more modularity, but for now I'm waiting for GWT 3 work to start (or at least have some visibility about what it could look like).

[Ali Akhtar]

It would make my workflow very complicated to have them in separate modules, as then I'd also need a 3rd project for shared code. It so happens that mostly DTOs would be in the shared code, and the DTOs would need to be annotated w/ Validation annotations. Where do they get these annotations, GWT's version or Dropwizard's version? This wouldn't really solve anything.

GWT is on 1.0.0.1.GA. Isn't that going to be mostly compatible with 1.1.0? It seems like this would just  require changing the version in a pom, and the rest would work. I would be really surprised if there are any breaking changes between these versions.

[Jens]

GWT is on 1.0.0.1.GA. Isn't that going to be mostly compatible with 1.1.0? It seems like this would just  require changing the version in a pom, and the rest would work. I would be really surprised if there are any breaking changes between these versions.

Upgrading Validation API to 1.1.0 would also require to update Hibernate Validator from 4.x to 5.x including its GWT emulation. The update of Hibernate Validator from 4.1.0 to 4.3.2 (which is still Validation API 1.0) is already some work and has not yet been committed: 

https://gwt-review.googlesource.com/#/c/9320/

So no its not just changing a version in a pom.

-- J.

 

 

[Ali Akhtar]

Please consider making that hibernate upgrade a priority. We are hugely behind on that upgrade, Hibernate 4 was ages ago. Today I'm experiencing this problem, but a lot of people are going to experience this in future, because every project is going to be on a newer version of validation-api.  If we tell everyone to split up GWT into a separate project, that kills one of the main advantages of GWT, which is code re-use.

I'd help but I'm not familiar with that code base at all.

--
You received this message because you are subscribed to a topic in the Google Groups "GWT Users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/Py4c2Fm9_7Y/unsubscribe.
To unsubscribe from this group and all its topics, send an email to google-web-tool...@googlegroups.com.
To post to this group, send email to google-we...@googlegroups.com.
Visit this group at https://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/d/optout.

[Thomas Broyer]

Nobody maintains the JSR303 emulation. Someone (Danilo) once volunteered, started working on the upgrade, and then disappeared.
If you don't use client-side validation then you can compile with javax.validation 1.0 and run with 1.1. The problem then is setting up those rules in your build, and then Maven gets in the way. Splitting your project in several modules really is the way to go when using Maven (it'd be different with Gradle for example); and it doesn't necessarily changes the dev workflow (see https://github.com/tbroyer/gwt-maven-archetypes)