Issue with the new 'signed in' feature

103 views
Skip to first unread message

Rob McMahon

unread,
Dec 5, 2014, 7:59:20 AM12/5/14
to google-map...@googlegroups.com
I have been using the new v3 API 'signed in' feature for a project I created at http://www.mapchannels.com/VenueMaps.aspx
Venue Maps let people create maps and streetview for a selected location and includes full source code.

There is a small bug I noticed with the signed in feature. When the info window first loads the text 'Can't save this place to Google Maps' is displayed. 
About a second later (the time varies) this text is replaced by 'Save to Google Maps'. 

Screenshots of the issue are here:

This isn't a major bug but it would look neater if only the 'Save to Google Maps' text was displayed. Can someone confirm this is an API bug and I will add it to the issue tracker.
venuemap-signedin1.jpg
venuemap-signedin2.jpg

Enoch Lau (Google Employee)

unread,
Dec 6, 2014, 8:37:04 PM12/6/14
to google-map...@googlegroups.com
Can you point me to the relevant parts of your JS code please? In particular, how and when do you open the info window, and set the 'place' property of the marker?

Enoch

Rob McMahon

unread,
Dec 6, 2014, 9:25:35 PM12/6/14
to google-map...@googlegroups.com

Hi Enoch

 

Thanks for the reply. It’s probably best to look at the template map which is used to generate the code for the user.

This is at http://www.mapchannels.com/venuemap/template/map.htm

 

The marker is set up in createMarker() at line 403 and the infoWindow is displayed by showInfoWindow() at line 560.

 

I can strip down the code and send you a link tomorrow to a page with just the one map and no street view.

 

I did try playing around with the creation order for the marker and info window but the same problem happened.

 

It may be due to the fact that I’m not using Google Place IDs for the markers. In lines 405 – 418 I have this code to set up the properties required for markerOptions :

 

                // place information (location and name) for used by the Google signed-in bookmarking service

                var placeInfo =

                {

                    placeId: null,

                    location: pt,

                    query: placeName

                };

 

                // Add Marker Attribution Information

                var attributionInfo =

                {

                    source: linkTitle,

                    webUrl: linkURL

                };

 

                var markerOptions =

                {

                    position: pt,

                    map: map,

                    icon: markerURL,

                    title: name,

                    place: placeInfo,

                    attribution: attributionInfo

                };

 

 

I’m guessing that there’s a different process for markers without a Google Place ID and that is causing the bug.

 

It’s not a major issue but it would look a bit neater without the text flicker when the info window is launched. It only ever happens the first time the info window gets displayed.

 

 

Best Regards

Rob McMahon

www.mapchannels.com

--
You received this message because you are subscribed to a topic in the Google Groups "Google Maps JavaScript API v3" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-maps-js-api-v3/L1_Tg_t9kGs/unsubscribe.
To unsubscribe from this group and all its topics, send an email to google-maps-js-a...@googlegroups.com.
To post to this group, send email to google-map...@googlegroups.com.
Visit this group at http://groups.google.com/group/google-maps-js-api-v3.
For more options, visit https://groups.google.com/d/optout.

Rob McMahon

unread,
Dec 7, 2014, 10:01:18 AM12/7/14
to google-map...@googlegroups.com
I made a stripped down page to demonstrate the bug at http://www.mapchannels.com/testsignedinmap.htm

I noticed a couple of other things

(1) When using v3.x instead of v3.18 the text stays as 'Cannot Save To Google Maps' and 'Save to Google Maps' never appears. See  http://www.mapchannels.com/testsignedinmap3.x.htm

(2) The  'Save to Google Maps' text is truncated in the info window unless I enclose the place name in a wide enough div. This is a separate issue which may be connected to the info window bug at https://code.google.com/p/gmaps-api-issues/issues/detail?id=5713 

I've attached a screenshot of what happens.

venuemap-signedin3.jpg

Enoch Lau (Google Employee)

unread,
Dec 8, 2014, 6:02:05 AM12/8/14
to google-map...@googlegroups.com
Thanks for noticing this. It looks like something we can improve in the Maps API. Please file a bug on the issue tracker if you'd like to keep track of it: https://code.google.com/p/gmaps-api-issues/issues/list

Enoch

Rob McMahon

unread,
Dec 11, 2014, 11:29:55 AM12/11/14
to google-map...@googlegroups.com
I have posted a bug report at https://code.google.com/p/gmaps-api-issues/issues/detail?id=7445 

Can more resources be given to fixing reported bugs in the v3 API ? There are some quite major bugs that were reported some time ago but are still awaiting a fix such as:



Reply all
Reply to author
Forward
0 new messages