Transclude scope overrides ng-controller when on same (custom) directive

[Christophe Eymard]

http://jsfiddle.net/pouipoui/X4rSy/1/

In it, we can see that using ng-controller on a custom directive causes a loss of the scope that it created.

What can be done to avoid the issue ?

Thanks for any input :)

[Peter Bacon Darwin]

I think this is a bug. I think that when you use replace:true the controller attached to the original element is not copied over.

Can you create an issue?

Pete

--
You received this message because you are subscribed to the Google Groups "AngularJS" group.
To unsubscribe from this group and stop receiving emails from it, send an email to angular+u...@googlegroups.com.
To post to this group, send email to ang...@googlegroups.com.
Visit this group at http://groups.google.com/group/angular?hl=en-US.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Joshua Miller]

Hello!

Actually, this is the behavior I would expect. 

Transclusion means the contents of the element are evaluated in the *parent* scope. When you define a controller on the same element, you are creating a new scope, but the transcluded contents are still evaluated in the parent scope - that is, in the scope *above* the new controller. Adding an ngController directive to an element shouldn't change how tranclusion works on another directive.

Or am I completely off base here?

Josh

--

[Peter Bacon Darwin]

@Josh - yes, you are right!

There is a bug about controllers elsewhere though!

Pete

[Peter Bacon Darwin]

http://plnkr.co/edit/PfJ6v6Pggs5beaxq0o2E?p=preview

[Christophe Eymard]

Any idea how to work around that problem ?

Does it still warrant an issue report ?

If yes, did you fill one already or should one be filled ?

[Peter Bacon Darwin]

http://jsfiddle.net/Nu5hn/

[Christophe Eymard]

I find it a little sad that we have to transclude the elements manually in the controller, kind of a performance loss there.

I hope we find some solution in the compile method...

Thank you though !

--
You received this message because you are subscribed to a topic in the Google Groups "AngularJS" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/angular/2Edcj4FKmSE/unsubscribe?hl=en-US.
To unsubscribe from this group and all its topics, send an email to angular+u...@googlegroups.com.

To post to this group, send email to ang...@googlegroups.com.
Visit this group at http://groups.google.com/group/angular?hl=en-US.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--
Christophe Eymard

[Peter Bacon Darwin]

Huh?  What do you think ng-transclude does?

https://github.com/angular/angular.js/blob/master/src/ng/directive/ngTransclude.js#L52-L57

[Christophe Eymard]

Ah, my bad, didn't think it through.

Thank you again !