Building from source when editing reader

[Thayer]

I am brand new to Zotero development and new to node, but I am working on a patch for the reader to give me more flexibility in filtering annotations. I have successfully followed the instructions and built Zotero from source (https://www.zotero.org/support/dev/client_coding/building_the_desktop_app) with a caveat: changes that I made inside `reader/` are not reflected in the application that is built when I execute `app/scripts/build_and_run -r`.

As a basic example: (1) I can edit html content in `chrome/content/zotero/` and see those changes reflected when I build the app. (2) but when edit html content in `reader/src/common/components/sidebar/annotations-view.js` nothing changes when I build the app (I can actually delete the contents of this file with no effect).

What is the intended procedure for developers working on the reader to build Zotero?

Thank you for your help!

[Tomasz Najdek]

The build system uses a commit hash to download a pre-built reader in order to speed up the build process. It then stores that hash inside .signatures.json​ so on future requests for a rebuild, it compares the hash and only re-fetches if they mismatch. Finally, if for any reason the download fails, it proceeds to do the build locally. The logic for this lives in js-build/reader.js​. Currently, I believe, the only way to achieve what you're trying to do is to modify that script in order to force a local build and skip updating the signatures file.

--
You received this message because you are subscribed to the Google Groups "zotero-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to zotero-dev+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/zotero-dev/a952817f-e351-4b85-882e-e74f0c5dfd43n%40googlegroups.com.

[Abe Jellinek]

Making a commit in the reader submodule also works.

To view this discussion visit https://groups.google.com/d/msgid/zotero-dev/FznIYSnUFvAsXzFaTZS-WKHdunjQm2NQouL8q7P9adhxODPTzzHu3c9hrC9dL3t7neeGtEFT3PEfniyt_15c0-A0qmUPIGddyrMYnPnQG88%3D%40doppnet.com.