help wanted: complete things

28 views
Skip to first unread message

Adrian Cole

unread,
Jul 5, 2019, 1:47:12 AM7/5/19
to zipki...@googlegroups.com
Hi, folks.

One of the great things about our community is volunteerism. It is
awesome that we get the relevance of practice and the diversity of
people from different places and backgrounds. One innate challenge of
volunteer work is unfinished work. I know it is easy to get side
tracked, and regardless of intent being unable to get stuff past the
finish line. This is par for the course, but it can also be confusing.
For example, people usually don't take on work if they think someone
else is doing it. Sometimes we have good intention, but accidentally
squat on work cementing no progress for sometimes orders of months.
Obviously we've had lots of distractions and probably more of this is
simply forgotten.

In such case, I wanted to remind of some work really needed, but not
started or complete. We could use some help getting some of this over
the finish line. I'm doing my best to finish up things also, but
frankly most of my time has been tech debt. Ideally that's over soon.

Anyway here's some things maybe we forgot:

* Zipkin Lens needs to work on bastion hosts (proxy mount under a
different path), I think we talked about this many many times, but I
don't think anyone actually did anything. This is blocking the
switcheroo.
* Envoy Zipkin v2 format has been closed a couple times due to some
sort of stall bot. We need to ask someone else to help if we aren't
able to move this forward. ex maybe https://github.com/Dudi119/cppKin
* https://github.com/openzipkin-contrib/zipkin-js-aws has been asked
for many many times also, but there is literally nothing in the repo
* Routinely we are asked about zipkin-go-opentracing and the answer is
always the same, but it hasn't shipped either

Don't consider this email pressure, rather a request in case we forgot
about work. If work is not going to complete at all, it is probably
good to acknowledge that and reduce our scope until we get to a point
where we finish things. We can always build back from there.
Meanwhile, I think we should be careful about committing and not
delivering as it can annoy users or even cement an impression that we
don't finish things.

My 2p, lay yours on me!

Brian Devins-Suresh

unread,
Jul 5, 2019, 12:43:03 PM7/5/19
to zipki...@googlegroups.com
Thanks for the reminders Adrian. I've definitely been dealing with burn out which doesn't help me get my volunteer/obsession work done after getting through a day of my paid work. I'll add my list of unfinished work and status.

The DynamoDB storage backend in zipkin-aws has been sitting, I don't know when I'll get the time to get back to this. I think there is more time left in getting it to the finish line than I can usually dedicate and this is one component that needs focus.

Sleuth SQS, yeah this one isn't in our org but I tend to treat Sleuth as one of ours anyway, I have a branch in progress for instrumenting the spring-cloud SQS consumer. I ran into a bunch of things that I wasn't sure about in the spring-integration/spring-messaging world that slowed me down. This I can get over the finish line with a small amount of effort.

AWS SQS instrumentation, this isn't work in progress but I noticed that the tags used do not match the ones that the X-Ray storage component knows about. I'm waiting on the messaging abstraction work to fix this though. I'll file a bug for this

I'm approaching some people about some changes at work so that maybe I can get past this drain and get back into a groove.

- Brian

--
You received this message because you are subscribed to the Google Groups "zipkin-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to zipkin-dev+...@googlegroups.com.
To post to this group, send email to zipki...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/zipkin-dev/CAHzwyDt7gWHuhA9bYC7GTMY4NyyU82UAara%2BFBTd0CixwpwWpA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Adrian Cole

unread,
Sep 17, 2019, 11:40:41 PM9/17/19
to zipki...@googlegroups.com
Hi, folks

I wanted to clue you in to some wrapped up and wrapping up things:

Wrapped up:
Armeria Elasticsearch redo is done in my opinion, thanks to Rag.

zipkin-gcp is now much more supportable with new README etc, thanks to GCP team.

https://github.com/openzipkin-contrib/zipkin-go-opentracing < Bas and JC managed to redo the opentracing layer directly on zipkin-go, which cuts a lot of the tech debt time from the former status quo.

https://github.com/openzipkin-contrib/zipkin-secondary-sampling < the overlay which allows you to make dynamic decisions about retained data without needing a 100% decision. Right now, Netflix are guinea pigs and this is java only. However, this could be helpful to implement in other languages. While not *finished* it is finished to a degree that it isn't pure merge conflicts or random data scattered across email. In other words, this one is a FYI in case you are interested

Wrapping up:

Rag is re-dockerifying everything with "master" tags so you can get the latest build. While he's usually neither on email nor gitter, you can watch pull requests, or ping Rag on armeria's slack for what's going on :) (this is a quiet nag for an uber-issue on the topic)

https://github.com/openzipkin/zipkin/pull/2736 < scoped trace UI: After a deluge of feedback and an unrelated hiatus, I'm happy to see igarashi picking this back up. This is a huge change to the UI, so if you have some interest in it, please comment.

https://github.com/openzipkin/zipkin-api/pull/82 < multi-get  This work had been hanging out in dead pull requests for way too long. I've resurrected it in order to try and avoid the "zipkin4net" problem where people were scared to help with the repo due to massive unmerged work. Even if we attic this, I'm ok with it. However, I don't want to redo it again in 6 months, so we should make a call to keep it or drop it.

https://github.com/openzipkin/zipkin/tree/attic/links-with-traceIds < This builds on the above, but I atticed it because it was stalled out and even the UI is in a different repo now. This is just an example of "completing" being ok to represent as Attic. We don't need to merge all the things.

Things that need wrapping up:

Things formerly mentioned on this thread many still need wrapping up. For example, still lens doesn't read config.json, have chinese language support, nor have proxy mounting verified. If we never do this work, we can never have a single UI.

Closing:

Anyway, hope some of this helps. I'll do my best to clean up as many repos as possible in the next month or so, so that there's no lurking massive work that puts off people from contributing.

Ciao,
-A
Reply all
Reply to author
Forward
0 new messages