https://github.com/vim/vim/pull/8828
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
Merging #8828 (756dc08) into master (04626c2) will decrease coverage by
87.68%
.
The diff coverage isn/a
.
@@ Coverage Diff @@ ## master #8828 +/- ## =========================================== - Coverage 90.14% 2.45% -87.69% =========================================== Files 151 149 -2 Lines 170814 165556 -5258 =========================================== - Hits 153985 4072 -149913 - Misses 16829 161484 +144655
Flag | Coverage Δ | |
---|---|---|
huge-clang-none | ? |
|
huge-gcc-none | ? |
|
huge-gcc-testgui | ? |
|
huge-gcc-unittests | 2.45% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/float.c | 0.00% <0.00%> (-99.22%) |
⬇️ |
src/gui_gtk_f.c | 0.00% <0.00%> (-97.54%) |
⬇️ |
src/crypt_zip.c | 0.00% <0.00%> (-97.06%) |
⬇️ |
src/match.c | 0.00% <0.00%> (-96.98%) |
⬇️ |
src/sha256.c | 0.00% <0.00%> (-96.94%) |
⬇️ |
src/evalbuffer.c | 0.00% <0.00%> (-96.92%) |
⬇️ |
src/textprop.c | 0.00% <0.00%> (-96.85%) |
⬇️ |
src/debugger.c | 0.00% <0.00%> (-96.62%) |
⬇️ |
src/libvterm/src/rect.h | 0.00% <0.00%> (-96.56%) |
⬇️ |
src/cmdhist.c | 0.00% <0.00%> (-96.49%) |
⬇️ |
... and 137 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 04626c2...756dc08. Read the comment docs.
@dpelle commented on this pull request.
In src/testdir/test_breakindent.vim:
> @@ -831,4 +831,22 @@ func Test_breakindent20_list() call s:close_windows('set breakindent& briopt& linebreak& list& listchars& showbreak&') endfunc +" The following used to crash Vim. This is fixed by 8.2.3391. +" This is a regression introduced by 8.2.2903.
Just confirming that the test caused vim-8.2.3390 to crash and latest vim-8.2.3394 does not crash on Linux x86_64.
Thanks.
@dpelle commented on this pull request.
In src/testdir/test_breakindent.vim:
> @@ -831,4 +831,22 @@ func Test_breakindent20_list() call s:close_windows('set breakindent& briopt& linebreak& list& listchars& showbreak&') endfunc +" The following used to crash Vim. This is fixed by 8.2.3391. +" This is a regression introduced by 8.2.2903.Just confirming that the test caused vim-8.2.3390 to crash and latest vim-8.2.3394 does not crash on Linux x86_64.
Thanks.
thanks!
—
You are receiving this because you commented.
Thanks for creating this test.
There is another check for n_extra becoming negative, and if I comment it out no test fails.
Perhaps you can manage to write a test for that one too?
This is in line 1215 of src/drawline.c
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub.
Thanks for creating this test.
There is another check for n_extra becoming negative, and if I comment it out no test fails.
Perhaps you can manage to write a test for that one too?
This is in line 1215 of src/drawline.c
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub.
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20210923070105.GB3729843%40256bit.org.