Node crash in DoubleToSmiInteger

[felipe...@gmail.com]

I'm not sure if this is the right audience, but I'm dealing with a rather strange problem. I'm working on a project using node on windows 10. I wrote an addon for node, wich loads a driver DLL. During initial tests, I load the dll and call its two basic functions, "GetDescription" and "GetVersion", both returing const char*s. Everything works fine, except for the fact the node server crashes after one second or so (even if I don't call any function). 

A little debugging and I got to the DoubleToSmiInteger function, its generating an unhandled exception when it gets a NAN double value. After I added a little test for NAN and rebuilt V8, everything seems to work fine. I'm still working on the details (such as why the NAN gets there), but I wanted to know more about the best course of action right now. Should I go all the way to submit a patch? Is this report enough? 

Thanks!

[Yang Guo]

Both filing a test and submitting a patch would be much appreciated!

Cheers,

Yang

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/dbe2ac7a-701a-4dbc-b893-c13a42e69e90%40googlegroups.com.

[felipe...@gmail.com]

Ok, thanks!

I'll have to put some more work to it, then. Since I'm modifying the function that is used to create numbers, its probably not a good idea to just add another "if", performance wise. 

Regards,

Zacani

On Thursday, July 25, 2019 at 3:53:30 AM UTC-3, Yang Guo wrote:

Both filing a test and submitting a patch would be much appreciated!

Cheers,

Yang

On Wed, Jul 24, 2019 at 11:52 PM <felipe...@gmail.com> wrote:

I'm not sure if this is the right audience, but I'm dealing with a rather strange problem. I'm working on a project using node on windows 10. I wrote an addon for node, wich loads a driver DLL. During initial tests, I load the dll and call its two basic functions, "GetDescription" and "GetVersion", both returing const char*s. Everything works fine, except for the fact the node server crashes after one second or so (even if I don't call any function). 

A little debugging and I got to the DoubleToSmiInteger function, its generating an unhandled exception when it gets a NAN double value. After I added a little test for NAN and rebuilt V8, everything seems to work fine. I'm still working on the details (such as why the NAN gets there), but I wanted to know more about the best course of action right now. Should I go all the way to submit a patch? Is this report enough? 

Thanks!

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to v8-...@googlegroups.com.

[felipe...@gmail.com]

Here's a link to the change I submitted:

https://chromium-review.googlesource.com/c/v8/v8/+/1721390/1

On Thursday, July 25, 2019 at 3:53:30 AM UTC-3, Yang Guo wrote:

Both filing a test and submitting a patch would be much appreciated!

Cheers,

Yang

On Wed, Jul 24, 2019 at 11:52 PM <felipe...@gmail.com> wrote:

I'm not sure if this is the right audience, but I'm dealing with a rather strange problem. I'm working on a project using node on windows 10. I wrote an addon for node, wich loads a driver DLL. During initial tests, I load the dll and call its two basic functions, "GetDescription" and "GetVersion", both returing const char*s. Everything works fine, except for the fact the node server crashes after one second or so (even if I don't call any function). 

A little debugging and I got to the DoubleToSmiInteger function, its generating an unhandled exception when it gets a NAN double value. After I added a little test for NAN and rebuilt V8, everything seems to work fine. I'm still working on the details (such as why the NAN gets there), but I wanted to know more about the best course of action right now. Should I go all the way to submit a patch? Is this report enough? 

Thanks!

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to v8-...@googlegroups.com.