Maglev:Adjuast condition bit code generation

24 views
Skip to first unread message

Yahan Lu

unread,
Sep 19, 2023, 10:23:57 PM9/19/23
to v8-dev
Hello everyone~
I want to port maglev to RISC-V, but there is no conditional bit code in RISC-V
So I need to remove the conditional bit code from the Maglev generic code.
I opened a CL (https://chromium-review.googlesource.com/c/v8/v8/+/4876814) to remove CompareInt32 and replace it with CompareInt32AndJumpIf.

If I can, I'll 
modify all cmp/assert in the maglev generic code.

Yahan Lu

unread,
Sep 20, 2023, 1:24:08 AM9/20/23
to v8-dev
Do you have any opinion?

Leszek Swirski

unread,
Sep 20, 2023, 4:29:43 AM9/20/23
to v8-...@googlegroups.com
This seems like a reasonable thing to do yes, I'll review your CL.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/ac54cfcc-b8e6-4362-b48a-52e38112e0a6n%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages