Changing Error Message and Respective Variables

[Ellison Chen]

Hello,

I'm new to the community and wanted to just change the spelling of a fallthrough error message, seen in this issue in the Node.js repo which suggests that the spelling should be corrected upstream, to v8.

I'm looking into changing the spelling of the error messages, however, without changing the respective variables from fallthru to fallthrough, it would make it more difficult to find the respective errors and/or error messages. 

I'm thinking it would be necessary that all instances of the term "fallthru" should be changed to "fallthrough" in order to resolve this issue.

Please let me know any thoughts, thanks!

[Clemens Backes]

As noted on the CL, I think renaming everything is the right fix.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/v8-dev/de8663d3-6749-4c95-86a7-26a31a5c89ebn%40googlegroups.com.

--

Clemens Backes

Software Engineer

clem...@google.com

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian   

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde.

This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.

[Jakob Kummerow]

Frankly, I don't think this is worth anyone's time. "fallthru" is a fairly common alternative spelling; people may disagree on whether they prefer it over the official spelling or not, but it's not a typo, not a bug, and not causing confusion; so just leave it. If you want to contribute to V8, that's great, but please find something more impactful than a spelling change.

[Marja Hölttä]

In addition to Jakob's point, changing error messages is often more work than we initially think, since dependencies (for V8, most importantly, Chromium) depend on error messages being a certain string, and require changes, e.g., updating the tests, when we change error messages. That's not how the world should be (ideally, nothing should depend on the exact wording of an error message), but that's how the world is.

On Mon, Jun 30, 2025 at 10:19 AM Ellison Chen <jialiang.e...@gmail.com> wrote:

--

--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/v8-dev/de8663d3-6749-4c95-86a7-26a31a5c89ebn%40googlegroups.com.

--

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian.

[Ellison Chen]

Good to know, thanks for the clarification! I appreciate the thorough explanation!