WriteUtf8V2

[Erik Corry]

The new WriteUtf8V2 only writes as many bytes as there is space for, but I'm not sure how to use this API.

If not all the characters were written, then how can the API user know how much of the input string was written? The argument that told the embedder how much was read has been removed. Instead, only the number of UTF 8 bytes written is returned. Is the embedder expected to use that number to reverse engineer how many characters were read?

It seems like this only works well if the output buffer is big enough to write the string in a single operation.

-- 

Erik Corry

[Erik Corry]

Would you be happy with a change that brings back the read-progress argument?

[Leszek Swirski]

In principle I don't see a reason why we couldn't add it back -- out of curiosity is there a reason you don't want to pre-size with Utf8Length? Some sort of streaming output maybe?

[Erik Corry]

Yes it's about being able to stream large strings.

Expect a code review :-).

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/v8-dev/e1546030-0411-40a4-b608-96a09bd298a6n%40googlegroups.com.

[Yagiz Nizipli]

Upon talkin with Erik, I've sent a patch to address this, and requested both of your reviews. Ref: https://chromium-review.googlesource.com/c/v8/v8/+/6276706