Fix to tools/gen-keywords-gen-h.py

29 views
Skip to first unread message

Jiading Guo

unread,
Dec 3, 2021, 10:50:22 AM12/3/21
to v8-dev
Hi all,

In `tools/gen-keywords-gen-h.py`[1]

if (IsInRange(len, MIN_WORD_LENGTH, MAX_WORD_LENGTH))

should be

if (base::IsInRange(len, MIN_WORD_LENGTH, MAX_WORD_LENGTH))

This commit[2] introduced base namespace but didn't change the python script accordingly. I read from doc[3] that merge request only accept severe bug fix, so I'll drop this tiny fix in the mailing list.

Regards,
Jiading

Jakob Gruber

unread,
Dec 6, 2021, 2:23:11 AM12/6/21
to v8-...@googlegroups.com
Thanks, please submit a CL. The 'merge request' you refer to means merging back to (beta/stable) branches.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/b527c561-b176-445a-af7d-e12aa0505ce7n%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages