Tick processor incorrectly processes 64-bit addresses

[Victor Homyakov]

Tick processor tries to track code pages for all logged addresses here

this.pages_[addr >>> CodeMap.PAGE_ALIGNMENT] = 1;

Unfortunately, this does not work correctly for 64-bit addresses: unsigned right shift first converts operand to a 32-bit integer, and only then makes the right shift. For example, calculated page for address 0xe6703e022a4 is 0x3e02, instead of 0xe6703e02. This may lead to errors in processed profile: tick address goes to the wrong page and is either not properly counted or not counted at all.

In case the tick-processor is still maintained, could someone of maintainers fix this problem?

[Jakob Gruber]

For this and the other issue, please file a bug at crbug.com/v8/new.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/432ac548-c39f-4088-b556-113cba23d31f%40googlegroups.com.