About review riscv64 files

[Yahan Lu]

Brice(brice...@futurewei.com) had added into RISCV_OWNERS file, but  Brice have no vote right to code review riscv64 files. For example : https://chromium-review.googlesource.com/c/v8/v8/+/2763963

 Can anyone give him code-riview right on riscv64 file?

[Yahan Lu]

Very grateful if someone helps me grateful.

Best wishes.

LuYahan

[Jakob Gruber]

+Michael Achenbach AFAIK you need committer status to set code review bits.

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/b093d490-f017-4ad8-852a-1b53acd42f5cn%40googlegroups.com.

[Yahan Lu]

Thanks jgruber

Are you mean that Brice is not a committer so can't code review?

[Michael Achenbach]

+Lutz Vahl who worked on the port-committer status. What is the current process for making brice...@futurewei.com a port committer?

Port committer ~= committer status to give CR+1, with the agreement to only change port files, e.g. *riscv*.*.

To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/9e00bc6e-5c27-4243-86f1-40c6bfa7f75cn%40googlegroups.com.

[Yahan Lu]

Thanks your help ~😁

在2021年4月8日星期四 UTC+8 下午7:59:07<Michael Achenbach> 写道：

+Lutz Vahl who worked on the port-committer status. What is the current process for making brice.dobry@futurewei.com a port committer?

To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscribe@googlegroups.com.