inspector_protocol serializable extra copy

12 views
Skip to first unread message

Hunter Laux

unread,
May 10, 2021, 9:48:04 PM5/10/21
to v8-dev
Any idea why this isn't being moved?
https://chromium.googlesource.com/v8/v8.git/+/refs/heads/master/third_party/inspector_protocol/crdtp/serializable.cc#21

- explicit PreSerialized(std::vector<uint8_t> bytes) : bytes_(bytes) {}
+ explicit PreSerialized(std::vector<uint8_t> bytes) : bytes_(std::move(bytes)) {}

Andreas Haas

unread,
May 12, 2021, 2:55:37 AM5/12/21
to v8-dev
Hi,

Thank you for the hint. It seems like we did not roll the latest version of the inspector protocol into V8.

Cheers, Andreas

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/4ab46791-489e-42ce-aca2-0d1333878474n%40googlegroups.com.

Yang Guo

unread,
May 12, 2021, 3:00:37 AM5/12/21
to v8-...@googlegroups.com, Andrey Kosyakov

Andrey Kosyakov

unread,
May 12, 2021, 1:10:41 PM5/12/21
to Yang Guo, v8-...@googlegroups.com
Thanks for head-up! Here goes the roll: https://chromium-review.googlesource.com/c/v8/v8/+/2892842

Reply all
Reply to author
Forward
0 new messages