Build failure on Mac
38 views
Skip to first unread message
Meir Shpilraien
Oct 18, 2023, 3:27:06 AM10/18/23
to v8-dev
Hey
Yesterday we started to see failure on our mac build on the main branch (which we do not see on official version). The failure:
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/torque_generated_definitions/js-collection-iterator-tq.o.d -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCR_XCODE_VERSION=1420 -DCR_CLANG_REVISION=\"llvmorg-18-init-7785-geef35c28-1\" -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 -DENABLE_GDB_JIT_INTERFACE -DV8_INTL_SUPPORT -DV8_ATOMIC_OBJECT_FIELD_WRITES -DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_SHARED_RO_HEAP -DV8_WIN64_UNWINDING_INFO -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH -DV8_SHORT_BUILTIN_CALLS -DV8_EXTERNAL_CODE_SPACE -DV8_ENABLE_SPARKPLUG -DV8_ENABLE_MAGLEV -DV8_ENABLE_TURBOFAN -DV8_ENABLE_SYSTEM_INSTRUMENTATION -DV8_ENABLE_WEBASSEMBLY -DV8_ALLOCATION_FOLDING -DV8_ALLOCATION_SITE_TRACKING -DV8_ADVANCED_BIGINT_ALGORITHMS -DV8_STATIC_ROOTS -DV8_USE_ZLIB -DV8_USE_LIBM_TRIG_FUNCTIONS -DV8_ENABLE_WASM_SIMD256_REVEC -DV8_ENABLE_MAGLEV_GRAPH_PRINTER -DV8_ENABLE_BUILTIN_JUMP_TABLE_SWITCH -DV8_ENABLE_EXTENSIBLE_RO_SNAPSHOT -DV8_COMPRESS_POINTERS -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS -DV8_IMMINENT_DEPRECATION_WARNINGS -DCPPGC_CAGED_HEAP -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION -DCPPGC_SLIM_WRITE_BARRIER -DV8_TARGET_ARCH_X64 -DV8_HAVE_TARGET_OS -DV8_TARGET_OS_MACOS -DV8_RUNTIME_CALL_STATS -DABSL_ALLOCATOR_NOTHROW=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I../../include -Igen/include -I../../third_party/abseil-cpp -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wno-deprecated-include-gch -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -femit-dwarf-unwind=no-compact-unwind -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -split-threshold-for-reg-with-hint=0 -ffp-contract=off -arch x86_64 -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -ffile-compilation-dir=. -no-canonical-prefixes -fno-omit-frame-pointer -g2 -gdwarf-aranges -Xclang -debug-info-kind=limited -isysroot ../../../../../../../../../Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk -mmacos-version-min=10.15 -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wmissing-field-initializers -Wunreachable-code -Wno-shadow -Wctad-maybe-unsupported -Wshorten-64-to-32 -Wno-invalid-offsetof -O3 -fno-math-errno -fvisibility=default -Wexit-time-destructors -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -c gen/torque-generated/src/objects/js-collection-iterator-tq.cc -o obj/torque_generated_definitions/js-collection-iterator-tq.o
In file included from gen/torque-generated/src/objects/js-collection-iterator-tq.cc:1:
In file included from ../../src/objects/js-collection-iterator-inl.h:8:
In file included from ../../src/objects/js-collection-iterator.h:9:
In file included from ../../src/objects/js-objects.h:10:
In file included from ../../src/objects/embedder-data-slot.h:12:
In file included from ../../src/objects/slots.h:11:
../../src/sandbox/external-pointer-table.h:379:26: error: implicit instantiation of undefined template 'std::vector<unsigned long>'
379 | std::vector<Address> invalidated_fields_;
| ^
../../../../../../../../../Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/c++/v1/iosfwd:259:28: note: template is declared here
259 | class _LIBCPP_TEMPLATE_VIS vector;
| ^
In file included from gen/torque-generated/src/objects/js-collection-iterator-tq.cc:1:
In file included from ../../src/objects/js-collection-iterator-inl.h:9:
In file included from ../../src/objects/objects-inl.h:24:
In file included from ../../src/heap/heap-write-barrier-inl.h:22:
In file included from ../../src/objects/slots-inl.h:18:
In file included from ../../src/sandbox/external-pointer-inl.h:11:
../../src/sandbox/external-pointer-table-inl.h:173:34: error: cannot initialize a parameter of type 'Space *' (aka 'v8::internal::ExternalEntityTable<v8::internal::ExternalPointerTableEntry, 1073741824>::Space *') with an lvalue of type 'Space *' (aka 'v8::internal::ExternalPointerTable::Space *')
173 | uint32_t index = AllocateEntry(space);
| ^~~~~
../../src/sandbox/external-entity-table.h:230:33: note: passing argument to parameter 'space' here
230 | uint32_t AllocateEntry(Space* space);
| ^
In file included from gen/torque-generated/src/objects/js-collection-iterator-tq.cc:1:
In file included from ../../src/objects/js-collection-iterator-inl.h:9:
In file included from ../../src/objects/objects-inl.h:24:
In file included from ../../src/heap/heap-write-barrier-inl.h:22:
In file included from ../../src/objects/slots-inl.h:18:
In file included from ../../src/sandbox/external-pointer-inl.h:11:
../../src/sandbox/external-pointer-table-inl.h:245:45: error: cannot initialize a parameter of type 'Space *' (aka 'v8::internal::ExternalEntityTable<v8::internal::ExternalPointerTableEntry, 1073741824>::Space *') with an lvalue of type 'Space *' (aka 'v8::internal::ExternalPointerTable::Space *')
245 | uint32_t new_index = AllocateEntryBelow(space, start_of_evacuation_area);
| ^~~~~
../../src/sandbox/external-entity-table.h:237:38: note: passing argument to parameter 'space' here
237 | uint32_t AllocateEntryBelow(Space* space, uint32_t threshold_index);
I was wondering if something got broken recently? Or maybe we are doing something wrong?
Thanks,
Meir
Clemens Backes
Oct 18, 2023, 4:59:26 AM10/18/23
to v8-...@googlegroups.com
Hi Meir,
this looks like a missing include of the vector header. I left a comment on the CL that introduced this code: https://crrev.com/c/4942593
-Clemens
--Disclaimer
The information contained in this communication from the sender is confidential. It is intended solely for use by the recipient and others authorized to receive it. If you are not the recipient, you are hereby notified that any disclosure, copying, distribution or taking action in relation of the contents of this information is strictly prohibited and may be unlawful.
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/2ef45388-4cdc-4cea-b332-b07851c85064n%40googlegroups.com.
Clemens Backes
Software Engineer
Google Germany GmbH
Erika-Mann-Straße 33
80636 München
Geschäftsführer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde.
This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.
Meir Shpilraien
Oct 22, 2023, 5:18:57 AM10/22/23
to v8-dev
Thank you, I can confirm that the fix solved the build failure.
Reply all
Reply to author
Forward
0 new messages