Inactive parties and addresses

[Xavier Codinas]

Hello,
When going to an inactive party and looking into it's addresses (which are inactive) those are not shown in the form view but other data is shown. Is this the expected behavior? IMHO, the addresses should be shown like the other data is.

Also, should the addresses be marked as inactive when the party is marked as inactive? For me, if you set the party to inactive all the related addresses should be set as inactive too, because they are no more needed.

Thoughts?

[Raimon Esteve]

El dia 17/11/2016 11.52, "Xavier Codinas" <xavie...@gmail.com> va escriure:

Same as dissable a product template and dissable all products

For me is a feature.

[Cédric Krier]

On 2016-11-17 02:36, Xavier Codinas wrote:
> Hello,
> When going to an inactive party and looking into it's addresses (which are
> inactive) those are not shown in the form view but other data is shown. Is
> this the expected behavior? IMHO, the addresses should be shown like the
> other data is.

Yes it is the expected behaviour because there is no information if the
addresses were inactivated at the same time as the party.

> Also, should the addresses be marked as inactive when the party is marked
> as inactive? For me, if you set the party to inactive all the related
> addresses should be set as inactive too, because they are no more needed.

I do not think addresses should be inactivated when the party is
inactivated. Because the address could be still needed to be searched on
document encoded prior to the inactivation of the party.
But indeed I think there could be improvement for the list of addresses
to not show the addresses of inactivated parties.

--
Cédric Krier - B2CK SPRL
Email/Jabber: cedric...@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/

[Xavier Codinas]

2016-11-17 14:12 GMT+01:00 Cédric Krier <cedric...@b2ck.com>:

On 2016-11-17 02:36, Xavier Codinas wrote:
> Hello,
> When going to an inactive party and looking into it's addresses (which are
> inactive) those are not shown in the form view but other data is shown. Is
> this the expected behavior? IMHO, the addresses should be shown like the
> other data is.

Yes it is the expected behaviour because there is no information if the
addresses were inactivated at the same time as the party. 

> Also, should the addresses be marked as inactive when the party is marked
> as inactive? For me, if you set the party to inactive all the related
> addresses should be set as inactive too, because they are no more needed.

I do not think addresses should be inactivated when the party is
inactivated. Because the address could be still needed to be searched on
document encoded prior to the inactivation of the party.

 

But indeed I think there could be improvement for the list of addresses
to not show the addresses of inactivated parties.

And how can that improvement be done? By adding a default search filter to address list?

 

--
Cédric Krier - B2CK SPRL
Email/Jabber: cedric...@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/

--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/20161117131226.GW16659%40tetsuo.

[Cédric Krier]

On 2016-11-18 13:13, Xavier Codinas wrote:
> 2016-11-17 14:12 GMT+01:00 Cédric Krier <cedric...@b2ck.com>:
> > But indeed I think there could be improvement for the list of addresses
> > to not show the addresses of inactivated parties.
> >
> > And how can that improvement be done? By adding a default search filter to
> address list?

I think it should be a little bit more complex. Because it should behave
like the current active test (being able to remove it) which a
domain/filter on the action will solve.
Probably it will require to extend the
ModelStorage._search_domain_active of Address.