Selected\focused row lost after search in log dialog regression (TSVN 1.10)

[gdal...@gmail.com]

Hi,
Started using TSVN 1.10 today.
Noticed a regression:
Often i use log dialog, search for something, find some old revision (row), select it and press the X\cross in search box. In previous version the selected row would stay selected and scrolled into view. This made it easy to find surrounding revisions.
In TSVN 1.10, when i press the X\cross in search box the row does not scroll into view, I have to scroll and find it manually. When I find it I see the row is greyed, so at does at least remember something about it.

regards
Gunnar

[Stefan Hett]

On 4/17/2018 12:53 PM,
tortoisesvn+APn2wQdzpxvvyinceji8...@googlegroups.com
wrote:

FWIW: Confirmed the behavior change as reported (old version was TSVN
1.9.7 - new one TSVN 1.10.0). I agree that the old behavior was better.

--
Regards,
Stefan Hett, Developer/Administrator

[Stefan]

When the log dialog first starts, the first revision is automatically selected.
And that selection is remembered. So when you filter, select, clear filter, it's still the first revision that's in the view because it was selected before.
If you Ctrl+click on the first revision to de-select it before you filter, the behavior is as you expect.

[Gunnar Dalsnes]

> --
> You received this message because you are subscribed to the Google
> Groups "TortoiseSVN" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to tortoisesvn...@googlegroups.com
> <mailto:tortoisesvn...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/tortoisesvn/d7145267-e5f0-4aa0-8530-b2888f85039d%40googlegroups.com
> <https://groups.google.com/d/msgid/tortoisesvn/d7145267-e5f0-4aa0-8530-b2888f85039d%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout.

Ctrl + click works. If this is by design, it is possible to add an
option to enable the original behavior? It would save me a lot of clicks.

Gunnar.

[Gunnar Dalsnes]

On 18.04.2018 20:32, Stefan via TortoiseSVN wrote:

> --
> You received this message because you are subscribed to the Google
> Groups "TortoiseSVN" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to tortoisesvn...@googlegroups.com
> <mailto:tortoisesvn...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/tortoisesvn/d7145267-e5f0-4aa0-8530-b2888f85039d%40googlegroups.com
> <https://groups.google.com/d/msgid/tortoisesvn/d7145267-e5f0-4aa0-8530-b2888f85039d%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout.

But I don't understand... Why isn't the selection changed when I click
the row I'm searching for? Its a bit strange that I must deselect
previous selected row manually before I select the new row...

Gunnar.

[Stefan]

But I don't understand... Why isn't the selection changed when I click
the row I'm searching for? Its a bit strange that I must deselect
previous selected row manually before I select the new row...

Well, before, you could search for something and then select. If you then searched for something else, that selection would be gone.
Now however, you can do multiple searches and selections and not lose the selections you've done before.

Stefan

[Gunnar Dalsnes]

> --
> You received this message because you are subscribed to the Google
> Groups "TortoiseSVN" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to tortoisesvn...@googlegroups.com
> <mailto:tortoisesvn...@googlegroups.com>.
> To view this discussion on the web visit

> https://groups.google.com/d/msgid/tortoisesvn/cec217a7-468e-4a99-b4c7-efd510524594%40googlegroups.com
> <https://groups.google.com/d/msgid/tortoisesvn/cec217a7-468e-4a99-b4c7-efd510524594%40googlegroups.com?utm_medium=email&utm_source=footer>.

> For more options, visit https://groups.google.com/d/optout.

I don't understand, you can multiselect in old TSVN too, by holding CTRL
while clicking... Now the logic is reversed?

But what about an option to configure this behaviour?

Gunnar.

[Stefan]

>     But I don't understand... Why isn't the selection changed when I

>     click
>     the row I'm searching for? Its a bit strange that I must deselect
>     previous selected row manually before I select the new row...

As I said: you search for something, then select it.
You clear the search filter, and all your selections are kept.
Now you search for something different, and select something else.
You clear the search filter again, and all your selections from before are kept as well, meaning you have now both selections from the first search and the second one.

So now, when you start entering something in the filter box, the selections are stored. Then with the active filter, you select something and that selection is added to the selection that was there before you started filtering.

The selection process itself hasn't changed: you still need to use Ctrl+Click to do multi-selections. And while a filter is active and no filter is active, a simple click will select one item and deselect the others. But when changing filter/no-filter, the selections are kept.

Stefan