KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets (3)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 133d9c53c9dc Merge tag 'x86_vdso_for_v5.17_rc1' of git://g..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=137b1e5fb00000
kernel config: https://syzkaller.appspot.com/x/.config?x=2f2c70f591694234
dashboard link: https://syzkaller.appspot.com/bug?extid=d1e4c3c0853cdc51ffdc
compiler: Debian clang version 11.0.1-2, GNU ld (GNU Binutils for Debian) 2.35.2
CC: [Ja...@zx2c4.com da...@davemloft.net ku...@kernel.org linux-...@vger.kernel.org net...@vger.kernel.org wire...@lists.zx2c4.com]

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+d1e4c3...@syzkaller.appspotmail.com

==================================================================
BUG: KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets

read to 0xffff8881345fda48 of 4 bytes by interrupt on cpu 1:
wg_cpumask_next_online drivers/net/wireguard/queueing.h:131 [inline]
wg_queue_enqueue_per_device_and_peer drivers/net/wireguard/queueing.h:178 [inline]
wg_packet_create_data drivers/net/wireguard/send.c:320 [inline]
wg_packet_send_staged_packets+0x41a/0x800 drivers/net/wireguard/send.c:387
wg_packet_send_keepalive+0xfc/0x110 drivers/net/wireguard/send.c:239
wg_expired_send_persistent_keepalive+0x38/0x50 drivers/net/wireguard/timers.c:141
call_timer_fn+0x2e/0x240 kernel/time/timer.c:1421
expire_timers+0x116/0x240 kernel/time/timer.c:1466
__run_timers+0x368/0x410 kernel/time/timer.c:1734
run_timer_softirq+0x2e/0x60 kernel/time/timer.c:1747
__do_softirq+0x158/0x2de kernel/softirq.c:558
__irq_exit_rcu kernel/softirq.c:637 [inline]
irq_exit_rcu+0x37/0x70 kernel/softirq.c:649
sysvec_apic_timer_interrupt+0x8d/0xb0 arch/x86/kernel/apic/apic.c:1097
asm_sysvec_apic_timer_interrupt+0x12/0x20
native_safe_halt arch/x86/include/asm/irqflags.h:51 [inline]
arch_safe_halt arch/x86/include/asm/irqflags.h:89 [inline]
acpi_safe_halt drivers/acpi/processor_idle.c:109 [inline]
acpi_idle_do_entry drivers/acpi/processor_idle.c:553 [inline]
acpi_idle_enter+0x282/0x300 drivers/acpi/processor_idle.c:688
cpuidle_enter_state+0x2b4/0x7d0 drivers/cpuidle/cpuidle.c:237
cpuidle_enter+0x3c/0x60 drivers/cpuidle/cpuidle.c:351
call_cpuidle kernel/sched/idle.c:158 [inline]
cpuidle_idle_call kernel/sched/idle.c:239 [inline]
do_idle+0x1b2/0x250 kernel/sched/idle.c:306
cpu_startup_entry+0x15/0x20 kernel/sched/idle.c:403
secondary_startup_64_no_verify+0xc4/0xcb

write to 0xffff8881345fda48 of 4 bytes by interrupt on cpu 0:
wg_cpumask_next_online drivers/net/wireguard/queueing.h:135 [inline]
wg_queue_enqueue_per_device_and_peer drivers/net/wireguard/queueing.h:178 [inline]
wg_packet_create_data drivers/net/wireguard/send.c:320 [inline]
wg_packet_send_staged_packets+0x455/0x800 drivers/net/wireguard/send.c:387
wg_packet_send_keepalive+0xfc/0x110 drivers/net/wireguard/send.c:239
wg_expired_send_persistent_keepalive+0x38/0x50 drivers/net/wireguard/timers.c:141
call_timer_fn+0x2e/0x240 kernel/time/timer.c:1421
expire_timers+0x116/0x240 kernel/time/timer.c:1466
__run_timers+0x368/0x410 kernel/time/timer.c:1734
run_timer_softirq+0x2e/0x60 kernel/time/timer.c:1747
__do_softirq+0x158/0x2de kernel/softirq.c:558
__irq_exit_rcu kernel/softirq.c:637 [inline]
irq_exit_rcu+0x37/0x70 kernel/softirq.c:649
sysvec_apic_timer_interrupt+0x8d/0xb0 arch/x86/kernel/apic/apic.c:1097
asm_sysvec_apic_timer_interrupt+0x12/0x20
native_safe_halt arch/x86/include/asm/irqflags.h:51 [inline]
arch_safe_halt arch/x86/include/asm/irqflags.h:89 [inline]
acpi_safe_halt drivers/acpi/processor_idle.c:109 [inline]
acpi_idle_do_entry drivers/acpi/processor_idle.c:553 [inline]
acpi_idle_enter+0x282/0x300 drivers/acpi/processor_idle.c:688
cpuidle_enter_state+0x2b4/0x7d0 drivers/cpuidle/cpuidle.c:237
cpuidle_enter+0x3c/0x60 drivers/cpuidle/cpuidle.c:351
call_cpuidle kernel/sched/idle.c:158 [inline]
cpuidle_idle_call kernel/sched/idle.c:239 [inline]
do_idle+0x1b2/0x250 kernel/sched/idle.c:306
cpu_startup_entry+0x15/0x20 kernel/sched/idle.c:403
rest_init+0xfa/0x100 init/main.c:725
arch_call_rest_init+0xa/0xb
start_kernel+0x5e4/0x669 init/main.c:1135
secondary_startup_64_no_verify+0xc4/0xcb

value changed: 0x00000001 -> 0x00000000

Reported by Kernel Concurrency Sanitizer on:
CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.16.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
==================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[Marco Elver]

#syz upstream

> --
> You received this message because you are subscribed to the Google Groups "syzkaller-upstream-moderation" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-upstream-m...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-upstream-moderation/00000000000016e5aa05d54e5c1c%40google.com.