assert "p == curproc" failed in vfs_vops.c

[syzbot]

Hello,

syzbot found the following crash on:

HEAD commit: f16a14f2 Log summary of IKE SA for established policy.
git tree: openbsd
console output: https://syzkaller.appspot.com/x/log.txt?x=11248b83e00000
kernel config: https://syzkaller.appspot.com/x/.config?x=bf87b6915a88cd0d
dashboard link: https://syzkaller.appspot.com/bug?extid=11f9f4bfcc5b5e90acc1

Unfortunately, I don't have any reproducer for this crash yet.

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+11f9f4...@syzkaller.appspotmail.com

login: panic: kernel diagnostic assertion "p == curproc" failed: file "/syzkaller/managers/setuid/kernel/sys/kern/vfs_vops.c", line 169
Stopped at db_enter+0x18: addq $0x8,%rsp
TID PID UID PRFLAGS PFLAGS CPU COMMAND
336413 16007 0 0x14000 0x200 1 reaper
*220028 90952 0 0x14000 0x200 0K systq
db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:398
panic(ffffffff821efc13) at panic+0x15c sys/kern/subr_prf.c:207
__assert(ffffffff82249f12,ffffffff822695b4,a9,ffffffff8222b23a) at __assert+0x2b sys/kern/subr_prf.c:154
VOP_CLOSE(fffffd8067bde420,1,fffffd807f7bf840,0) at VOP_CLOSE+0x12f sys/kern/vfs_vops.c:170
vn_closefile(fffffd80691f36a0,0) at vn_closefile+0xd7 vn_close sys/kern/vfs_vnops.c:298 [inline]
vn_closefile(fffffd80691f36a0,0) at vn_closefile+0xd7 sys/kern/vfs_vnops.c:614
fdrop(fffffd80691f36a0,0) at fdrop+0xc2 sys/kern/kern_descrip.c:1276
closef(fffffd80691f36a0,0) at closef+0x11c sys/kern/kern_descrip.c:1260
unp_gc(0) at unp_gc+0x172 sys/kern/uipc_usrreq.c:944
taskq_thread(ffffffff8251f4f0) at taskq_thread+0x9c sys/kern/kern_task.c:369
end trace frame: 0x0, count: 6
https://www.openbsd.org/ddb.html describes the minimum info required in bug
reports. Insufficient info makes it difficult to find and fix bugs.
ddb{0}>
ddb{0}> set $lines = 0
ddb{0}> set $maxwidth = 0
ddb{0}> show panic
kernel diagnostic assertion "p == curproc" failed: file "/syzkaller/managers/setuid/kernel/sys/kern/vfs_vops.c", line 169
ddb{0}> trace
db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:398
panic(ffffffff821efc13) at panic+0x15c sys/kern/subr_prf.c:207
__assert(ffffffff82249f12,ffffffff822695b4,a9,ffffffff8222b23a) at __assert+0x2b sys/kern/subr_prf.c:154
VOP_CLOSE(fffffd8067bde420,1,fffffd807f7bf840,0) at VOP_CLOSE+0x12f sys/kern/vfs_vops.c:170
vn_closefile(fffffd80691f36a0,0) at vn_closefile+0xd7 vn_close sys/kern/vfs_vnops.c:298 [inline]
vn_closefile(fffffd80691f36a0,0) at vn_closefile+0xd7 sys/kern/vfs_vnops.c:614
fdrop(fffffd80691f36a0,0) at fdrop+0xc2 sys/kern/kern_descrip.c:1276
closef(fffffd80691f36a0,0) at closef+0x11c sys/kern/kern_descrip.c:1260
unp_gc(0) at unp_gc+0x172 sys/kern/uipc_usrreq.c:944
taskq_thread(ffffffff8251f4f0) at taskq_thread+0x9c sys/kern/kern_task.c:369
end trace frame: 0x0, count: -9
ddb{0}> show registers
rdi 0
rsi 0x1
rbp 0xffff800020a2d890
rbx 0xffff800020a2d940
rdx 0xffff800020a18750
rcx 0
rax 0
r8 0xffffffff810939af kprintf+0x16f
r9 0x1
r10 0x25
r11 0x3fb4880d214f72a7
r12 0x3000000008
r13 0xffff800020a2d8a0
r14 0x100
r15 0x1
rip 0xffffffff81146c58 db_enter+0x18
cs 0x8
rflags 0x246
rsp 0xffff800020a2d880
ss 0x10
db_enter+0x18: addq $0x8,%rsp
ddb{0}> show proc
PROC (systq) pid=220028 stat=onproc
flags process=14000<NOZOMBIE,SYSTEM> proc=200<SYSTEM>
pri=32, usrpri=50, nice=20
forw=0xffffffffffffffff, list=0xffff800020a19380,0xffff800020a184f0
process=0xffff800020a1a000 user=0xffff800020a28000, vmspace=0xffffffff8266bc88
estcpu=0, cpticks=1, pctcpu=0.0
user=0, sys=1, intr=0
ddb{0}> ps
PID TID PPID UID S FLAGS WAIT COMMAND
75248 14483 48095 32767 2 0x10 syz-executor.1
75248 465915 48095 32767 3 0x4000090 fsleep syz-executor.1
51032 150357 46933 32767 2 0x490 syz-executor.0
48095 351827 49913 32767 3 0x90 nanosleep syz-executor.1
49913 399397 25236 0 3 0x82 wait syz-executor.1
46933 49590 25236 0 3 0x82 wait syz-executor.0
25236 24351 95201 0 3 0x82 thrsleep syz-fuzzer
25236 128380 95201 0 2 0x4000482 syz-fuzzer
25236 163262 95201 0 3 0x4000082 thrsleep syz-fuzzer
25236 346450 95201 0 3 0x4000082 thrsleep syz-fuzzer
25236 36607 95201 0 3 0x4000082 thrsleep syz-fuzzer
25236 441984 95201 0 3 0x4000082 kqread syz-fuzzer
25236 452466 95201 0 3 0x4000082 thrsleep syz-fuzzer
25236 347900 95201 0 3 0x4000082 thrsleep syz-fuzzer
25236 417586 95201 0 3 0x4000082 thrsleep syz-fuzzer
25236 222459 95201 0 3 0x4000082 thrsleep syz-fuzzer
95201 270812 2698 0 3 0x10008a pause ksh
2698 347398 35269 0 3 0x92 select sshd
95710 503997 1 0 3 0x100083 ttyin getty
35269 466243 1 0 3 0x80 select sshd
78149 480830 38363 73 3 0x100090 kqread syslogd
38363 146582 1 0 3 0x100082 netio syslogd
28202 227836 1 77 3 0x100090 poll dhclient
63014 412627 1 0 3 0x80 poll dhclient
65295 479663 0 0 3 0x14200 bored smr
47167 235388 0 0 3 0x14200 pgzero zerothread
17733 137628 0 0 3 0x14200 aiodoned aiodoned
58726 149685 0 0 3 0x14200 syncer update
1535 3943 0 0 3 0x14200 cleaner cleaner
16007 336413 0 0 7 0x14200 reaper
22115 26754 0 0 3 0x14200 pgdaemon pagedaemon
94842 143546 0 0 3 0x14200 bored crynlk
12350 52099 0 0 3 0x14200 bored crypto
75237 110096 0 0 3 0x40014200 acpi0 acpi0
46362 354832 0 0 3 0x40014200 idle1
66064 195685 0 0 3 0x14200 bored softnet
16527 111340 0 0 3 0x14200 bored systqmp
*90952 220028 0 0 7 0x14200 systq
61558 172658 0 0 3 0x40014200 bored softclock
8972 415650 0 0 3 0x40014200 idle0
1 490484 0 0 3 0x82 wait init
0 0 -1 0 3 0x10200 scheduler swapper
ddb{0}> show all locks
Process 90952 (systq) thread 0xffff800020a18750 (220028)
exclusive rrwlock inode r = 0 (0xfffffd80668266f8)
#0 witness_lock+0x4c5 sys/kern/subr_witness.c:1164
#1 rw_enter+0x453 sys/kern/kern_rwlock.c:311
#2 rrw_enter+0x88 sys/kern/kern_rwlock.c:462
#3 VOP_LOCK+0x4b sys/kern/vfs_vops.c:613
#4 vn_lock+0x81 sys/kern/vfs_vnops.c:575
#5 vn_closefile+0xc6 vn_close sys/kern/vfs_vnops.c:298 [inline]
#5 vn_closefile+0xc6 sys/kern/vfs_vnops.c:614
#6 fdrop+0xc2 sys/kern/kern_descrip.c:1276
#7 closef+0x11c sys/kern/kern_descrip.c:1260
#8 unp_gc+0x172 sys/kern/uipc_usrreq.c:944
#9 taskq_thread+0x9c sys/kern/kern_task.c:369
#10 proc_trampoline+0x1c
shared rwlock systq r = 0 (0xffffffff8251f550)
#0 witness_lock+0x4c5 sys/kern/subr_witness.c:1164
#1 taskq_thread+0x8f sys/kern/kern_task.c:368
#2 proc_trampoline+0x1c
exclusive kernel_lock &kernel_lock r = 1 (0xffffffff8263a520)
#0 witness_lock+0x4c5 sys/kern/subr_witness.c:1164
#1 __mp_acquire_count+0x51 sys/kern/kern_lock.c:227
#2 mi_switch+0x392 sys/kern/sched_bsd.c:435
#3 sleep_finish+0x113 sys/kern/kern_synch.c:417
#4 sleep_finish_all+0x32 sleep_finish_timeout sys/kern/kern_synch.c:446 [inline]
#4 sleep_finish_all+0x32 sys/kern/kern_synch.c:206
#5 msleep+0x20e sys/kern/kern_synch.c:273
#6 taskq_next_work+0xbe sys/kern/kern_task.c:323
#7 taskq_thread+0xe5 sys/kern/kern_task.c:366
#8 proc_trampoline+0x1c
ddb{0}> show malloc
Type InUse MemUse HighUse Limit Requests Type Lim
devbuf 9465 6331K 6331K 78643K 10556 0
pcb 13 8K 8K 78643K 13 0
rtable 105 3K 3K 78643K 189 0
ifaddr 39 10K 10K 78643K 39 0
counters 43 33K 33K 78643K 43 0
ioctlops 0 0K 2K 78643K 15 0
mount 1 1K 1K 78643K 1 0
vnodes 1216 76K 76K 78643K 1221 0
UFS quota 1 32K 32K 78643K 1 0
UFS mount 5 36K 36K 78643K 5 0
shm 2 1K 1K 78643K 2 0
VM map 2 1K 1K 78643K 2 0
sem 12 0K 0K 78643K 28 0
dirhash 12 2K 2K 78643K 12 0
ACPI 1809 196K 290K 78643K 12766 0
file desc 7 21K 33K 78643K 124 0
proc 48 50K 83K 78643K 359 0
subproc 34 2K 2K 78643K 34 0
NFS srvsock 1 0K 0K 78643K 1 0
NFS daemon 1 16K 16K 78643K 1 0
in_multi 33 2K 2K 78643K 33 0
ether_multi 1 0K 0K 78643K 1 0
ISOFS mount 1 32K 32K 78643K 1 0
MSDOSFS mount 1 16K 16K 78643K 1 0
ttys 31 148K 148K 78643K 31 0
exec 0 0K 1K 78643K 181 0
pagedep 1 8K 8K 78643K 1 0
inodedep 1 32K 32K 78643K 1 0
newblk 1 0K 0K 78643K 1 0
VM swap 7 26K 26K 78643K 7 0
UVM amap 85 20K 21K 78643K 1095 0
UVM aobj 2 2K 2K 78643K 2 0
memdesc 1 4K 4K 78643K 1 0
crypto data 1 1K 1K 78643K 1 0
ip6_options 0 0K 0K 78643K 28 0
NDP 5 0K 0K 78643K 9 0
temp 62 3035K 3099K 78643K 2004 0
kqueue 3 4K 10K 78643K 18 0
SYN cache 2 16K 16K 78643K 2 0
ddb{0}> show all pools
Name Size Requests Fail Releases Pgreq Pgrel Npage Hiwat Minpg Maxpg Idle
arp 64 6 0 0 1 0 1 1 0 8 0
plcache 128 20 0 0 1 0 1 1 0 8 0
rtpcb 80 19 0 17 1 0 1 1 0 8 0
rtentry 112 45 0 1 2 0 2 2 0 8 0
unpcb 120 73 0 63 1 0 1 1 0 8 0
syncache 264 4 0 4 1 1 0 1 0 8 0
tcpqe 32 11 0 11 2 2 0 1 0 8 0
tcpcb 544 38 0 33 1 0 1 1 0 8 0
inpcb 280 95 0 86 1 0 1 1 0 8 0
nd6 48 6 0 0 1 0 1 1 0 8 0
art_heap8 4096 1 0 0 1 0 1 1 0 8 0
art_heap4 256 188 0 0 12 0 12 12 0 8 0
art_table 32 189 0 0 2 0 2 2 0 8 0
art_node 16 44 0 4 1 0 1 1 0 8 0
semapl 112 26 0 16 1 0 1 1 0 8 0
dirhash 1024 17 0 0 3 0 3 3 0 8 0
dino1pl 128 1526 0 127 46 0 46 46 0 8 0
ffsino 272 1526 0 127 94 0 94 94 0 8 0
nchpl 144 1862 0 252 60 0 60 60 0 8 0
uvmvnodes 72 1569 0 0 29 0 29 29 0 8 0
vnodes 208 1569 0 0 83 0 83 83 0 8 0
namei 1024 4363 0 4363 1 0 1 1 0 8 1
percpumem 16 32 0 0 1 0 1 1 0 8 0
scxspl 192 5738 0 5738 7 1 6 6 0 8 6
plimitpl 152 16 0 7 1 0 1 1 0 8 0
sigapl 424 311 0 280 4 0 4 4 0 8 0
futexpl 56 1162 0 1161 1 0 1 1 0 8 0
knotepl 112 69 0 50 1 0 1 1 0 8 0
kqueuepl 144 67 0 65 1 0 1 1 0 8 0
pipelkpl 48 65 0 55 1 0 1 1 0 8 0
pipepl 120 130 0 111 1 0 1 1 0 8 0
fdescpl 496 296 0 280 3 0 3 3 0 8 0
filepl 152 1309 0 1207 5 0 5 5 0 8 1
lockfpl 104 83 0 82 1 0 1 1 0 8 0
lockfspl 48 30 0 29 1 0 1 1 0 8 0
sessionpl 112 17 0 7 1 0 1 1 0 8 0
pgrppl 48 17 0 7 1 0 1 1 0 8 0
ucredpl 96 61 0 52 1 0 1 1 0 8 0
zombiepl 144 280 0 279 1 0 1 1 0 8 0
processpl 984 311 0 279 5 0 5 5 0 8 0
procpl 624 444 0 401 4 0 4 4 0 8 0
sockpl 400 187 0 166 3 0 3 3 0 8 0
mcl9k 9216 16 0 0 2 0 2 2 0 8 0
mcl4k 4096 3 0 0 1 0 1 1 0 8 0
mcl2k 2048 112 0 0 13 0 13 13 0 8 0
mtagpl 80 1 0 0 1 0 1 1 0 8 0
mbufpl 256 216 0 0 14 1 13 13 0 8 0
bufpl 280 4289 0 165 295 0 295 295 0 8 0
anonpl 16 32614 0 29807 17 1 16 16 0 124 1
amapchunkpl 152 1353 0 1262 6 0 6 6 0 158 1
amappl16 192 696 0 593 9 0 9 9 0 8 3
amappl15 184 92 0 85 2 1 1 1 0 8 0
amappl14 176 3 0 2 2 1 1 1 0 8 0
amappl13 168 24 0 23 1 0 1 1 0 8 0
amappl12 160 8 0 8 1 1 0 1 0 8 0
amappl11 152 66 0 53 1 0 1 1 0 8 0
amappl10 144 15 0 10 1 0 1 1 0 8 0
amappl9 136 400 0 394 1 0 1 1 0 8 0
amappl8 128 320 0 303 1 0 1 1 0 8 0
amappl7 120 105 0 94 1 0 1 1 0 8 0
amappl6 112 21 0 19 1 0 1 1 0 8 0
amappl5 104 283 0 270 1 0 1 1 0 8 0
amappl4 96 438 0 411 1 0 1 1 0 8 0
amappl3 88 132 0 124 1 0 1 1 0 8 0
amappl2 80 1584 0 1509 3 1 2 3 0 8 0
amappl1 72 15189 0 14736 24 10 14 20 0 8 4
amappl 80 655 0 617 1 0 1 1 0 84 0
dma4096 4096 1 0 1 1 1 0 1 0 8 0
dma256 256 6 0 6 1 1 0 1 0 8 0
dma128 128 253 0 253 1 1 0 1 0 8 0
dma64 64 6 0 6 1 1 0 1 0 8 0
dma32 32 7 0 7 1 1 0 1 0 8 0
dma16 16 18 0 17 1 0 1 1 0 8 0
aobjpl 64 1 0 0 1 0 1 1 0 8 0
uaddrrnd 24 296 0 279 1 0 1 1 0 8 0
uaddrbest 32 2 0 0 1 0 1 1 0 8 0
uaddr 24 296 0 279 1 0 1 1 0 8 0
vmmpekpl 168 5905 0 5873 2 0 2 2 0 8 0
vmmpepl 168 41204 0 39819 82 9 73 77 0 357 12
vmsppl 368 295 0 279 2 0 2 2 0 8 0
pdppl 4096 600 0 558 6 0 6 6 0 8 0
pvpl 32 141582 0 135617 115 4 111 115 0 265 59
pmappl 232 295 0 279 2 0 2 2 0 8 1
extentpl 40 46 0 29 1 0 1 1 0 8 0
phpool 112 157 0 3 5 0 5 5 0 8 0


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[Greg Steuck]

Looks like syzkaller respectfully disagrees with your assertion :)

Document that `a_p' is always curproc by using a KASSERT().

This will allows for future simplifications of the VFS interfaces.

Tested in a bulk by naddy@ and visa@.

ok visa@, anton@

--
You received this message because you are subscribed to the Google Groups "syzkaller-openbsd-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-openbsd...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-openbsd-bugs/000000000000b5240705a219feda%40google.com.

--

nest.cx is Gmail hosted, use PGP: https://pgp.key-server.io/0x0B1542BD8DF5A1B0
Fingerprint: 5E2B 2D0E 1E03 2046 BEC3  4D50 0B15 42BD 8DF5 A1B0

[Greg Steuck]

+mpi for real.

[syzbot]

syzbot has found a reproducer for the following crash on:

HEAD commit: f16a14f2 Log summary of IKE SA for established policy.
git tree: openbsd

console output: https://syzkaller.appspot.com/x/log.txt?x=1716bedbe00000

kernel config: https://syzkaller.appspot.com/x/.config?x=bf87b6915a88cd0d
dashboard link: https://syzkaller.appspot.com/bug?extid=11f9f4bfcc5b5e90acc1

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=172a26bde00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17dcdadbe00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+11f9f4...@syzkaller.appspotmail.com

login: panic: kernel diagnostic assertion "p == curproc" failed: file "/syzkaller/managers/setuid/kernel/sys/kern/vfs_vops.c", line 169
Stopped at db_enter+0x18: addq $0x8,%rsp
TID PID UID PRFLAGS PFLAGS CPU COMMAND

248917 34785 0 0x14000 0x200 1 reaper
*248599 25948 0 0x14000 0x200 0K systq

db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:398
panic(ffffffff821efc13) at panic+0x15c sys/kern/subr_prf.c:207
__assert(ffffffff82249f12,ffffffff822695b4,a9,ffffffff8222b23a) at __assert+0x2b sys/kern/subr_prf.c:154

VOP_CLOSE(fffffd806f21b760,1,fffffd807f7bfc60,0) at VOP_CLOSE+0x12f sys/kern/vfs_vops.c:170
vn_closefile(fffffd8070ffba18,0) at vn_closefile+0xd7 vn_close sys/kern/vfs_vnops.c:298 [inline]
vn_closefile(fffffd8070ffba18,0) at vn_closefile+0xd7 sys/kern/vfs_vnops.c:614
fdrop(fffffd8070ffba18,0) at fdrop+0xc2 sys/kern/kern_descrip.c:1276
closef(fffffd8070ffba18,0) at closef+0x11c sys/kern/kern_descrip.c:1260

unp_gc(0) at unp_gc+0x172 sys/kern/uipc_usrreq.c:944
taskq_thread(ffffffff8251f4f0) at taskq_thread+0x9c sys/kern/kern_task.c:369
end trace frame: 0x0, count: 6
https://www.openbsd.org/ddb.html describes the minimum info required in bug
reports. Insufficient info makes it difficult to find and fix bugs.
ddb{0}>
ddb{0}> set $lines = 0
ddb{0}> set $maxwidth = 0
ddb{0}> show panic
kernel diagnostic assertion "p == curproc" failed: file "/syzkaller/managers/setuid/kernel/sys/kern/vfs_vops.c", line 169
ddb{0}> trace
db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:398
panic(ffffffff821efc13) at panic+0x15c sys/kern/subr_prf.c:207
__assert(ffffffff82249f12,ffffffff822695b4,a9,ffffffff8222b23a) at __assert+0x2b sys/kern/subr_prf.c:154

VOP_CLOSE(fffffd806f21b760,1,fffffd807f7bfc60,0) at VOP_CLOSE+0x12f sys/kern/vfs_vops.c:170
vn_closefile(fffffd8070ffba18,0) at vn_closefile+0xd7 vn_close sys/kern/vfs_vnops.c:298 [inline]
vn_closefile(fffffd8070ffba18,0) at vn_closefile+0xd7 sys/kern/vfs_vnops.c:614
fdrop(fffffd8070ffba18,0) at fdrop+0xc2 sys/kern/kern_descrip.c:1276
closef(fffffd8070ffba18,0) at closef+0x11c sys/kern/kern_descrip.c:1260

unp_gc(0) at unp_gc+0x172 sys/kern/uipc_usrreq.c:944
taskq_thread(ffffffff8251f4f0) at taskq_thread+0x9c sys/kern/kern_task.c:369
end trace frame: 0x0, count: -9
ddb{0}> show registers
rdi 0
rsi 0x1

rbp 0xffff800020a2d4b0
rbx 0xffff800020a2d560
rdx 0x8b
rcx 0x2
rax 0x1

r8 0xffffffff810939af kprintf+0x16f
r9 0x1

r10 0xdd85003a929adf08
r11 0x88e97f6c4ff34f0
r12 0x3000000008
r13 0xffff800020a2d4c0

r14 0x100
r15 0x1
rip 0xffffffff81146c58 db_enter+0x18
cs 0x8
rflags 0x246

rsp 0xffff800020a2d4a0

ss 0x10
db_enter+0x18: addq $0x8,%rsp
ddb{0}> show proc

PROC (systq) pid=248599 stat=onproc

flags process=14000<NOZOMBIE,SYSTEM> proc=200<SYSTEM>
pri=32, usrpri=50, nice=20

forw=0xffffffffffffffff, list=0xffff800020a19380,0xffff800020a18eb0
process=0xffff800020a1a3d8 user=0xffff800020a28000, vmspace=0xffffffff8266bc88

estcpu=0, cpticks=1, pctcpu=0.0
user=0, sys=1, intr=0
ddb{0}> ps
PID TID PPID UID S FLAGS WAIT COMMAND

3653 408801 73578 0 3 0x82 nanosleep syz-executor2256
73578 143601 18192 0 3 0x10008a pause ksh
18192 389791 17759 0 3 0x92 select sshd
15854 177370 1 0 3 0x100083 ttyin getty
17759 140788 1 0 3 0x80 select sshd
78536 289493 91039 73 3 0x100090 kqread syslogd
91039 6034 1 0 3 0x100082 netio syslogd
27688 95189 1 77 3 0x100090 poll dhclient
85526 117305 1 0 3 0x80 poll dhclient
17775 434653 0 0 3 0x14200 bored smr
32282 274022 0 0 3 0x14200 pgzero zerothread
15552 332751 0 0 3 0x14200 aiodoned aiodoned
40877 139992 0 0 3 0x14200 syncer update
30751 441465 0 0 3 0x14200 cleaner cleaner
34785 248917 0 0 7 0x14200 reaper
7852 180542 0 0 3 0x14200 pgdaemon pagedaemon
22981 488131 0 0 3 0x14200 bored crynlk
65125 385126 0 0 3 0x14200 bored crypto
3661 406376 0 0 3 0x40014200 acpi0 acpi0
83135 245926 0 0 3 0x40014200 idle1
76229 183379 0 0 3 0x14200 bored softnet
74575 322298 0 0 3 0x14200 bored systqmp
*25948 248599 0 0 7 0x14200 systq
79632 469649 0 0 2 0x40014200 softclock
21513 159318 0 0 3 0x40014200 idle0
1 342969 0 0 3 0x82 wait init

0 0 -1 0 3 0x10200 scheduler swapper
ddb{0}> show all locks

Process 25948 (systq) thread 0xffff800020a19110 (248599)
exclusive rrwlock inode r = 0 (0xfffffd806f223818)

devbuf 9455 6326K 6327K 78643K 10546 0

pcb 13 8K 8K 78643K 13 0

rtable 61 2K 2K 78643K 117 0
ifaddr 24 7K 7K 78643K 24 0
counters 39 33K 33K 78643K 39 0
ioctlops 0 0K 2K 78643K 13 0

mount 1 1K 1K 78643K 1 0

vnodes 1182 74K 74K 78643K 1187 0

UFS quota 1 32K 32K 78643K 1 0
UFS mount 5 36K 36K 78643K 5 0
shm 2 1K 1K 78643K 2 0
VM map 2 1K 1K 78643K 2 0

sem 2 0K 0K 78643K 2 0

dirhash 12 2K 2K 78643K 12 0
ACPI 1809 196K 290K 78643K 12766 0

file desc 1 0K 0K 78643K 1 0
proc 47 50K 58K 78643K 278 0

NFS srvsock 1 0K 0K 78643K 1 0
NFS daemon 1 16K 16K 78643K 1 0

in_multi 11 0K 0K 78643K 11 0

ether_multi 1 0K 0K 78643K 1 0
ISOFS mount 1 32K 32K 78643K 1 0
MSDOSFS mount 1 16K 16K 78643K 1 0

ttys 19 95K 95K 78643K 19 0
exec 0 0K 1K 78643K 151 0

pagedep 1 8K 8K 78643K 1 0
inodedep 1 32K 32K 78643K 1 0
newblk 1 0K 0K 78643K 1 0
VM swap 7 26K 26K 78643K 7 0

UVM amap 54 2K 3K 78643K 805 0

UVM aobj 2 2K 2K 78643K 2 0
memdesc 1 4K 4K 78643K 1 0
crypto data 1 1K 1K 78643K 1 0

NDP 3 0K 0K 78643K 3 0
temp 135 3047K 3097K 78643K 1535 0
kqueue 2 2K 2K 78643K 2 0

SYN cache 2 16K 16K 78643K 2 0
ddb{0}> show all pools
Name Size Requests Fail Releases Pgreq Pgrel Npage Hiwat Minpg Maxpg Idle

arp 64 2 0 0 1 0 1 1 0 8 0

plcache 128 20 0 0 1 0 1 1 0 8 0

rtpcb 80 15 0 13 1 0 1 1 0 8 0
rtentry 112 23 0 1 1 0 1 1 0 8 0
unpcb 120 263 0 21 8 0 8 8 0 8 0
syncache 264 5 0 5 1 0 1 1 0 8 1
tcpcb 544 8 0 5 1 0 1 1 0 8 0
inpcb 280 22 0 16 1 0 1 1 0 8 0

art_heap8 4096 1 0 0 1 0 1 1 0 8 0

art_heap4 256 96 0 0 6 0 6 6 0 8 0
art_table 32 97 0 0 1 0 1 1 0 8 0
art_node 16 22 0 2 1 0 1 1 0 8 0

dirhash 1024 17 0 0 3 0 3 3 0 8 0

dino1pl 128 1391 0 15 45 0 45 45 0 8 0
ffsino 272 1391 0 15 92 0 92 92 0 8 0
nchpl 144 1566 0 31 57 0 57 57 0 8 0
uvmvnodes 72 1400 0 0 26 0 26 26 0 8 0
vnodes 208 1400 0 0 74 0 74 74 0 8 0
namei 1024 3565 0 3565 1 0 1 1 0 8 1
percpumem 16 30 0 0 1 0 1 1 0 8 0
scxspl 192 2642 0 2642 2 1 1 2 0 8 1
plimitpl 152 13 0 8 1 0 1 1 0 8 0
sigapl 424 310 0 284 4 0 4 4 0 8 0
knotepl 112 5 0 0 1 0 1 1 0 8 0
kqueuepl 144 1 0 0 1 0 1 1 0 8 0
pipelkpl 48 57 0 53 1 0 1 1 0 8 0
pipepl 120 114 0 107 1 0 1 1 0 8 0
fdescpl 496 295 0 284 2 0 2 2 0 8 0
filepl 152 1177 0 783 16 0 16 16 0 8 0
lockfpl 104 5 0 4 1 0 1 1 0 8 0
lockfspl 48 3 0 2 1 0 1 1 0 8 0
sessionpl 112 17 0 9 1 0 1 1 0 8 0
pgrppl 48 17 0 9 1 0 1 1 0 8 0
ucredpl 96 47 0 40 1 0 1 1 0 8 0
zombiepl 144 284 0 283 1 0 1 1 0 8 0
processpl 984 310 0 283 4 0 4 4 0 8 0
procpl 624 310 0 283 3 0 3 3 0 8 0
sockpl 400 300 0 50 26 0 26 26 0 8 1
mcl4k 4096 2 0 0 1 0 1 1 0 8 0
mcl2k 2048 56 0 0 7 0 7 7 0 8 0

mtagpl 80 1 0 0 1 0 1 1 0 8 0

mbufpl 256 297 0 0 19 0 19 19 0 8 0
bufpl 280 1762 0 70 121 0 121 121 0 8 0
anonpl 16 18039 0 16914 6 1 5 6 0 124 0
amapchunkpl 152 584 0 547 2 0 2 2 0 158 0
amappl16 192 188 0 184 1 0 1 1 0 8 0
amappl15 184 1 0 0 1 0 1 1 0 8 0
amappl14 176 1 0 1 1 1 0 1 0 8 0
amappl13 168 12 0 11 1 0 1 1 0 8 0

amappl12 160 8 0 8 1 1 0 1 0 8 0

amappl11 152 64 0 52 1 0 1 1 0 8 0
amappl10 144 5 0 2 1 0 1 1 0 8 0
amappl9 136 227 0 226 1 0 1 1 0 8 0
amappl8 128 200 0 199 1 0 1 1 0 8 0
amappl7 120 78 0 70 1 0 1 1 0 8 0
amappl6 112 8 0 8 2 2 0 1 0 8 0
amappl5 104 244 0 233 1 0 1 1 0 8 0
amappl4 96 420 0 394 1 0 1 1 0 8 0
amappl3 88 98 0 92 1 0 1 1 0 8 0
amappl2 80 704 0 658 2 0 2 2 0 8 0
amappl1 72 12575 0 12189 14 4 10 14 0 8 0
amappl 80 472 0 452 1 0 1 1 0 84 0

dma4096 4096 1 0 1 1 1 0 1 0 8 0
dma256 256 6 0 6 1 1 0 1 0 8 0
dma128 128 253 0 253 1 1 0 1 0 8 0
dma64 64 6 0 6 1 1 0 1 0 8 0
dma32 32 7 0 7 1 1 0 1 0 8 0
dma16 16 18 0 17 1 0 1 1 0 8 0
aobjpl 64 1 0 0 1 0 1 1 0 8 0

uaddrrnd 24 295 0 283 1 0 1 1 0 8 0

uaddrbest 32 2 0 0 1 0 1 1 0 8 0

uaddr 24 295 0 283 1 0 1 1 0 8 0
vmmpekpl 168 5354 0 5334 1 0 1 1 0 8 0
vmmpepl 168 27285 0 26535 44 8 36 44 0 357 2
vmsppl 368 294 0 283 2 0 2 2 0 8 0
pdppl 4096 598 0 566 5 0 5 5 0 8 0
pvpl 32 73335 0 70599 26 0 26 26 0 265 3
pmappl 232 294 0 283 1 0 1 1 0 8 0

extentpl 40 46 0 29 1 0 1 1 0 8 0

phpool 112 169 0 2 5 0 5 5 0 8 0
ddb{0}>

[Greg Steuck]

There's now a reproducer: https://syzkaller.appspot.com/x/repro.c?x=17dcdadbe00000 (I haven't tried it)

[Anton Lindqvist]

Took a brief look and unp_gc() does pass NULL as the proc argument here.

> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-openbsd-bugs/CANMcDo82gh19Cx9qz1f-d513-F7Z1kK4RJT%3D6VZhxMYhUqze%2BQ%40mail.gmail.com.

[Anton Lindqvist]

#syz fix: Revert previous, syzkaller found a way to trigger the KASSERT().