Re: WARNING in zd_mac_clear

[Oliver Neukum]

#syz test: https://github.com/google/kasan.git usb-fuzzer

From ae999d5a437850b65497df7dcca3ffc10f75e697 Mon Sep 17 00:00:00 2001
From: Oliver Neukum <one...@suse.com>
Date: Tue, 30 Jul 2019 15:59:03 +0200
Subject: [PATCH] zdnet: remove false assertion from zd_mac_clear()

The function is called before the lock which is asserted was ever used.
Just remove it.

Reported-by: syzbot+74c657...@syzkaller.appspotmail.com
Signed-off-by: Oliver Neukum <one...@suse.com>
---
drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
index da7e63fca9f5..a9999d10ae81 100644
--- a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
+++ b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
@@ -223,7 +223,6 @@ void zd_mac_clear(struct zd_mac *mac)
{
flush_workqueue(zd_workqueue);
zd_chip_clear(&mac->chip);
- lockdep_assert_held(&mac->lock);
ZD_MEMCLEAR(mac, sizeof(struct zd_mac));
}

--
2.16.4

[Andrey Konovalov]

On Tue, Jul 30, 2019 at 4:21 PM Oliver Neukum <one...@suse.com> wrote:
>
> #syz test: https://github.com/google/kasan.git usb-fuzzer

Hi Oliver,

Could you please use the commit id when testing fixes for these USB
bugs? So 9a33b369 instead of usb-fuzzer for this one. Instead we are
risking false positive Tested-by tags from syzbot.

Thanks!

> --
> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bug...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/1564496488.25582.30.camel%40suse.com.

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger
crash:

Reported-and-tested-by:
syzbot+74c657...@syzkaller.appspotmail.com

Tested on:

commit: 7f7867ff usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
kernel config: https://syzkaller.appspot.com/x/.config?x=93eb69acad6f1977
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
patch: https://syzkaller.appspot.com/x/patch.diff?x=10eee442600000

Note: testing is done by a robot and is best-effort only.

[Oliver Neukum]

Am Dienstag, den 30.07.2019, 16:24 +0200 schrieb Andrey Konovalov:
> On Tue, Jul 30, 2019 at 4:21 PM Oliver Neukum <one...@suse.com> wrote:
> >
> > #syz test: https://github.com/google/kasan.git usb-fuzzer
>
> Hi Oliver,
>
> Could you please use the commit id when testing fixes for these USB
> bugs? So 9a33b369 instead of usb-fuzzer for this one. Instead we are
> risking false positive Tested-by tags from syzbot.

So it is identical for all USB bugs?
I was wondering whence to get that ID.

Regards
Oliver

[Andrey Konovalov]

No, it's different for different reports. It can be found in the
initial report message:

https://groups.google.com/forum/#!msg/syzkaller-bugs/52gEHPRxhOk/f8QMbYZMCgAJ

> HEAD commit: 9a33b369 usb-fuzzer: main usb gadget fuzzer driver