Fixing a test typo

27 views
Skip to first unread message

Connor Behan

unread,
Jun 14, 2015, 3:16:15 PM6/14/15
to sy...@googlegroups.com
Here's a patch for something in the matrix test I just noticed. I don't know if git send-email can work with Google Groups.
0001-Trivial-fix-to-matrix-test.patch

Aaron Meurer

unread,
Jun 14, 2015, 4:41:07 PM6/14/15
to sy...@googlegroups.com
We prefer fixes through GitHub pull requests. It makes things easier
to review and merge, and the tests will be run automatically by Travis
CI. Let us know if you need help doing it.

Aaron Meurer

On Sun, Jun 14, 2015 at 1:53 PM, Connor Behan <connor...@gmail.com> wrote:
> Here's a patch for something in the matrix test I just noticed. I don't know
> if git send-email can work with Google Groups.
>
> --
> You received this message because you are subscribed to the Google Groups
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sympy+un...@googlegroups.com.
> To post to this group, send email to sy...@googlegroups.com.
> Visit this group at http://groups.google.com/group/sympy.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sympy/a3dd36b1-b24a-492b-bef9-617adbc1aa5b%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Francesco Bonazzi

unread,
Jun 15, 2015, 4:11:37 AM6/15/15
to sy...@googlegroups.com
A quick way to create a pull request on github. Go to:

https://github.com/sympy/symengine/blob/master/symengine/tests/test_matrices.py

On the right of "History" there's a pencil, click there. You'll have an in-browser text editor. At the end you should be able to create the pull request.
Reply all
Reply to author
Forward
0 new messages