Use a bot to pick potential reviewers for PRs

37 views
Skip to first unread message

Ondřej Čertík

unread,
May 16, 2016, 5:37:11 PM5/16/16
to sympy
Hi,

I am trying to figure out ways to delegate the reviewing process, so
that we can reduce the number of open pull requests. I suggested to
use labels "PR: author's turn" before [1], and I think that would
work, except that I don't have the time myself to be flipping these
labels manually. So there should be a bot that does that. It looks
like Microsoft has already written a bot that does a similar thing:

http://www.felixrieseberg.com/a-peer-review-bot-for-github/
https://github.com/felixrieseberg/peer-review-bot

Related to that, we also want to get more people reviewing pull
requests. We should use a bot that goes into the source file and using
"git blame" figures out some potential reviewers. Here is one from
Facebook that does that:

https://github.com/facebook/mention-bot


Any volunteers to set this up? I would try the mention-bot, I think
this could be very useful.

Ondrej


[1] https://groups.google.com/d/topic/sympy/14dxPREl56k/discussion

Aaron Meurer

unread,
May 16, 2016, 5:41:44 PM5/16/16
to sy...@googlegroups.com
Does mention-bot provide a way for people to opt-out from being
mentioned by it?

Aaron Meurer
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To post to this group, send email to sy...@googlegroups.com.
> Visit this group at https://groups.google.com/group/sympy.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CADDwiVBaCQU6CqBixwCfFwfhOhUn6dtOA42SZBqmt%2BNgDg4ckA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.

Ondřej Čertík

unread,
May 16, 2016, 5:49:06 PM5/16/16
to sympy
On Mon, May 16, 2016 at 3:41 PM, Aaron Meurer <asme...@gmail.com> wrote:
> Does mention-bot provide a way for people to opt-out from being
> mentioned by it?

Yes, see the userBlacklist in
https://github.com/facebook/mention-bot#configuration

I wonder however, whether we should rather opt-in people by hand, so
that only people that want to do this will be mentioned, everybody
else will not.

Ondrej

Ted Horst

unread,
May 16, 2016, 9:32:07 PM5/16/16
to sy...@googlegroups.com
You might want to have a look at https://github.com/servo/highfive. The rust and servo projects use it for assigning reviewers among other things.

Ted
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To post to this group, send email to sy...@googlegroups.com.
> Visit this group at https://groups.google.com/group/sympy.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CADDwiVAHnPssQLoP_7pHiwp%3DcxFds24eSZVJN82tfi_pRZ45Dg%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages