Do I have something more to do after my Pull requests?
61 views
Skip to first unread message
Thomas Baruchel
Dec 6, 2015, 10:46:22 AM12/6/15
to sympy
I did three Pull requests 10/14 days ago: https://github.com/sympy/sympy/pulls/baruchel
Since that, I have no news; maybe it is normal, but I am asking in case I would have forgotten something?
Do I need to do something more? Regards.
Since that, I have no news; maybe it is normal, but I am asking in case I would have forgotten something?
Do I need to do something more? Regards.
Mateusz Paprocki
Dec 6, 2015, 5:13:34 PM12/6/15
to sympy
Hi,
pull request should be sufficient. However, we have very limited
resources, so it may take awhile for us to get to review your
contributions. What you could do is to advertise your work a little
bit, by figuring out who maintains or has solid contributions to a
module and politely pinging him/them in a PR. This way you could have
got my attention on #10171 a bit earlier. Otherwise, a new PR will
easily sink in a busy inbox. It also doesn't hurt to have some
discussion on the mailing list about what you work on prior to
submitting a PR. Also, you rise your odds for a review when all the
basic prerequisites are in the PR upon submission, including tests,
docstrings/doctests, references, proper code style, etc. (no worries
here, at least #10171 is solid).
Mateusz
> --
> You received this message because you are subscribed to the Google Groups
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sympy+un...@googlegroups.com.
> To post to this group, send email to sy...@googlegroups.com.
> Visit this group at http://groups.google.com/group/sympy.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sympy/81a381e1-64ca-4f5b-b82c-cda5b6ace715%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
resources, so it may take awhile for us to get to review your
contributions. What you could do is to advertise your work a little
bit, by figuring out who maintains or has solid contributions to a
module and politely pinging him/them in a PR. This way you could have
got my attention on #10171 a bit earlier. Otherwise, a new PR will
easily sink in a busy inbox. It also doesn't hurt to have some
discussion on the mailing list about what you work on prior to
submitting a PR. Also, you rise your odds for a review when all the
basic prerequisites are in the PR upon submission, including tests,
docstrings/doctests, references, proper code style, etc. (no worries
here, at least #10171 is solid).
Mateusz
> --
> You received this message because you are subscribed to the Google Groups
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sympy+un...@googlegroups.com.
> To post to this group, send email to sy...@googlegroups.com.
> Visit this group at http://groups.google.com/group/sympy.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sympy/81a381e1-64ca-4f5b-b82c-cda5b6ace715%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Ondřej Čertík
Dec 7, 2015, 10:15:02 AM12/7/15
to sympy
Hi Thomas,
On Sun, Dec 6, 2015 at 3:13 PM, Mateusz Paprocki <mat...@gmail.com> wrote:
> Hi,
>
> On 6 December 2015 at 16:46, Thomas Baruchel <baru...@gmx.com> wrote:
>> I did three Pull requests 10/14 days ago:
>> https://github.com/sympy/sympy/pulls/baruchel
>> Since that, I have no news; maybe it is normal, but I am asking in case I
>> would have forgotten something?
>> Do I need to do something more? Regards.
>
> pull request should be sufficient. However, we have very limited
> resources, so it may take awhile for us to get to review your
> contributions. What you could do is to advertise your work a little
> bit, by figuring out who maintains or has solid contributions to a
> module and politely pinging him/them in a PR. This way you could have
> got my attention on #10171 a bit earlier. Otherwise, a new PR will
> easily sink in a busy inbox. It also doesn't hurt to have some
> discussion on the mailing list about what you work on prior to
> submitting a PR. Also, you rise your odds for a review when all the
> basic prerequisites are in the PR upon submission, including tests,
> docstrings/doctests, references, proper code style, etc. (no worries
> here, at least #10171 is solid).
You can also mention people on github (e.g. @certik for myself), that
way they will get an email in their inbox.
The best is to find people that are relevant to the code you are
changing. But if nobody is reviewing your PRs, feel free to ping me as
well, I'll be happy to help.
Ondrej
On Sun, Dec 6, 2015 at 3:13 PM, Mateusz Paprocki <mat...@gmail.com> wrote:
> Hi,
>
> On 6 December 2015 at 16:46, Thomas Baruchel <baru...@gmx.com> wrote:
>> I did three Pull requests 10/14 days ago:
>> https://github.com/sympy/sympy/pulls/baruchel
>> Since that, I have no news; maybe it is normal, but I am asking in case I
>> would have forgotten something?
>> Do I need to do something more? Regards.
>
> pull request should be sufficient. However, we have very limited
> resources, so it may take awhile for us to get to review your
> contributions. What you could do is to advertise your work a little
> bit, by figuring out who maintains or has solid contributions to a
> module and politely pinging him/them in a PR. This way you could have
> got my attention on #10171 a bit earlier. Otherwise, a new PR will
> easily sink in a busy inbox. It also doesn't hurt to have some
> discussion on the mailing list about what you work on prior to
> submitting a PR. Also, you rise your odds for a review when all the
> basic prerequisites are in the PR upon submission, including tests,
> docstrings/doctests, references, proper code style, etc. (no worries
> here, at least #10171 is solid).
way they will get an email in their inbox.
The best is to find people that are relevant to the code you are
changing. But if nobody is reviewing your PRs, feel free to ping me as
well, I'll be happy to help.
Ondrej
Thomas Baruchel
Dec 8, 2015, 4:21:59 AM12/8/15
to sympy
Thank you to both Mateusz Paprocki and Ondřej Čertík,
it looks like two of my Pull requests have already been merged after I sent a message here.
May I assume you (Mateusz Paprocki) have some interest in identifying/recognizing/detecting
numbers or sequences (which is the purpose of the new sympy.concrete.guess submodule I want to submit in the remaining pull request)?
May I mention you on Github the next time I want to add something related to that field (as Ondřej Čertík) explained in his own answer?
What is the exact string I have to add on Github for mentioning you? Is it in the body of the message of the pull request that I have to do such a thing?
Best regards, and thank you again, tb.
it looks like two of my Pull requests have already been merged after I sent a message here.
May I assume you (Mateusz Paprocki) have some interest in identifying/recognizing/detecting
numbers or sequences (which is the purpose of the new sympy.concrete.guess submodule I want to submit in the remaining pull request)?
May I mention you on Github the next time I want to add something related to that field (as Ondřej Čertík) explained in his own answer?
What is the exact string I have to add on Github for mentioning you? Is it in the body of the message of the pull request that I have to do such a thing?
Best regards, and thank you again, tb.
Ondřej Čertík
Dec 8, 2015, 10:59:37 AM12/8/15
to sympy
mattpap in Mateusz' case and put @ up front like this: @mattpap.
Finally, just put this into any comment or issue or PR description.
Ondrej
>
> --
> You received this message because you are subscribed to the Google Groups
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sympy+un...@googlegroups.com.
> To post to this group, send email to sy...@googlegroups.com.
> Visit this group at http://groups.google.com/group/sympy.
> To view this discussion on the web visit
Reply all
Reply to author
Forward
0 new messages