OK, I've had a minute to take a look at this. Given the state of the
initial typesetting, I think this was actually more like a
moderate-difficulty production than a beginner production. So, kudos on
completing it, you did a good job. There are a lot of details in here
that needed attention.
I've gone ahead and released. Some general notes for the future:
- You have two editorial commits that introduced a huge number of
non-editorial changes. This makes it really hard to review. In the
future, carefully limit editorial changes in [Editorial] commits so that
we know what's going on and we can more easily undo them if necessary.
Commits are free so it's OK to do a lot of them if it means breaking up
work into digestible chunks.
- In the letter footer, nesting <ul> within <ul> is not necessary; only
one of those things is a list. Also a class is not necessary, because
there's only one <ul> in the whole ebook--so you can target <ul> for
styling directly. You can see how I did it in the final book.
- <hr> means "thematic break". It's not used if we just want "top
border". To create a top border, target an element with CSS. Also see
the final book for an example.
- Skylark is a ship name so it should be italicized. There are also some
alien words that should be italicized and not quoted.
- There was some missing copy and paste styling for poetry.
- When italicizing books etc., quotation marks and punctuation around
them don't get italics too. Actually we should remove quotes, because
we've already italicized the book. This mainly applied to the preface,
which I removed because it's just a publisher blurb.
Overall very good work. If you'd like to work on another book next, send
a note to the mailing list!
On 1/8/22 5:01 PM, B Keith wrote:
> Ok Alex this is ready for you to take a look at,
>
> B
>
>> On Jan 8, 2022, at 2:26 PM, David Zitzelsberger <
dazi...@gmail.com
>> <mailto:
dazi...@gmail.com>> wrote:
>>
>> Changes committed and pushed.
>>
>> On Sat, Jan 8, 2022, 12:29 PM B Keith <
bois...@gmail.com
>> <mailto:
bois...@gmail.com>> wrote:
>>
>> A few more small issues.
>>
>> — Bruce
>> _________
>>
>> Guadeamus igitur iuvenes dum sumus
>>
>>> On Jan 8, 2022, at 10:48 AM, David Zitzelsberger
>>> >> <mailto:
dazi...@gmail.com
>>> <mailto:
dazi...@gmail.com>>> wrote:
>>> >>
>>> >> I did mean semanticate.
>>> >>
>>> >> Typogrify run and all changes reviewed and found to be
>>> acceptable.
>>> >>
>>> >> I pushed the changes about 10 minutes ago so they
>>> should be there now.
>>> >>
>>> >> Thanks
>>> >>
>>> >> On Tue, Jan 4, 2022, 2:48 PM B Keith
>>> <
bois...@gmail.com <mailto:
bois...@gmail.com>
>>> >> <mailto:
bois...@gmail.com
>>> <mailto:
bois...@gmail.com>>> wrote:
>>> >>
>>> >> Typogrify.
>>> >>
>>> >> I think you read that as sematicate :-)
>>> >>
>>> >> There are a whole bunch of non-breaking spaces etc
>>> and a few quote
>>> >> marks in the Preface that need to be fixed.
>>> >>
>>> >> B
>>> >>
>>> >>> On Jan 4, 2022, at 12:23 PM, David Zitzelsberger
>>> >>> <
dazi...@gmail.com
>>> <mailto:
dazi...@gmail.com><mailto:
dazi...@gmail.com
>>> <mailto:
dazi...@gmail.com>>> wrote:
>>> >>>
>>> >>> Done.
>>> >>>
>>> >>> 18 cases of se semanticate incorrectly turning X
>>> into a roman
>>> >>> numeral in 7 files. No other changes, so no
>>> changes to commit or
>>> >>> push.
>>> >>>
>>> >>> When I say incorrectly I'm not suggesting changes
>>> to the se
>>> >>> toolset. There's no reasonable way for a program
>>> to know that
>>> >>> "substance X" is substance unknown and not
>>> substance ten.
>>> >>>
>>> >>> se clean makes no changes, so no changes for that
>>> either.
>>> >>>
>>> >>> se lint reports nothing, though I do have one
>>> instance of an
>>> >>> ignore rule that I manually reviewed.
>>> >>>
>>> >>> se build --check-only also reports nothing.
>>> >>>
>>> >>> Please review as is when you have the time.
>>> >>>
>>> >>> Thanks
>>> >>>
>>> >>> On Tue, Jan 4, 2022, 10:05 AM B Keith
>>> <
bois...@gmail.com <mailto:
bois...@gmail.com>
>>> >>> <mailto:
bois...@gmail.com
>>> <mailto:
bois...@gmail.com>>> wrote:
>>> >>>
>>> >>> Ya, that can be a pain. But make it a habit
>>> to run it one
>>> >>> last time before you submit and then revert
>>> the changes that
>>> >>> were wrong. Let me know when its done
>>> >>>
>>> >>> B
>>> >>>
>>> >>>> On Jan 4, 2022, at 9:02 AM, David Zitzelsberger
>>> >>>> <
dazi...@gmail.com
>>> <mailto:
dazi...@gmail.com><mailto:
dazi...@gmail.com
>>> <mailto:
dazi...@gmail.com>>> wrote:
>>> >>>>
>>> >>>> I had to stop running typography part way
>>> through because it
>>> >>>> kept changing all the substance X to
>>> substance Roman numeral
>>> >>>> 10. But I will give it another run and let
>>> you know the results.
>>> >>>>
>>> >>>> Thank you
>>> >>>>
>>> >>>> On Tue, Jan 4, 2022, 8:59 AM B Keith
>>> <
bois...@gmail.com <mailto:
bois...@gmail.com>
>>> >>>> <mailto:
bois...@gmail.com
>>> <mailto:
bois...@gmail.com>>> wrote:
>>> >>>>
>>> >>>> Morning David,
>>> >>>>
>>> >>>> Could I get you to run typogrify and
>>> clean again before
>>> >>>> I start the review. It makes a ton of
>>> changes…
>>> >>>>
>>> >>>> Bruce
>>> >>>>
>>> >>>>> On Jan 3, 2022, at 8:46 AM, David
>>> Zitzelsberger
>>> >>>>> <
dazi...@gmail.com
>>> <mailto:
dazi...@gmail.com><mailto:
dazi...@gmail.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>
>>> >>>>>
>>> <mailto:
standardebook...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>>.
>>> <
https://groups.google.com/d/msgid/standardebooks/CAFOpp_%3Dnr1n3y-K2%3D1jDPemBP4rAA%3DZ6pukZEnaPhtM1_zwK7g%40mail.gmail.com?utm_medium=email&utm_source=footer
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>
>>> >>>>
>>> <mailto:
standardebook...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>>.
>>> <
https://groups.google.com/d/msgid/standardebooks/22FA35E1-4846-467D-B2C4-463A64AF3095%40gmail.com?utm_medium=email&utm_source=footer
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>
>>> >>>>
>>> <mailto:
standardebook...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>>.
>>> <
https://groups.google.com/d/msgid/standardebooks/CAFOpp_nYFY_vV4zkhZj7DCpFP8Up09rKDeCb9p6DS0V1b2zzKw%40mail.gmail.com?utm_medium=email&utm_source=footer
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>
>>> >>>
>>> <mailto:
standardebook...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>>.
>>> <
https://groups.google.com/d/msgid/standardebooks/B8111375-750C-43B8-B151-D64B32F5367F%40gmail.com?utm_medium=email&utm_source=footer
>>>
tostandardeboo...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>
>>> >>>
>>> <mailto:
standardebook...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>>.
>>> <
https://groups.google.com/d/msgid/standardebooks/CAFOpp_mmG3%2BSWoP1tkcVL%3DqCD%3DyZpyzpMfMFSE366bZUatj9YQ%40mail.gmail.com?utm_medium=email&utm_source=footer
>>>
tostandardeboo...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>
>>> >>
>>> <mailto:
standardebook...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>>.
>>> <
https://groups.google.com/d/msgid/standardebooks/D30615F7-DF2E-4065-98B1-302BF2238005%40gmail.com?utm_medium=email&utm_source=footer
>>> >> an email
tostandardeboo...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>
>>> >> <mailto:
standardebook...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>>.
>>> <
https://groups.google.com/d/msgid/standardebooks/CAFOpp_kKKmY1sfgZz3wNRN%3DNT0jWm5o4miThbhoghMXYQyKWmQ%40mail.gmail.com?utm_medium=email&utm_source=footer
>>> > an email
tostandardeboo...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>
>>> > <mailto:
standardebook...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>>.
>>> <
https://groups.google.com/d/msgid/standardebooks/C577F11E-30EA-47F5-BA69-5897DC884270%40gmail.com?utm_medium=email&utm_source=footer
>>>
tostandardeboo...@googlegroups.com
>>> <mailto:
standardebooks%2Bunsu...@googlegroups.com>.
>>> To view this discussion on the web
>>> visithttps://
groups.google.com/d/msgid/standardebooks/797ba384-7eb2-19d1-9815-3142ae94928d%40standardebooks.org
>>> <
https://groups.google.com/d/msgid/standardebooks/797ba384-7eb2-19d1-9815-3142ae94928d%40standardebooks.org>.
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the
>>> Google Groups "Standard Ebooks" group.
>>> To unsubscribe from this group and stop receiving emails from it,
>>> send an email
tostandardeboo...@googlegroups.com
>>> visithttps://
groups.google.com/d/msgid/standardebooks/CAFOpp_%3DheNe-OYUaKneZBqZGYAA0Sm5o4oEVFyN4-6vXEq6QeQ%40mail.gmail.com
>>> <
https://groups.google.com/d/msgid/standardebooks/CAFOpp_%3DheNe-OYUaKneZBqZGYAA0Sm5o4oEVFyN4-6vXEq6QeQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>>
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "Standard Ebooks" group.
>> To unsubscribe from this group and stop receiving emails from it,
>> send an email to
standardebook...@googlegroups.com
>> <mailto:
standardebook...@googlegroups.com>.
>> To view this discussion on the web visit
>>
https://groups.google.com/d/msgid/standardebooks/E3E17D42-03EB-43FC-B036-209824C87AB8%40gmail.com
>> <
https://groups.google.com/d/msgid/standardebooks/E3E17D42-03EB-43FC-B036-209824C87AB8%40gmail.com?utm_medium=email&utm_source=footer>.
>>
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "Standard Ebooks" group.
>> To unsubscribe from this group and stop receiving emails from it, send
>> an email to
standardebook...@googlegroups.com
>> <mailto:
standardebook...@googlegroups.com>.
>> To view this discussion on the web visit
>>
https://groups.google.com/d/msgid/standardebooks/CAFOpp_nO9rLESz8yz6ksfotf_0xecVYV-Cm%2BKqvQd3jsdVRENg%40mail.gmail.com
>> <
https://groups.google.com/d/msgid/standardebooks/CAFOpp_nO9rLESz8yz6ksfotf_0xecVYV-Cm%2BKqvQd3jsdVRENg%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>
https://groups.google.com/d/msgid/standardebooks/93D0CAF5-A59A-405D-9E33-34771D003D6F%40gmail.com
> <
https://groups.google.com/d/msgid/standardebooks/93D0CAF5-A59A-405D-9E33-34771D003D6F%40gmail.com?utm_medium=email&utm_source=footer>.