0.12 release

[Johannes Schönberger]

Hi everyone,

Seems like we are close to clearing the 0.12 milestone: https://github.com/scikit-image/scikit-image/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.12

It's been a while since we had a release and lots of great stuff has been merged in the mean time. I suggest to freeze any other PRs until we release 0.12. Maybe we can aim to release 0.12 in the next days?

Cheers, Johannes

[Stéfan van der Walt]

On Wed, Jan 20, 2016 at 1:18 PM, Johannes Schönberger <js...@demuc.de> wrote:
> It's been a while since we had a release and lots of great stuff has been merged in the mean time. I suggest to freeze any other PRs until we release 0.12. Maybe we can aim to release 0.12 in the next days?

Yes, we're very close now! We're starting to see the effect of the
package & userbase growing: in the past, we'd release, and people
would come back with a few bug reports. Now, simply planning a
release triggers new bug reports, making the milestone grow and grow!
But the list is now shrinking rapidly.

Thanks all for your hard work!

Stéfan

[Emmanuelle Gouillart]

We only have 3 PRs started by Stéfan marked for 0.12, so we're indeed
very close! Out of these 3, 2 are almost ready to merge, and the last one
(about the novice module) could be postponed to 0.13 without much damage
(if I'm not mistaken; Stéfan, you might have a different opinion).

Stéfan, do you want these PRs to be merged for 0.12? Can you estimate
when they should be ready?

I can take care of the release process as described in our RELEASE.txt,
but it would be the first time for me so I'll probably need some help
along the process!

Best,
Emma

[Stéfan van der Walt]

Hi Emma

On 31 January 2016 at 07:52, Emmanuelle Gouillart

<emmanuelle...@nsup.org> wrote:
> Stéfan, do you want these PRs to be merged for 0.12? Can you estimate
> when they should be ready?

I'll make the last changes to those PRs now. If, after that, they are
not ready to merge, let us not hold up the whole release.

> I can take care of the release process as described in our RELEASE.txt,
> but it would be the first time for me so I'll probably need some help
> along the process!

That is very kind of you! I am happy to lend a hand as and where needed.

Stéfan

[Emmanuelle Gouillart]

> > Stéfan, do you want these PRs to be merged for 0.12? Can you estimate
> > when they should be ready?

> I'll make the last changes to those PRs now. If, after that, they are
> not ready to merge, let us not hold up the whole release.

Awesome! From GitHub's activity there are several devs around today, so
we should be able to review and hopefully merge today.

> > I can take care of the release process as described in our RELEASE.txt,
> > but it would be the first time for me so I'll probably need some help
> > along the process!

> That is very kind of you! I am happy to lend a hand as and where needed.

Thanks!

Emma

[Stéfan van der Walt]

On 31 January 2016 at 08:58, Emmanuelle Gouillart

<emmanuelle...@nsup.org> wrote:
>> > Stéfan, do you want these PRs to be merged for 0.12? Can you estimate
>> > when they should be ready?
>
>> I'll make the last changes to those PRs now. If, after that, they are
>> not ready to merge, let us not hold up the whole release.

I've made updates to those PRs. Unfortunately, I will be out for most
of the rest of the day, but feel free to update those PRs--I've added
Emma, Johannes, Josh and Juan as collaborators on my fork.

Thanks again!

Stéfan

[Emmanuelle Gouillart]

One more request, especially to the core team: could we restrain
ourselves from adding new PRs to the 0.12 milestone, except for bad bug
fixes? We need to converge at some point :-).

Emma

> --
> You received this message because you are subscribed to the Google Groups "scikit-image" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image...@googlegroups.com.
> To post to this group, send an email to scikit...@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/scikit-image/CABDkGQk7emQRwk9W5-sRZ0nq8gS%2Bj5TLJ3GBC7RTcnQ7umzTDQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.

[Johannes Schönberger]

Agreed and apologies :-)

No more PRs from my side.

> To view this discussion on the web, visit https://groups.google.com/d/msgid/scikit-image/20160131195815.GD819538%40phare.normalesup.org.

[Josh Warner]

I added #1921 to the milestone, but for good reason. Should have minimal fuss and saves us a cycle against this deprecation.

Nothing else pending here!

On Sunday, January 31, 2016 at 1:35:47 PM UTC-7, Johannes Schönberger wrote:

Agreed and apologies :-)

No more PRs from my side.

> On Jan 31, 2016, at 20:58, Emmanuelle Gouillart <emmanuelle...@nsup.org> wrote:
>
> One more request, especially to the core team: could we restrain
> ourselves from adding new PRs to the 0.12 milestone, except for bad bug
> fixes? We need to converge at some point :-).
>
> Emma
>
>> On Sun, Jan 31, 2016 at 09:52:25AM -0800, Stéfan van der Walt wrote:
>> On 31 January 2016 at 08:58, Emmanuelle Gouillart
>> <emmanuelle...@nsup.org> wrote:
>>>>> Stéfan, do you want these PRs to be merged for 0.12? Can you estimate
>>>>> when they should be ready?
>>>
>>>> I'll make the last changes to those PRs now.  If, after that, they are
>>>> not ready to merge, let us not hold up the whole release.
>>
>> I've made updates to those PRs.  Unfortunately, I will be out for most
>> of the rest of the day, but feel free to update those PRs--I've added
>> Emma, Johannes, Josh and Juan as collaborators on my fork.
>>
>> Thanks again!
>>
>> Stéfan
>>
>> --
>> You received this message because you are subscribed to the Google Groups "scikit-image" group.

>> To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com.

>> To post to this group, send an email to scikit...@googlegroups.com.
>> To view this discussion on the web, visit https://groups.google.com/d/msgid/scikit-image/CABDkGQk7emQRwk9W5-sRZ0nq8gS%2Bj5TLJ3GBC7RTcnQ7umzTDQ%40mail.gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups "scikit-image" group.

> To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com.

[Emmanuelle Gouillart]

I completely understand why you added this PR to the milestone, but there
are some remaining issues about it (see comments on GitHub: failing tests
+ gallery examples to update). Will you have time today or tomorrow to
work on it, so that we can tag 0.12 very soon :-) ?

Thanks!
Emma

> an email to scikit-image...@googlegroups.com.

> >> To post to this group, send an email to scikit...@googlegroups.com.
> >> To view this discussion on the web, visit https://groups.google.com/d/
> msgid/scikit-image/CABDkGQk7emQRwk9W5-sRZ0nq8gS%2Bj5TLJ3GBC7RTcnQ7umzTDQ%
> 40mail.gmail.com.
> >> For more options, visit https://groups.google.com/d/optout.

> > --
> > You received this message because you are subscribed to the Google Groups
> "scikit-image" group.
> > To unsubscribe from this group and stop receiving emails from it, send an

> email to scikit-image...@googlegroups.com.

> > To post to this group, send an email to scikit...@googlegroups.com.
> > To view this discussion on the web, visit https://groups.google.com/d/

> msgid/scikit-image/20160131195815.GD819538%40phare.normalesup.org.

[Josh Warner]

Already done, didn't have Wi-Fi over lunch but will push once I get home tonight.

[Johannes Schönberger]

Should we release 0.12 now? Seems like all but one PR are merged now.

> On Feb 1, 2016, at 11:55 PM, Josh Warner <silvertr...@gmail.com> wrote:
>
> Already done, didn't have Wi-Fi over lunch but will push once I get home tonight.
>

> --
> You received this message because you are subscribed to the Google Groups "scikit-image" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image...@googlegroups.com.
> To post to this group, send an email to scikit...@googlegroups.com.

> To view this discussion on the web, visit https://groups.google.com/d/msgid/scikit-image/f59e463a-124c-43b7-8272-40bb25925a55%40googlegroups.com.

[Emmanuelle Gouillart]

Yes, I think it's ready now! I've started working on release notes
yesterday and will continue tonight (Paris time), but if someone with
more bandwidth is impatient about releasing, go for it!

Emma

[Stéfan van der Walt]

Please note that there are still outstanding items on the TODO.txt.  I am almost done refactoring the labeling to use zero as background.

Stéfan

To view this discussion on the web, visit https://groups.google.com/d/msgid/scikit-image/20160203075920.GA2389752%40phare.normalesup.org.

[Emmanuelle Gouillart]

Thanks for preventing us from being carried away by the excitement of the
release :-D

[Stéfan van der Walt]

On 3 February 2016 at 09:21, Emmanuelle Gouillart

<emmanuelle...@nsup.org> wrote:
> Thanks for preventing us from being carried away by the excitement of the
> release :-D

Let me not stand in the way! I have three months' worth of happiness
pent up for the moment that tag gets applied.

Onward :)

Stéfan

[Emmanuelle Gouillart]

Dear all,

after having pressed everyone to finish pull requests and promised to
take care of the release, I'm having a few busy days during which I can't
find time to work on the release. It's going to be much better starting
from Tuesday evening, so please bear with me and be patient: the release
is (still) coming! And it means that there are still a few days to
complete outstanding items on TODO.txt :-)

Cheers,
Emmanuelle

[Emmanuelle Gouillart]

Dear all,

TODO.txt is now empty as far as 0.12 is concerned, release notes are
ready, shall we tag now? Stéfan, no regrets about #1937 or #1905?

I'm not used to "pushing origin master" (instead of pull requests), so I
prefer asking before: are instructions such as

- Update the version number in ``skimage/__init__.py`` and ``bento.info``
and commit

- Edit ``doc/source/_static/docversions.js`` and commit

- Add the version number as a tag in git::

git tag -s v0.X.0

git push --tags origin master

etc...

meant to be done in master and pushed directly to origin?

Stéfan, if I tag, can you publish on PyPi?

Cheers,
Emma

[Stéfan van der Walt]

Hi Emma

On 23 February 2016 at 07:38, Emmanuelle Gouillart

<emmanuelle...@nsup.org> wrote:
> TODO.txt is now empty as far as 0.12 is concerned, release notes are
> ready, shall we tag now? Stéfan, no regrets about #1937 or #1905?

Thanks for your hard work in moving the release forward!

#1937 highlights a bug in our tests (and failing tests, that aren't
currently showing up), so I would consider that the last blocker.

I'll try to get around to #1905, but if I don't that's also OK.

> - Update the version number in ``skimage/__init__.py`` and ``bento.info``
> and commit

All of this can be done on a 0.12.x branch.

> - Edit ``doc/source/_static/docversions.js`` and commit

This change needs to be done on / merged onto master.

> - Add the version number as a tag in git::
>
> git tag -s v0.X.0

This again can happen on the 0.12.x branch.

> Stéfan, if I tag, can you publish on PyPi?

I'd be happy to!

Thanks!
Stéfan

[Emmanuelle Gouillart]

Hi Stéfan,

> #1937 highlights a bug in our tests (and failing tests, that aren't
> currently showing up), so I would consider that the last blocker.

> I'll try to get around to #1905, but if I don't that's also OK.

OK ! For #1937, I think the bug highlighted by
test_orb.test_keypoints_orb_desired_no_of_keypoints should be fixed
before the PR can be merged. Otherwise we'll have Travis failing all the
time, for all new PRs. Am I wrong?

And many thanks for all the explanations!

Cheers,
Emma

[Stéfan van der Walt]

On 24 February 2016 at 13:57, Emmanuelle Gouillart

<emmanuelle...@nsup.org> wrote:
> OK ! For #1937, I think the bug highlighted by
> test_orb.test_keypoints_orb_desired_no_of_keypoints should be fixed
> before the PR can be merged. Otherwise we'll have Travis failing all the
> time, for all new PRs. Am I wrong?

That's correct, yes!

Stéfan

[Emmanuelle Gouillart]

> #1937 highlights a bug in our tests (and failing tests, that aren't
> currently showing up), so I would consider that the last blocker.

Well, #1937 has been stalling for a while and I would consider it a minor
bug only (differing opinion, anyone?), so how about we postpone #1937 to
0.13?

Emma

[Stéfan van der Walt]

On 2 March 2016 at 13:24, Emmanuelle Gouillart

<emmanuelle...@nsup.org> wrote:
>> #1937 highlights a bug in our tests (and failing tests, that aren't
>> currently showing up), so I would consider that the last blocker.

#1937 is a bug fix, so should be merged. The real problem is the bug
that it exposes, which is

https://github.com/scikit-image/scikit-image/issues/1935

I will work on fixing it this afternoon.

Stéfan

[Emmanuelle Gouillart]

Thanks :-D

[Juan Nunez-Iglesias]

Bug fixes seem precisely inessential to get done ahead of release? Anything that doesn't break the API can be added in 0.12.1?

--
You received this message because you are subscribed to the Google Groups "scikit-image" group.
To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image...@googlegroups.com.
To post to this group, send an email to scikit...@googlegroups.com.

To view this discussion on the web, visit https://groups.google.com/d/msgid/scikit-image/20160302215220.GC3276684%40phare.normalesup.org.

[Stéfan van der Walt]

On 2 March 2016 at 16:00, Juan Nunez-Iglesias <jni....@gmail.com> wrote:
> Bug fixes seem precisely inessential to get done ahead of release? Anything
> that doesn't break the API can be added in 0.12.1?

You can't really release a package with a broken test suite. So you
have the option to temporarily disable the tests, but shipping with a
known bug feels kind of weird?

Either way, I think I've zapped most of the outstanding ones. Waiting
for Travis.

Stéfan

[Juan Nunez-Iglesias]

Aren't these pre-existing bugs? At any rate, as you say, might be a moot point, finally. =)

--
You received this message because you are subscribed to the Google Groups "scikit-image" group.
To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image...@googlegroups.com.
To post to this group, send an email to scikit...@googlegroups.com.

To view this discussion on the web, visit https://groups.google.com/d/msgid/scikit-image/CABDkGQnz%2BdW7-oC2CpcEpxRYjmotMderNZ2-u84EctjOSOpU-Q%40mail.gmail.com.

[Stéfan van der Walt]

Who wants to merge the last outstanding PR for 0.12!

https://github.com/scikit-image/scikit-image/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.12

> To post to this group, send email to scikit...@googlegroups.com.

> To view this discussion on the web, visit

> https://groups.google.com/d/msgid/scikit-image/CA%2BJHcKRUYPFNz7n3OARY1rhpZj%3DEvN%3DTPivKOrt0X0izZhbCXw%40mail.gmail.com.

[Emmanuelle Gouillart]

Awesome!! I'm tagging right now, so please don't merge any PRs!!!

[Emmanuelle Gouillart]

So, I tagged v0.12.0 and pushed a 0.12.x branch to
scikit-image/scikit-image

Now the release can be published on PyPi, I think :-)

Emma