Test

[Timothy Kline]

I just installed scikit-fmm on mac. Running skfmm.test() gave:

**********************************************************************
File "/python2.7/site-packages/skfmm/__init__.py", line 247, in skfmm.testing
Failed example:
    print phi[2, 2] == phi[2, 3]
Expected:
    True
Got:
    False
**********************************************************************
File "/python2.7/site-packages/skfmm/__init__.py", line 251, in skfmm.testing
Failed example:
    print phi[2, 2] == phi[2, 3]
Expected:
    True
Got:
    False
**********************************************************************
1 items had failures:
   2 of 264 in skfmm.testing
***Test Failed*** 2 failures.

Looking through doctest it is mentioned that this is guaranteed to fail. So, is this correct behavior or any thought on these failures?

Thanks for your time and contribution,

Tim

[Jason Furtney]

Dear Tim Klein,

Thanks for your email and for your interest in scikit-fmm. Yes, this
is a known problem with the current version. The solution should be
perfectly symmetric in this case. This test is sort of an unusual
edge-case, depending on what kind of problems you are looking at this
may not be an issue.

There is a branch in the github repo which has a fix for this problem:
https://github.com/scikit-fmm/scikit-fmm/tree/logging

Here is a note from a previous email on this topic:

On the symmetry problem: it seems
like the symmetry is broken when two points with the same trial
distance are processed in arbitrary order. I experimented with
freezing batches of points which are equidistant from the front. The
solution becomes symmetric and all the tests still pass. As far as I
can tell, this is OK because it still respects the causality of a
monotonically expanding front.

I have not merged this fix into the master branch because there may be
a performance problem with using std::vector to store the batches of
points. I will do some additional testing soon, if everything looks
good I will push out a new version.

Thanks,
Jason

> --
> You received this message because you are subscribed to the Google Groups
> "scikit-fmm" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to scikit-fmm+...@googlegroups.com.
> To post to this group, send email to sciki...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/scikit-fmm/4a60de10-2985-4c9a-bcf5-9e9439451ca3%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



--
--
Jason K. Furtney
Itasca Consulting Group
111 3rd Ave. South, Suite 450
Minneapolis, MN 55401 USA
(612) 371-4711

[Timothy Kline]

OK, sounds good. Thanks so much for the response Jason.

-Tim