Attention: new high quality of docstrings

[Kwankyu Lee]

Hi,

PR #38155 https://github.com/sagemath/sage/pull/38155 now got positive review.

We hope that sage developers maintain the high quality of docstrings established by the PR.

Thanks for attention.

[kcrisman]

Impressive!

[Martin R]

I think it would be good to have a conscious decision about when a merge of this pull request should happen.  Since it affects 2262 (!) files, just about everybody will have to rebase their work.  Also, when there is a clear decision, the author will not have to fix merge conflicts again and again.

Personally, I think that a single beta release, containing only this pull request, would be appropriate.  I can imagine that this would be helpful when locating future bugs, because this pull request contains a huge amount of changes, but no changes to code, so it can be skipped when trying to find a breaking commit.  Alternatively, maybe even better, it could be the last commit before the next release.

Best wishes,

Martin

[Dima Pasechnik]

On Sat, Jul 27, 2024 at 10:01 AM 'Martin R' via sage-devel
<sage-...@googlegroups.com> wrote:
>
> I think it would be good to have a conscious decision about when a merge of this pull request should happen. Since it affects 2262 (!) files, just about everybody will have to rebase their work. Also, when there is a clear decision, the author will not have to fix merge conflicts again and again.
>
> Personally, I think that a single beta release, containing only this pull request, would be appropriate. I can imagine that this would be helpful when locating future bugs, because this pull request contains a huge amount of changes, but no changes to code, so it can be skipped when trying to find a breaking commit. Alternatively, maybe even better, it could be the last commit before the next release.
>

I don't see a problem merging this - after all, rebasing over it will
be mostly automatic.
E.g. rebasing de current develop branch over it goes automatically, no
intervention is needed.

I also don't see how it could affect debugging.
If you run git bisect, it's just one more commit.

Dima

> Best wishes,
>
> Martin
> On Tuesday 9 July 2024 at 13:58:51 UTC+2 kcrisman wrote:
>>
>> Impressive!
>>
>> On Monday, July 8, 2024 at 8:31:39 AM UTC-4 Kwankyu Lee wrote:
>>>
>>> Hi,
>>>
>>> PR #38155 https://github.com/sagemath/sage/pull/38155 now got positive review.
>>>
>>> We hope that sage developers maintain the high quality of docstrings established by the PR.
>>>
>>> Thanks for attention.
>

> --
> You received this message because you are subscribed to the Google Groups "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/aa753d4e-e7c2-480e-a01b-8ea9811183a1n%40googlegroups.com.

[Kwankyu Lee]

On Saturday, July 27, 2024 at 6:01:48 PM UTC+9 Martin R wrote:

I think it would be good to have a conscious decision about when a merge of this pull request should happen.  Since it affects 2262 (!) files, just about everybody will have to rebase their work.  Also, when there is a clear decision, the author will not have to fix merge conflicts again and again.

git is smart and the author is skillful in git. I look forward a good luck in the next release :-)