Remove nose package?

55 views
Skip to first unread message

Isuru Fernando

unread,
Sep 29, 2021, 5:35:40 PM9/29/21
to sage-devel
Building the nose package requires 'use_2to3' in setuptools, but the latest setuptools version
has dropped support for 'use_2to3'. We can either run 2to3 manually or drop the nose
package. Since nose hasn't had an update since 2016 and is unmaintained, I think it's time
to drop it.

Isuru

Dima Pasechnik

unread,
Sep 29, 2021, 5:49:28 PM9/29/21
to sage-devel
nose became nose2: https://github.com/nose-devs/nose2 - which is being developed.

Whether we need so many different testing frameworks is a question.
I'd say, just remove nose.


--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CA%2B01voMoprTiBDJnodhZ7x_r%2BRUvu82yhEoG1xApoBcswPYZXw%40mail.gmail.com.

David Roe

unread,
Sep 29, 2021, 5:49:57 PM9/29/21
to sage-devel
I don't have a strong opinion on whether to drop nose or not, but I was curious how it was used in Sage.  It looks to be required to run tests for networkx, cvxopt and symengine.  Will tests for those packages just need to be run after installing nose manually?
David

--

Isuru Fernando

unread,
Sep 29, 2021, 5:52:28 PM9/29/21
to sage-devel
> It looks to be required to run tests for networkx, cvxopt and symengine.  Will tests for those packages just need to be run after installing nose manually?

At least for symengine, we can change to pytest. I suppose other packages can too.

Isuru

Dima Pasechnik

unread,
Sep 29, 2021, 5:53:51 PM9/29/21
to sage-devel
On Wed, Sep 29, 2021 at 10:52 PM Isuru Fernando <isu...@gmail.com> wrote:
> It looks to be required to run tests for networkx, cvxopt and symengine.  Will tests for those packages just need to be run after installing nose manually?

At least for symengine, we can change to pytest. I suppose other packages can too.


Isuru

On Wed, Sep 29, 2021 at 4:49 PM David Roe <roed...@gmail.com> wrote:
I don't have a strong opinion on whether to drop nose or not, but I was curious how it was used in Sage.  It looks to be required to run tests for networkx, cvxopt and symengine.  Will tests for those packages just need to be run after installing nose manually?
David

On Wed, Sep 29, 2021 at 5:35 PM Isuru Fernando <isu...@gmail.com> wrote:
Building the nose package requires 'use_2to3' in setuptools, but the latest setuptools version
has dropped support for 'use_2to3'. We can either run 2to3 manually or drop the nose
package. Since nose hasn't had an update since 2016 and is unmaintained, I think it's time
to drop it.

Isuru

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CA%2B01voMoprTiBDJnodhZ7x_r%2BRUvu82yhEoG1xApoBcswPYZXw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAChs6_n4oty0KE9N5PoAj2t0ma9X7bbOxuz1atO88xV07GmjwA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.

Thierry

unread,
Sep 30, 2021, 11:10:13 AM9/30/21
to sage-...@googlegroups.com
Hi,

nose selftests are broken, networkx and cvxopt selftests are broken
because they still rely on nose (in Sage), while upstream now relies
on pytest. Symengine does not rely on nose (nor pytest), but on cmake.

- fix for cvxopt: https://trac.sagemath.org/ticket/32598 (needs_review)
- fix for networkx: https://trac.sagemath.org/ticket/32597 (needs_review)

- removal of nose (proposal): https://trac.sagemath.org/ticket/32595

Now that Sage does not rely on nose anymore, i am +1 for its removal
(and will put #32595 on needs_review if we agree on this).

By the way, should pytest become standard ?

Ciao,
Thierry
> >>> <https://groups.google.com/d/msgid/sage-devel/CA%2B01voMoprTiBDJnodhZ7x_r%2BRUvu82yhEoG1xApoBcswPYZXw%40mail.gmail.com?utm_medium=email&utm_source=footer>
> >>> .
> >>>
> >> --
> >> You received this message because you are subscribed to the Google Groups
> >> "sage-devel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an
> >> email to sage-devel+...@googlegroups.com.
> >> To view this discussion on the web visit
> >> https://groups.google.com/d/msgid/sage-devel/CAChs6_n4oty0KE9N5PoAj2t0ma9X7bbOxuz1atO88xV07GmjwA%40mail.gmail.com
> >> <https://groups.google.com/d/msgid/sage-devel/CAChs6_n4oty0KE9N5PoAj2t0ma9X7bbOxuz1atO88xV07GmjwA%40mail.gmail.com?utm_medium=email&utm_source=footer>
> >> .
> >>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "sage-devel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to sage-devel+...@googlegroups.com.
> > To view this discussion on the web visit
> > https://groups.google.com/d/msgid/sage-devel/CA%2B01voMjkFNbSanYhNvUOLp4Ga%3DVa5ectbiPpwfp%2BZBvouW69A%40mail.gmail.com
> > <https://groups.google.com/d/msgid/sage-devel/CA%2B01voMjkFNbSanYhNvUOLp4Ga%3DVa5ectbiPpwfp%2BZBvouW69A%40mail.gmail.com?utm_medium=email&utm_source=footer>
> > .
> >
>
> --
> You received this message because you are subscribed to the Google Groups "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAAWYfq00SSugdQGk4q_urEszR1qdu96E2jgBTi-5WA5QFq8tJA%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages