Sage developer's guide

[William Stein]

Hi Sage Developers,

Somebody was asking me about doing Sage development, and I pointed
them to the sage developer's guide [1]. However, looking at it for a
moment was worrisome, since it starts with a big scary banner saying:
"Warning: Sage development is scheduled to move to GitHub in February
2023. The exact date will be announced in
https://groups.google.com/g/sage-devel. After the transition, some
parts of this guide (especially those related with the Sage Trac
server) will become obsolete and be updated according to the new
workflow on GitHub. See our transition guide from Trac to GitHub for
the preliminary version of the workflow."

It seems like that banne could be updated a bit, now that it is April.
I do realize that there's still a lot being hashed out about the exact
workflow...

William

[1] https://doc.sagemath.org/html/en/developer/index.html

--

Best Regards,
William Stein

CEO, SageMath, Inc.
https://cocalc.com

[Kwankyu Lee]

It seems like that banner could be updated a bit, now that it is April.

I do realize that there's still a lot being hashed out about the exact
workflow...

It seems that the workflow is still in flux. Some questions: 

(1) Who can be a reviewer? Anyone, organization member or members of triage team?

(2) How one can be an organization member?

(3) How one can be a member of triage team?

(4) Currently, for a PR from an outside contributor(not organization member), github workflows need an approval to run. Who are supposed to  approve this? Anyone with maintainer privilege?

(5) How one can be a maintainer?

(6) What to do with automatic labelling vs manual labelling? https://github.com/sagemath/sage/pull/35172

 

[Kwankyu Lee]

(6) What to do with automatic labelling vs manual labelling? https://github.com/sagemath/sage/pull/35172

If any organization member can be a reviewer, automatic labelling should be implemented, since only triage team members can add labels. But I think the current manual labelling should not be hindered by the automating script. 

 

 

[Dima Pasechnik]

Anyone should be able to be a reviewer, but not everyone a PR-approving reviewer.

The problem is that approving a PR is something that should not be left to arbitrary people.

I.e. not every reviewer, potentially requesting changes and approving changes, should be able to approve the PR.

So the label change can be automated, but not any "approval" should trigger it.

On Wed, 5 Apr 2023, 09:39 Kwankyu Lee, <ekwa...@gmail.com> wrote:

(6) What to do with automatic labelling vs manual labelling? https://github.com/sagemath/sage/pull/35172

If any organization member can be a reviewer, automatic labelling should be implemented, since only triage team members can add labels. But I think the current manual labelling should not be hindered by the automating script. 

 

 

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/9eedde50-afca-4224-9728-e07ece238a40n%40googlegroups.com.

[Kwankyu Lee]

I created a PR 

https://github.com/sagemath/sage/pull/35460

to start. Please help if you want to get things done fast.

[seb....@gmail.com]

This PR is ready for review, now!

Kwankyu Lee schrieb am Mittwoch, 5. April 2023 um 10:28:22 UTC+2:

It seems like that banner could be updated a bit, now that it is April.

I do realize that there's still a lot being hashed out about the exact
workflow...

It seems that the workflow is still in flux. Some questions: 

.....

[Kwankyu Lee]

Hi,

Here is the preliminary version of new developer guide (no 's): https://deploy-preview-35460--sagemath-tobias.netlify.app

Errors, typos, defects should go to: https://github.com/sagemath/sage/pull/35460

Thanks for your attention in advance.

On Wednesday, April 5, 2023 at 2:33:44 PM UTC+9 William Stein wrote: