Upgrade to Rails 5 link not working

[Jimmy Lin]

After I upgrade this particular rails app to rails 5. The links on the page is not clickable. After i click it, it is not redirecting.

But if i open it in a new page, it works fine.

Anybody know why?

[Colin Law]

I am afraid I do not understand what you are saying. First you say the
links are not clickable, then you say that if you click it does not
re-direct. What do you mean by that? Then you say if you open a new
page it works fine, what works fine? The link clicking?

So please explain the problem in more detail, first though have a look
at the page source html in the browser and see if the links look ok.
If that looks ok then look in the log see if there are any clues
there.

Also you have not said whether your automated tests work ok.

Colin

> Anybody know why?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Ruby on Rails: Talk" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to rubyonrails-ta...@googlegroups.com.
> To post to this group, send email to rubyonra...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/rubyonrails-talk/86c33c71-c47e-4142-9cc6-61e3889089e4%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Jimmy Lin]

In the source code, i can see "<a class="btn btn-success" href="/account/sign_in">Sign In</a>"

When I click it, it has no response. It is the same for any link or any button on the page.

Then if i copy the url to a new browser window, it will show the page properly.

On Fri, Aug 5, 2016 at 11:18 PM, Colin Law <cla...@gmail.com> wrote:

On 5 August 2016 at 16:29, Jimmy Lin <jimm...@gmail.com> wrote:
> After I upgrade this particular rails app to rails 5. The links on the page
> is not clickable. After i click it, it is not redirecting.
> But if i open it in a new page, it works fine.

I am afraid I do not understand what you are saying. First you say the
links are not clickable, then you say that if you click it does not
re-direct.  What do you mean by that?  Then you say if you open a new
page it works fine, what works fine?  The link clicking?

So please explain the problem in more detail, first though have a look
at the page source html in the browser and see if the links look ok.
If that looks ok then look in the log see if there are any clues
there.

Also you have not said whether your automated tests work ok.

Colin

> Anybody know why?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Ruby on Rails: Talk" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to rubyonrails-talk+unsubscribe@googlegroups.com.
> To post to this group, send email to rubyonrails-talk@googlegroups.com.

> To view this discussion on the web visit
> https://groups.google.com/d/msgid/rubyonrails-talk/86c33c71-c47e-4142-9cc6-61e3889089e4%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "Ruby on Rails: Talk" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/rubyonrails-talk/NMLio7rs4YQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to rubyonrails-talk+unsubscribe@googlegroups.com.
To post to this group, send email to rubyonrails-talk@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/CAL%3D0gLu2x4V8DJ4mYssM8cL0MQDc5bJi%2BVC%2B8H%3DeJUY0_BnTUg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Thanks

Jimmy

[Colin Law]

On 5 August 2016 at 22:56, Jimmy Lin <jimm...@gmail.com> wrote:
> In the source code, i can see "<a class="btn btn-success"
> href="/account/sign_in">Sign In</a>"
> When I click it, it has no response. It is the same for any link or any
> button on the page.
> Then if i copy the url to a new browser window, it will show the page
> properly.

You have not replied to suggestion that you look in the log to see
what is shown there when you click the link (log/development.log).
Also I find it easier to follow the thread if you insert your reply at
appropriate points in the previous message. In this case I think you
would have been less likely that you would have failed to notice my
reference to the log if you had done that.

Also does the link look like a link normally does in the browser (in
blue or whatever the styling is setup to show links as). Does the url
show up in the browser when you hover over it?

When you say you copy the url to a new browser window which url do you mean?

I notice that you have also ignored my question about automated tests.
Does that mean there are none?

Please make sure to answer all questions, thanks.

Colin

>
> On Fri, Aug 5, 2016 at 11:18 PM, Colin Law <cla...@gmail.com> wrote:
>>
>> On 5 August 2016 at 16:29, Jimmy Lin <jimm...@gmail.com> wrote:
>> > After I upgrade this particular rails app to rails 5. The links on the
>> > page
>> > is not clickable. After i click it, it is not redirecting.
>> > But if i open it in a new page, it works fine.
>>
>> I am afraid I do not understand what you are saying. First you say the
>> links are not clickable, then you say that if you click it does not
>> re-direct. What do you mean by that? Then you say if you open a new
>> page it works fine, what works fine? The link clicking?
>>
>> So please explain the problem in more detail, first though have a look
>> at the page source html in the browser and see if the links look ok.
>> If that looks ok then look in the log see if there are any clues
>> there.
>>
>> Also you have not said whether your automated tests work ok.
>>
>> Colin
>>
>> > Anybody know why?
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> > Groups
>> > "Ruby on Rails: Talk" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> > an

>> > email to rubyonrails-ta...@googlegroups.com.
>> > To post to this group, send email to rubyonra...@googlegroups.com.

>> > To view this discussion on the web visit
>> >
>> > https://groups.google.com/d/msgid/rubyonrails-talk/86c33c71-c47e-4142-9cc6-61e3889089e4%40googlegroups.com.
>> > For more options, visit https://groups.google.com/d/optout.
>>
>> --
>> You received this message because you are subscribed to a topic in the
>> Google Groups "Ruby on Rails: Talk" group.
>> To unsubscribe from this topic, visit
>> https://groups.google.com/d/topic/rubyonrails-talk/NMLio7rs4YQ/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to

>> rubyonrails-ta...@googlegroups.com.
>> To post to this group, send email to rubyonra...@googlegroups.com.

>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/rubyonrails-talk/CAL%3D0gLu2x4V8DJ4mYssM8cL0MQDc5bJi%2BVC%2B8H%3DeJUY0_BnTUg%40mail.gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
>
>
> --
> Thanks
> Jimmy
>

> --
> You received this message because you are subscribed to the Google Groups
> "Ruby on Rails: Talk" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to rubyonrails-ta...@googlegroups.com.
> To post to this group, send email to rubyonra...@googlegroups.com.

> To view this discussion on the web visit

> https://groups.google.com/d/msgid/rubyonrails-talk/CAGQPN4n8Q7KFfvoWgodz%3D0%2BhYeOVYJFKds1QeAKaTtPkj3H-gA%40mail.gmail.com.

[Jimmy Lin]

On Aug 6, 2016, at 9:33 AM, Colin Law <cla...@gmail.com> wrote:

On 5 August 2016 at 22:56, Jimmy Lin <jimm...@gmail.com> wrote:

In the source code, i can see "<a class="btn btn-success"
href="/account/sign_in">Sign In</a>"
When I click it, it has no response. It is the same for any link or any
button on the page.
Then if i copy the url to a new browser window, it will show the page
properly.

You have not replied to suggestion that you look in the log to see
what is shown there when you click the link (log/development.log).
Also I find it easier to follow the thread if you insert your reply at
appropriate points in the previous message. In this case I think you
would have been less likely that you would have failed to notice my
reference to the log if you had done that.

I opened up the log file. I didn’t see any issues. The page opens as normal. However, i click any links. There is no additional log in the file.

Also does the link look like a link normally does in the browser (in
blue or whatever the styling is setup to show links as). Does the url
show up in the browser when you hover over it?

Yes. the style looks right and it shows up the correct link.

When you say you copy the url to a new browser window which url do you mean?

I was trying to say the URL for the link is correct and working. 

I notice that you have also ignored my question about automated tests.
Does that mean there are none?

Yeah.. I haven’t written any auto test yet. I am about to start writing them.

Please make sure to answer all questions, thanks.

Sorry for the confusing. Thank you very much.

To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/CAL%3D0gLtsRTEZmFoPha0LsAnMSdjDO0Y%2BnER-d4pjS0KEiftwrA%40mail.gmail.com.

[Colin Law]

On 6 Aug 2016 10:47 p.m., "Jimmy Lin" <jimm...@gmail.com> wrote:
>
>
>
>
>
>
>
>> On Aug 6, 2016, at 9:33 AM, Colin Law <cla...@gmail.com> wrote:
>>
>> On 5 August 2016 at 22:56, Jimmy Lin <jimm...@gmail.com> wrote:
>>>
>>> In the source code, i can see "<a class="btn btn-success"
>>> href="/account/sign_in">Sign In</a>"
>>> When I click it, it has no response. It is the same for any link or any
>>> button on the page.
>>> Then if i copy the url to a new browser window, it will show the page
>>> properly.
>>
>>
>> You have not replied to suggestion that you look in the log to see
>> what is shown there when you click the link (log/development.log).
>> Also I find it easier to follow the thread if you insert your reply at
>> appropriate points in the previous message. In this case I think you
>> would have been less likely that you would have failed to notice my
>> reference to the log if you had done that.
>
>
> I opened up the log file. I didn’t see any issues. The page opens as normal. However, i click any links. There is no additional log in the file.

Try disabling turbolinks

Colin

> To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/1C03296E-872E-4826-8795-D83CAF91FC93%40gmail.com.

[Jimmy Lin]

I disabled turbolink. I put 'data-turbolinks-track' => false in the application template

I also removed turbolink gem. But still not working. Still does the same thing.

>>>>> email to rubyonrails-talk+unsubscribe@googlegroups.com.
>>>>> To post to this group, send email to rubyonrails-talk@googlegroups.com.

>>>>> To view this discussion on the web visit
>>>>>
>>>>> https://groups.google.com/d/msgid/rubyonrails-talk/86c33c71-c47e-4142-9cc6-61e3889089e4%40googlegroups.com.
>>>>> For more options, visit https://groups.google.com/d/optout.
>>>>
>>>>
>>>> --
>>>> You received this message because you are subscribed to a topic in the
>>>> Google Groups "Ruby on Rails: Talk" group.
>>>> To unsubscribe from this topic, visit
>>>> https://groups.google.com/d/topic/rubyonrails-talk/NMLio7rs4YQ/unsubscribe.
>>>> To unsubscribe from this group and all its topics, send an email to

>>>> rubyonrails-talk+unsubscribe@googlegroups.com.
>>>> To post to this group, send email to rubyonrails-talk@googlegroups.com.

>>>> To view this discussion on the web visit
>>>> https://groups.google.com/d/msgid/rubyonrails-talk/CAL%3D0gLu2x4V8DJ4mYssM8cL0MQDc5bJi%2BVC%2B8H%3DeJUY0_BnTUg%40mail.gmail.com.
>>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>>
>>>
>>>
>>>
>>> --
>>> Thanks
>>> Jimmy
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "Ruby on Rails: Talk" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an

>>> email to rubyonrails-talk+unsub...@googlegroups.com.
>>> To post to this group, send email to rubyonrails-talk@googlegroups.com.

>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/rubyonrails-talk/CAGQPN4n8Q7KFfvoWgodz%3D0%2BhYeOVYJFKds1QeAKaTtPkj3H-gA%40mail.gmail.com.
>>>
>>> For more options, visit https://groups.google.com/d/optout.
>>
>>
>> -- 
>> You received this message because you are subscribed to a topic in the Google Groups "Ruby on Rails: Talk" group.
>> To unsubscribe from this topic, visit https://groups.google.com/d/topic/rubyonrails-talk/NMLio7rs4YQ/unsubscribe.

>> To unsubscribe from this group and all its topics, send an email to rubyonrails-talk+unsub...@googlegroups.com.
>> To post to this group, send email to rubyonrails-talk@googlegroups.com.

>> To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/CAL%3D0gLtsRTEZmFoPha0LsAnMSdjDO0Y%2BnER-d4pjS0KEiftwrA%40mail.gmail.com.
>>
>> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.

> To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-talk+unsubscribe@googlegroups.com.
> To post to this group, send email to rubyonrails-talk@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/1C03296E-872E-4826-8795-D83CAF91FC93%40gmail.com.
>
> For more options, visit https://groups.google.com/d/optout.

--

You received this message because you are subscribed to a topic in the Google Groups "Ruby on Rails: Talk" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/rubyonrails-talk/NMLio7rs4YQ/unsubscribe.

To unsubscribe from this group and all its topics, send an email to rubyonrails-talk+unsubscribe@googlegroups.com.
To post to this group, send email to rubyonrails-talk@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/CAL%3D0gLvqdHT0Cfi2Pj_U85bY-k6pT%2BOk_5kVf9Z2DPxWhn2YJQ%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Thanks

Jimmy

[Colin Law]

On 7 August 2016 at 10:54, Jimmy Lin <jimm...@gmail.com> wrote:
> I disabled turbolink. I put 'data-turbolinks-track' => false in the
> application template
> I also removed turbolink gem. But still not working. Still does the same
> thing.

No need to remove the gem itself, just take it out of Gemfile and
bundle install.

Two more things to try, check in the browser console window that there
are no errors when it loads the page or you click the link. Then
copy/paste the complete page source (in the browser) into the html
validator at https://validator.w3.org/#validate_by_input and fix any
errors.

Colin

[Jimmy Lin]

There is no issue with turbolink nor with any page source. 

Then when i go through my gem file, i found an old gem which i don't need anymore. I checked and it is stated only support for rails 3-4. After I remove it, it works fine now.

Thank you for all your help.

--
You received this message because you are subscribed to a topic in the Google Groups "Ruby on Rails: Talk" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/rubyonrails-talk/NMLio7rs4YQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to rubyonrails-talk+unsubscribe@googlegroups.com.
To post to this group, send email to rubyonrails-talk@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/CAL%3D0gLvmQChX4f8B-3u4-biv8P5NHDkLqwhMjfrWtW7fhFw-5Q%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Thanks

Jimmy

[James Jelinek]

What was the gem causing the conflict?

Sent from my iPhone

You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-ta...@googlegroups.com.
To post to this group, send email to rubyonra...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/CAGQPN4%3DigTm_O4bg%3DbMfKQd55hXsxXffzfw1HMF648xTDqqm4w%40mail.gmail.com.

[Jimmy Lin]

I believe it is  'twitter_ratchet_rails' this one.

To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-talk+unsubscribe@googlegroups.com.

To post to this group, send email to rubyonrails-talk@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/CAGQPN4%3DigTm_O4bg%3DbMfKQd55hXsxXffzfw1HMF648xTDqqm4w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--

You received this message because you are subscribed to a topic in the Google Groups "Ruby on Rails: Talk" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/rubyonrails-talk/NMLio7rs4YQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to rubyonrails-talk+unsubscribe@googlegroups.com.
To post to this group, send email to rubyonrails-talk@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/35521157-0FB8-4388-BEA7-4E4DC5DC87D8%40gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Thanks

Jimmy

[Colin Law]

On 7 August 2016 at 22:36, Jimmy Lin <jimm...@gmail.com> wrote:
> There is no issue with turbolink nor with any page source.
> Then when i go through my gem file, i found an old gem which i don't need
> anymore. I checked and it is stated only support for rails 3-4. After I
> remove it, it works fine now.
> Thank you for all your help.

There certainly was an issue with the page source or javascript.
Probably the javascript. In this case caused by the gem. If there
had been no issue it would have worked.

However this has been useful as it has prompted me to add to my list
of things to check when upgrading - that all gems in Gemfile are
compatible with the new version.

Colin

>
> On Sun, Aug 7, 2016 at 8:51 PM, Colin Law <cla...@gmail.com> wrote:
>>
>> On 7 August 2016 at 10:54, Jimmy Lin <jimm...@gmail.com> wrote:
>> > I disabled turbolink. I put 'data-turbolinks-track' => false in the
>> > application template
>> > I also removed turbolink gem. But still not working. Still does the same
>> > thing.
>>
>> No need to remove the gem itself, just take it out of Gemfile and
>> bundle install.
>>
>> Two more things to try, check in the browser console window that there
>> are no errors when it loads the page or you click the link. Then
>> copy/paste the complete page source (in the browser) into the html
>> validator at https://validator.w3.org/#validate_by_input and fix any
>> errors.
>>
>> Colin
>>
>> --
>> You received this message because you are subscribed to a topic in the
>> Google Groups "Ruby on Rails: Talk" group.
>> To unsubscribe from this topic, visit
>> https://groups.google.com/d/topic/rubyonrails-talk/NMLio7rs4YQ/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to

>> rubyonrails-ta...@googlegroups.com.
>> To post to this group, send email to rubyonra...@googlegroups.com.

>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/rubyonrails-talk/CAL%3D0gLvmQChX4f8B-3u4-biv8P5NHDkLqwhMjfrWtW7fhFw-5Q%40mail.gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
>
>
> --
> Thanks
> Jimmy
>

> --
> You received this message because you are subscribed to the Google Groups

> "Ruby on Rails: Talk" group.

> To unsubscribe from this group and stop receiving emails from it, send an

> email to rubyonrails-ta...@googlegroups.com.
> To post to this group, send email to rubyonra...@googlegroups.com.

> To view this discussion on the web visit

> https://groups.google.com/d/msgid/rubyonrails-talk/CAGQPN4%3DigTm_O4bg%3DbMfKQd55hXsxXffzfw1HMF648xTDqqm4w%40mail.gmail.com.