[PATCH] Fix missing include in RPC names in admin_client

9 views
Skip to first unread message

Ben Grande

unread,
May 18, 2023, 8:35:24 PM5/18/23
to qubes-devel
Seems like a copy and paste issue.
As of know, if I try to replace include/admin-local-ro, as it is using
the path /etc/qubes/policy.d, the file is placed there under the name
admin-local-ro.policy.
For reviewers, check /var/log/qubes/policy-admin.log.

--
Benjamin Grande <ben.gr...@gmail.com>
0001-Fix-missing-include-in-RPC-names-in-admin_client.patch
signature.asc

Marek Marczykowski-Górecki

unread,
May 19, 2023, 8:37:39 AM5/19/23
to qubes-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Thu, May 18, 2023 at 05:49:31PM +0000, Ben Grande wrote:
> Seems like a copy and paste issue.
> As of know, if I try to replace include/admin-local-ro, as it is using
> the path /etc/qubes/policy.d, the file is placed there under the name
> admin-local-ro.policy.
> For reviewers, check /var/log/qubes/policy-admin.log.

Thanks, applied.

>
> --
> Benjamin Grande <ben.gr...@gmail.com>
>
> --
> You received this message because you are subscribed to the Google Groups "qubes-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to qubes-devel...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/qubes-devel/ZGZlKwviLqvWCfJW%40personal-mutt.

> From e684e4c5de379c7412fd256adaf243b73cbff040 Mon Sep 17 00:00:00 2001
> From: Ben Grande <ben.gr...@gmail.com>
> Date: Thu, 18 May 2023 17:32:06 +0000
> Subject: [PATCH] Fix missing include in RPC names in admin_client
>
> Signed-off-by: Ben Grande <ben.gr...@gmail.com>
> ---
> qrexec/policy/admin_client.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qrexec/policy/admin_client.py b/qrexec/policy/admin_client.py
> index c28c2f2..f969260 100644
> --- a/qrexec/policy/admin_client.py
> +++ b/qrexec/policy/admin_client.py
> @@ -57,13 +57,13 @@ class PolicyClient:
> self.call("policy.Replace", name, token + "\n" + content)
>
> def policy_include_replace(self, name: str, content: str, token="any"):
> - self.call("policy.Replace", name, token + "\n" + content)
> + self.call("policy.include.Replace", name, token + "\n" + content)
>
> def policy_remove(self, name: str, token="any"):
> self.call("policy.Remove", name, token)
>
> def policy_include_remove(self, name: str, token="any"):
> - self.call("policy.Remove", name, token)
> + self.call("policy.include.Remove", name, token)
>
> def policy_get_files(self, name: str):
> result = self.call("policy.GetFiles", name)
> --
> Benjamin Grande <ben.gr...@gmail.com>
>




- --
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
-----BEGIN PGP SIGNATURE-----

iQEyBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmRnbYsACgkQ24/THMrX
1ywVsQf3a2z4HfxPy5/mjI46wPnHYF9cWUTfm2WhxRVbRzi/4ZZ+Y5pgekB391bp
Z35mPlx3R80Op/O+8MY/bjqDsZq5tg4SBRfLAMo16NdegUxqJ8fHvYsSPOBYP07v
F1+p84C7MgsNAOMfC1To6O6gmlI49oXIXEFtLWfxhcYz8oiOnUSvE8ZqBixewBnn
3NOX0g4D6U4OckXo0x9FDBrUcRg2P+JspGDJ9EOoQ8UjixVrzFGdRKMAmVTJ8PIb
qOg3o0uQsdh3zciF2XwSi/q2a5U2zoI3SRV0cUf1gD/okcHp3aPREvA9TUzyVubm
ftACp7FMgvBTBJ9cTnHRXBDQqa0O
=K8Jl
-----END PGP SIGNATURE-----
Reply all
Reply to author
Forward
0 new messages