WebOb 1.8.2 has been released

32 views
Skip to first unread message

Bert JW Regeer

unread,
Jun 5, 2018, 8:47:52 PM6/5/18
to Pylons Project, Pylons Project
Hello all,

I have just released WebOb 1.8.2. which fixes an issues with the cookie interface used for adding SameSite to the cookie. This was erroneously only accepting byte strings when it should have simply coerced to bytes as necessary like every other parameter.

Please install from your local PyPi with:

pip install webob==1.8.2

PyPI

Changelog

Docs

Issues

Thanks,
Bert JW Regeer

Jonathan Vanasco

unread,
Jun 6, 2018, 12:29:20 PM6/6/18
to pylons-discuss
I believe this is also the first release that no longer accepts the kwarg "key".  it's functionality was deprecated years ago, and it was officially removed a few years back too. a kwarg that does nothing was left in a few spots though.  if anyone experiences errors from this, their code was already broken for several years, but they didn't realize.

I'm just mentioning this on the off-chance anyone has an issue.

Bert JW Regeer

unread,
Jun 6, 2018, 2:04:20 PM6/6/18
to Pylons Project
This has been the case since 1.7.0 was released…

See https://docs.pylonsproject.org/projects/webob/en/stable/whatsnew-1.7.html#backwards-incompatibility

specifically:

- Response.set_cookie no longer accepts a key argument. This was deprecated in WebOb 1.5 and as mentioned in the deprecation, is being removed in 1.7

Recently some changes were made to remove any last references to `key`, so that things would error if you did try to use it, but those are on master only and have not been back ported to 1.8-branch (yet, I may still do that. I forgot to do it this go-around).

Bert

> On Jun 6, 2018, at 10:29 , Jonathan Vanasco <jvan...@gmail.com> wrote:
>
> I believe this is also the first release that no longer accepts the kwarg "key". it's functionality was deprecated years ago, and it was officially removed a few years back too. a kwarg that does nothing was left in a few spots though. if anyone experiences errors from this, their code was already broken for several years, but they didn't realize.
>
> I'm just mentioning this on the off-chance anyone has an issue.
>
> --
> You received this message because you are subscribed to the Google Groups "pylons-discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to pylons-discus...@googlegroups.com.
> To post to this group, send email to pylons-...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/pylons-discuss/fdf4ef03-7e5f-4061-a87d-53efadcd74e9%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Bert JW Regeer

unread,
Jun 6, 2018, 2:07:15 PM6/6/18
to Pylons Project

Jonathan Vanasco

unread,
Jun 6, 2018, 2:41:35 PM6/6/18
to pylons-discuss


On Wednesday, June 6, 2018 at 2:04:20 PM UTC-4, Bert JW Regeer wrote:
Recently some changes were made to remove any last references to `key`, so that things would error if you did try to use it, but those are on master only and have not been back ported to 1.8-branch (yet, I may still do that. I forgot to do it this go-around).

Ah I thought that was in this release, sorry.  I was the one who found that issue in the docs code.  The point I wanted to get across with the above, is that if you're (erroneously) using `key` now, your code is already broken because it's been accepting that kwarg that has does nothing for years, without raising an exception.
Reply all
Reply to author
Forward
0 new messages