Notes from PR Triage on February 5th, 2014
24 views
Skip to first unread message
Andy Parker
Feb 5, 2014, 1:58:25 PM2/5/14
to puppe...@googlegroups.com
Joined:
Adrien, Ashley, Charlie, Ethan, Felix, Josh, Joshua, Kylo, Rob, Andy, Jeremy
Adrien, Ashley, Charlie, Ethan, Felix, Josh, Joshua, Kylo, Rob, Andy, Jeremy
Items in strikethrough are closed so can come off the review list next week.
Puppet:
2269: Some packaging changes. Andy pinging Haus. WIP Merged by Moses
Puppet:
Held over 4x:
2200: It would cause a regression. Contributor pinged. Need some guidance on how to proceed. Peter and Kylo to work on this. Work continues with the discussion around how to handle versions. Kylo will carry the discussion over to puppet-dev.
http://docs.oracle.com/cd/E26502_01/html/E28984/ghyer.html#fmri
http://docs.oracle.com/cd/E26502_01/html/E28984/ghyer.html#fmri
2212: Moses working on this with contributor. Andy pinged Moses and the contributor about the copyright issues again.
Held over 2x:
Puppet:
2086: Ashley and Adrien will work out the details. Looks good. Want to change the provider name from ruby to ini file. Still in progress but might make it in in the coming week.
2282: Ashley to follow up with the contributor. Hope to join with the contributor today.
2277: Henrik will add a test and merge it in. Merged by Andy
2276: Looks ok, but we need a little bit of backstory to justify that we can actually do this and
needs a ticket. Adrien to look into. Give the contributor another week. Adrien will ping contributor again about info. If we get no response then we will do the investigation ourselves.
2243/2238: Josh to follow-up, checking in with Adrien. Pulling into this week's sprint.
Held over 1x:
Puppet:
2024 - Charlie to review, pull into next sprint. The review is still in progress.
2060 - pull into sprint after this, pup-728. The nagios changes are fine (this is clearly one of those "unmaintained" areas), but there is a change to the transaction code that we need to vet. Kylo or Andy to review the transaction change.
2247 - looks good but substantial, at next triage let's review whether we have bandwidth to tackle this.
2301 - Peter to review, pulling into next sprint Merged
New:
Puppet:
1974: We'd like to see this changed to use the package_settings property and clean up the logic (the "permutations" wording is very confusing and not at all clear what it is trying to achieve). Kylo to put in the feedback.
2012: Josh to rebase onto the current state and merge it in.
2023: Need to squash up and rework the commits. Adrien to take, fix up, to a little validation and merge in (BSD is another area where we'll take what people want)
2026: Adrien and Ashley to go over it. Ask Charlie take a look. We'll just fix it up.
2033: We'd love to get this in. Jasperla got stuck on tests and we don't have capacity to get this in right now. Probably in the 3.6 timeframe.
2050: Sending back to Felix to fix up the error messages to be clearer.
2067: Adrien added comment asking about the removing of quoting the value. Felix will try it out on sure box he has.
2080: Discussed with Felix and decided that this is a hacky patch for a problem that has other, more elegant and complete, workarounds outside of puppet. Closed
--
2024 - Charlie to review, pull into next sprint. The review is still in progress.
2060 - pull into sprint after this, pup-728. The nagios changes are fine (this is clearly one of those "unmaintained" areas), but there is a change to the transaction code that we need to vet. Kylo or Andy to review the transaction change.
2247 - looks good but substantial, at next triage let's review whether we have bandwidth to tackle this.
New:
Puppet:
1974: We'd like to see this changed to use the package_settings property and clean up the logic (the "permutations" wording is very confusing and not at all clear what it is trying to achieve). Kylo to put in the feedback.
2012: Josh to rebase onto the current state and merge it in.
2023: Need to squash up and rework the commits. Adrien to take, fix up, to a little validation and merge in (BSD is another area where we'll take what people want)
2026: Adrien and Ashley to go over it. Ask Charlie take a look. We'll just fix it up.
2033: We'd love to get this in. Jasperla got stuck on tests and we don't have capacity to get this in right now. Probably in the 3.6 timeframe.
2050: Sending back to Felix to fix up the error messages to be clearer.
2067: Adrien added comment asking about the removing of quoting the value. Felix will try it out on sure box he has.
2080: Discussed with Felix and decided that this is a hacky patch for a problem that has other, more elegant and complete, workarounds outside of puppet. Closed
Andrew Parker
Freenode: zaphod42
Twitter: @aparker42
Software DeveloperJoin us at PuppetConf 2014, September 23-24 in San Francisco - http://bit.ly/pupconf14
Erik Dalén
Feb 6, 2014, 8:57:48 AM2/6/14
to Puppet Developers
I couldn't participate, but next week I'll be able to. Will that be enough for getting patches in for the 3.5.0 release?
Otherwise I'm available for a PR triage of my PRs tonight (CET) or so if you guys have time.
--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CANhgQXuh-SfZHvuFtcSZvP9d6Go85p8wB26f%3D9kX_LeovWbPOA%40mail.gmail.com.
For more options, visit https://groups.google.com/groups/opt_out.
Erik Dalén
Andy Parker
Feb 6, 2014, 12:22:48 PM2/6/14
to puppe...@googlegroups.com
On Thu, Feb 6, 2014 at 5:57 AM, Erik Dalén <erik.gus...@gmail.com> wrote:
I couldn't participate, but next week I'll be able to. Will that be enough for getting patches in for the 3.5.0 release?Otherwise I'm available for a PR triage of my PRs tonight (CET) or so if you guys have time.
I think we still have about a week before 3.5.0 will be ready for RC (possibly more, depending on what I learn in a meeting today...sigh). I did take a look just now and merged in the to_data_hash change since we had discussed that one before and I asked Henrik to take a look at the Pops fixup.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CAAAzDLfhtTM4wibg7PbefbRJqstvRO0T2pcw4mw2wsxJ%3DbAZQw%40mail.gmail.com.
For more options, visit https://groups.google.com/groups/opt_out.
Reply all
Reply to author
Forward
0 new messages