Any feedback would be appreciated.
--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Some comments on the metrics:The _total suffix usually indicates a counter, avoid it with other types such as gauges. objects_total seems inconsistent in not having the 'cluster' in there. You should be using ConstMetric rather than setting metrics in collect, this avoids races.
The _count suffix is part of a Summary or Histogram, avoid it with other types. Generally you can remove suffixes such as _count and _total without any loss of meaning. degraded_objects_percent - if this can be calculated from other metrics, then don't export it. In general avoid percentages, ratios are preferred for consistency (and should be calculated in Prometheus).
pool_read_io_total sounds like a counter rather than a guage. I wouldn't usually put 'io' in a name, as read implies that.
monitor_total_kbs should be converted to bytes both as that's our standard, and to be consistent with the rest of the exporter. For monitor_clock_skew and monitor_latency put the units in the metric name (preferably seconds).
Brian
Any feedback would be appreciated.
--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsub...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
I like the idea of scraping stats from individual daemons in isolation. In our scenario, we didn't find the metrics surfaced by them to be that useful for debugging various issues we encountered (unlike how it would be with other daemons like mysqld or httpd, etc.). But when the cluster is "down" (as seen externally) it could be beneficial to know about the state of running process across the ensemble. I will look into writing couple more exporters specially for monitor and OSD daemons.Some comments on the metrics:The _total suffix usually indicates a counter, avoid it with other types such as gauges. objects_total seems inconsistent in not having the 'cluster' in there. You should be using ConstMetric rather than setting metrics in collect, this avoids races.I see. Is "cluster_capacity" a fine alternative to "cluster_bytes_total" if it's a gauge?
Also, the collection process is currently synchronized by https://github.com/digitalocean/ceph_exporter/blob/master/exporter.go#L68-L69. Do you feel like it could still be susceptible to any concurrency issues?
The _count suffix is part of a Summary or Histogram, avoid it with other types. Generally you can remove suffixes such as _count and _total without any loss of meaning. degraded_objects_percent - if this can be calculated from other metrics, then don't export it. In general avoid percentages, ratios are preferred for consistency (and should be calculated in Prometheus).I will update the source to remove both the suffixes. Agreed that the percentage doesn't need to be computed inline, but the one that is being surfaced is bubbled up by Ceph itself so planning to keep it for now.
pool_read_io_total sounds like a counter rather than a guage. I wouldn't usually put 'io' in a name, as read implies that.Good point! Truncating `io`. :) I also didn't realize Counter type had a Set(); always thought they just had Incs(). I will update the type.
monitor_total_kbs should be converted to bytes both as that's our standard, and to be consistent with the rest of the exporter. For monitor_clock_skew and monitor_latency put the units in the metric name (preferably seconds).I can do the conversion inline if that's the requirement for recording sizes/capacity. For both clock skews and latency, measuring time in seconds is too low a resolution. But I see your point and I will add the resolution in the metric name. :)
Brian
Any feedback would be appreciated.
--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
And please let me know (or feel free to open issues/contribute) if there are other changes you would like to see therein.
--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
Brian
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsub...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
And please let me know (or feel free to open issues/contribute) if there are other changes you would like to see therein.
--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsub...@googlegroups.com.
Please help me. How to install Ceph_exporter?
I has installed prometheus + node_exporter
--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsub...@googlegroups.com.
To post to this group, send email to prometheus-developers@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/c5be99ca-9301-4361-a359-ac77aed2e96b%40googlegroups.com.
There are two Ceph exporters you can try. The documentation for them is included on their homepages.
On Mon, Nov 21, 2016 at 7:46 AM, <chie...@gmail.com> wrote:
Please help me. How to install Ceph_exporter?
I has installed prometheus + node_exporter
--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsubscri...@googlegroups.com.
I tried to install your ceph_exporter but failed with:
-----------
user@vm23[/0]:/opt/ceph_exporter/ceph_exporter # go install exporter.go
exporter.go:24:2: cannot find package "github.com/ceph/go-ceph/rados" in any of:
/usr/lib/go-1.7/src/github.com/ceph/go-ceph/rados (from $GOROOT)
($GOPATH not set)
exporter.go:25:2: cannot find package "github.com/digitalocean/ceph_exporter/collectors" in any of:
/usr/lib/go-1.7/src/github.com/digitalocean/ceph_exporter/collectors (from $GOROOT)
($GOPATH not set)
exporter.go:26:2: cannot find package "github.com/prometheus/client_golang/prometheus" in any of:
/usr/lib/go-1.7/src/github.com/prometheus/client_golang/prometheus (from $GOROOT)
($GOPATH not set)
exporter.go:27:2: cannot find package "github.com/prometheus/client_golang/prometheus/promhttp" in any of:
/usr/lib/go-1.7/src/github.com/prometheus/client_golang/prometheus/promhttp (from $GOROOT)
($GOPATH not set)
-----------
What I did was git-cloning https://github.com/digitalocean/ceph_exporter
and than running "go install exporter.go".
Since I'm unfortunately a "no-GO-er" ;-/ this is probably me missing a dependency or something else on how to build the package in go.
Since docker container is not an option here, I would be glad of any hint on how to build the ceph_exporter.
best regards
--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsub...@googlegroups.com.
To post to this group, send email to prometheus-developers@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/7c6b29a1-c601-4a36-b225-4e3790da2ba5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
mkdir <somepath>
cd <somepath>
export GOPATH=<somepath>
go get -u github.com/digitalocean/ceph_exporter
that's it.
If it complains about missing rados headers, obviously one have to install them like:
apt-get install librados-dev
than try again