Deprecating https://github.com/prometheus/nagios_plugins (?)

[Bjoern Rabenstein]

Hi,

More than a year ago, I added a pointer from
https://github.com/prometheus/nagios_plugins (the "old repo") to its
fork https://github.com/magenta-aps/check_prometheus_metric (the "new
repo"), see https://github.com/prometheus/nagios_plugins/pull/26 .

I've never heard any complaints about the new plugin, so I think it's
about time to properly deprecate the old repo.

First of all: Does anyone have any objections?

Assuming we can go forward with it: What do you think is the best
procedure? Ideally, we would redirect from the old to the new
repo. However, that's not as easy as it looks. So far, I think this
would require the following gymnastics:

- Delete the new repo.
- Transfer the ownership of the old repo to magenta-aps with
the same name as the (deleted) new repo.
- Replay all the commits that happened in the new repo to the
transfered repo to make it appear like the new repo before,
just not as a fork.

Does anyone have a better idea?

And if not, should we really do that or would it be better to apply less
magic, just put a big and fat deprecation warning onto the old repo,
and graveyard it after another half year or so?

Any feedback welcome.
--
Björn Rabenstein
[PGP-ID] 0x851C3DA17D748D03
[email] bjo...@rabenste.in

[Matthias Rampke]

I think the no-magic route is better. You can also archive the repo[0] to make it clear that it's read only (with this GitHub feature, do we still need to graveyard anything ourselves?

/MR

[0] https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/archiving-a-github-repository/archiving-repositories

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20210813155716.GE3669%40jahnn.

[Bjoern Rabenstein]

On 17.08.21 10:54, Matthias Rampke wrote:
> I think the no-magic route is better. You can also archive the repo[0] to
> make it clear that it's read only (with this GitHub feature, do we still
> need to graveyard anything ourselves?

That's a good idea. I'll do just that.

In general, I think it still makes sense to graveyard repos if we want
to reduce visibility, e.g. because continue using the code would be
harmful, but in this case, where you could still use the old code but
should go for the fork for new features etc., archiving seems
precisely the right thing to do.

[Julien Pivotto]

We should graveyard it. If you are concerned about redirecting people to the fork, we should transfer the ownership of the repo.

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20210818095542.GS3669%40jahnn.

[Ben Kochie]

+1 to mark archived.

Manually graveyarding things isn't really needed anymore unless we really want to break use of a thing.

To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAMV%3D_gYjKWMns7DgkhBXr3g%3DKVonp4fyGG%2B6GhnhCiO5tEkAjA%40mail.gmail.com.

[Bjoern Rabenstein]

On 18.08.21 12:03, Julien Pivotto wrote:
> We should graveyard it. If you are concerned about redirecting people to
> the fork, we should transfer the ownership of the repo.

Yeah, but transferring the ownership will require quite a risky dance
(because the fork already exists for a while, see my original mail).

In any case, we now have diverging opinions about merely archiving
vs. graveyarding. I'll archive the repo now in any case, because that
doesn't exclude graveyarding later, but "stops the bleeding".

Personally, I'm not very concerned about the redirect, but if we don't
do the redirect, we should graveyard only after a good while (if we
want to do it at all).

Bottom line, I guess: Let's discuss the graveyarding in a few months
time.

[Ben Kochie]

The fork owner can make a manual request to github to mark the repo as not a fork. It's pretty easy to do, I've done this for several other projects.

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20210818105417.GT3669%40jahnn.