lets get back on it

21 views
Skip to first unread message

Lukas Kahwe Smith

unread,
May 15, 2015, 7:54:59 AM5/15/15
to php-fig-psr-9-.
Aloha,

So lets get back to work on this ..

Larry can you merge:
https://github.com/php-fig/fig-standards/pull/393
https://github.com/php-fig/fig-standards/pull/473

While they are still WIPs, I think its good to get the current state into the repo and then open new PRs to improve things further.
That being said, I guess its probably best if people send PRs to my fork with the respective branches in the above PRs to make it easier for me to do my work as editor.

Note there are some interesting comments in https://github.com/php-fig/fig-standards/pull/473 that would be good if someone could work through in detail and try and fix in the proposal.

Finally I would like to use this email as sort of a roll call of who is still interested AND able to invest some time into this in the coming weeks. Just want to see if our pool of contributors is big enough to get something ready or if we need to invite other people to participate.

regards,
Lukas Kahwe Smith
sm...@pooteeweet.org



signature.asc

enygma

unread,
May 18, 2015, 8:46:51 AM5/18/15
to php-fig-psr-...@googlegroups.com


On Friday, May 15, 2015 at 6:54:59 AM UTC-5, Lukas Kahwe Smith wrote:
Aloha,

So lets get back to work on this ..

Larry can you merge:
https://github.com/php-fig/fig-standards/pull/393
https://github.com/php-fig/fig-standards/pull/473

While they are still WIPs, I think its good to get the current state into the repo and then open new PRs to improve things further.
That being said, I guess its probably best if people send PRs to my fork with the respective branches in the above PRs to make it easier for me to do my work as editor.


Agreed, I think moving forward with these is the right way to go - we've spent enough time talking...time for some action :) It'd be awesome to have this as a topic to talk about in September when I share PHP security info at the AppSec USA conference. It'd be even cooler to have some tooling around it for the discovery piece too.
 
Note there are some interesting comments in https://github.com/php-fig/fig-standards/pull/473 that would be good if someone could work through in detail and try and fix in the proposal.

Finally I would like to use this email as sort of a roll call of who is still interested AND able to invest some time into this in the coming weeks. Just want to see if our pool of contributors is big enough to get something ready or if we need to invite other people to participate.


I'm definitely ready to work - I've been preparing for php[tek] but I'm there now and will wrap that this week so I'll have more time.

Larry Garfield

unread,
May 20, 2015, 7:03:19 PM5/20/15
to php-fig-psr-...@googlegroups.com
On 5/18/15 7:46 AM, enygma wrote:
>
>
> On Friday, May 15, 2015 at 6:54:59 AM UTC-5, Lukas Kahwe Smith wrote:
>
> Aloha,
>
> So lets get back to work on this ..
>
> Larry can you merge:
> https://github.com/php-fig/fig-standards/pull/393
> <https://github.com/php-fig/fig-standards/pull/393>
> https://github.com/php-fig/fig-standards/pull/473
> <https://github.com/php-fig/fig-standards/pull/473>
>
> While they are still WIPs, I think its good to get the current state
> into the repo and then open new PRs to improve things further.
> That being said, I guess its probably best if people send PRs to my
> fork with the respective branches in the above PRs to make it easier
> for me to do my work as editor.

Merged!

I'd actually prefer to keep the latest canonical stuff on the main repo.
Every PSR seems to have followed a different process to date, but I
think what MWOP did with PSR-7 worked fairly well where PRs were against
the main repo and just churned quickly as needed. It also means it's
easier to subscribe to updates since it's just the one repo, not some
person's fork of it. (Assuming GitHub's notifications ever work correctly.)

> Agreed, I think moving forward with these is the right way to go - we've
> spent enough time talking...time for some action :) It'd be awesome to
> have this as a topic to talk about in September when I share PHP
> security info at the AppSec USA conference. It'd be even cooler to have
> some tooling around it for the discovery piece too.
>
> Note there are some interesting comments in
> https://github.com/php-fig/fig-standards/pull/473
> <https://github.com/php-fig/fig-standards/pull/473> that would be
> good if someone could work through in detail and try and fix in the
> proposal.
>
> Finally I would like to use this email as sort of a roll call of who
> is still interested AND able to invest some time into this in the
> coming weeks. Just want to see if our pool of contributors is big
> enough to get something ready or if we need to invite other people
> to participate.
>
>
> I'm definitely ready to work - I've been preparing for php[tek] but I'm
> there now and will wrap that this week so I'll have more time.

Still interested! Should we move all activity back to the main list at
this point?

--Larry Garfield

Chris Cornutt

unread,
May 20, 2015, 7:37:59 PM5/20/15
to Larry Garfield, php-fig-psr-9-.

+1 from me to move to the list. Guess I'll have to update from digest mode ;)

> --Larry Garfield
>
>
> --
> You received this message because you are subscribed to the Google Groups "php-fig-psr-9-discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to php-fig-psr-9-disc...@googlegroups.com.
> To post to this group, send email to php-fig-psr-...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig-psr-9-discussion/555D12B6.6070307%40garfieldtech.com.
>
> For more options, visit https://groups.google.com/d/optout.

Lukas Kahwe Smith

unread,
May 21, 2015, 2:41:54 AM5/21/15
to Chris Cornutt, Larry Garfield, php-fig-psr-9-.

> On 21 May 2015, at 01:37, Chris Cornutt <eny...@phpdeveloper.org> wrote:
>
>
> On May 20, 2015 6:03 PM, "Larry Garfield" <la...@garfieldtech.com> wrote:
> >
> > On 5/18/15 7:46 AM, enygma wrote:
> >>
> >>
> >>
> >> On Friday, May 15, 2015 at 6:54:59 AM UTC-5, Lukas Kahwe Smith wrote:
> >>
> >> Aloha,
> >>
> >> So lets get back to work on this ..
> >>
> >> Larry can you merge:
> >> https://github.com/php-fig/fig-standards/pull/393
> >> <https://github.com/php-fig/fig-standards/pull/393>
> >> https://github.com/php-fig/fig-standards/pull/473
> >>
> >> <https://github.com/php-fig/fig-standards/pull/473>
> >>
> >> While they are still WIPs, I think its good to get the current state
> >> into the repo and then open new PRs to improve things further.
> >> That being said, I guess its probably best if people send PRs to my
> >> fork with the respective branches in the above PRs to make it easier
> >> for me to do my work as editor.
> >
> >
> > Merged!

thx

> > I'd actually prefer to keep the latest canonical stuff on the main repo. Every PSR seems to have followed a different process to date, but I think what MWOP did with PSR-7 worked fairly well where PRs were against the main repo and just churned quickly as needed. It also means it's easier to subscribe to updates since it's just the one repo, not some person's fork of it. (Assuming GitHub's notifications ever work correctly.)

ok .. what is the policy there .. do editors then get the right to merge?

> > Still interested! Should we move all activity back to the main list at this point?
> >
>
> +1 from me to move to the list. Guess I'll have to update from digest mode ;)

fine for me. I will then work on an email summarizing the open discussion points over the weekend as I will for once not be playing a frisbee tournament :)
signature.asc

Larry Garfield

unread,
May 21, 2015, 10:58:05 AM5/21/15
to Lukas Kahwe Smith, Chris Cornutt, php-fig-psr-9-.
On 5/21/15 1:41 AM, Lukas Kahwe Smith wrote:

>>>> On Friday, May 15, 2015 at 6:54:59 AM UTC-5, Lukas Kahwe Smith wrote:
>>>>
>>>> Aloha,
>>>>
>>>> So lets get back to work on this ..
>>>>
>>>> Larry can you merge:
>>>> https://github.com/php-fig/fig-standards/pull/393
>>>> <https://github.com/php-fig/fig-standards/pull/393>
>>>> https://github.com/php-fig/fig-standards/pull/473
>>>>
>>>> <https://github.com/php-fig/fig-standards/pull/473>
>>>>
>>>> While they are still WIPs, I think its good to get the current state
>>>> into the repo and then open new PRs to improve things further.
>>>> That being said, I guess its probably best if people send PRs to my
>>>> fork with the respective branches in the above PRs to make it easier
>>>> for me to do my work as editor.
>>>
>>>
>>> Merged!
>
> thx
>
>>> I'd actually prefer to keep the latest canonical stuff on the main repo. Every PSR seems to have followed a different process to date, but I think what MWOP did with PSR-7 worked fairly well where PRs were against the main repo and just churned quickly as needed. It also means it's easier to subscribe to updates since it's just the one repo, not some person's fork of it. (Assuming GitHub's notifications ever work correctly.)
>
> ok .. what is the policy there .. do editors then get the right to merge?

I believe MWOP pinged Beau/Paul (Coordinator/Sponsor) to merge things
for him, to keep some level of separation of concerns and extra review
layer.

--Larry Garfield
Reply all
Reply to author
Forward
0 new messages