[opkg-utils PATCH] Makefile: fixed for-loop in install receipe

[Josh Deweese]

The install receipe would have copied all the manpages to each of the
section folders. This change will do what I believe the original
author had intended.

Signed-off-by: Joshua DeWeese <jdew...@hennypenny.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 69a1c5a..817a8c1 100644
--- a/Makefile
+++ b/Makefile
@@ -23,7 +23,7 @@ install: all
for m in $(MANPAGES); \
do \
install -d $(DESTDIR)$(mandir)/man$${m##*.}; \
- install -m 644 $(MANPAGES) $(DESTDIR)$(mandir)/man$${m##*.}; \
+ install -m 644 "$$m" $(DESTDIR)$(mandir)/man$${m##*.}; \
done

.PHONY: install all
--
2.7.4

---

This email has been scanned for email related threats and delivered safely by Mimecast.
For more information please visit http://www.mimecast.com

---

[Alejandro Del Castillo]

indeed, thanks for the fix!

merged

On 5/29/19 1:57 PM, Josh Deweese wrote:
> The install receipe would have copied all the manpages to each of the
> section folders. This change will do what I believe the original
> author had intended.
>
> Signed-off-by: Joshua DeWeese <jdew...@hennypenny.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 69a1c5a..817a8c1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -23,7 +23,7 @@ install: all
> for m in $(MANPAGES); \
> do \
> install -d $(DESTDIR)$(mandir)/man$${m##*.}; \
> - install -m 644 $(MANPAGES) $(DESTDIR)$(mandir)/man$${m##*.}; \
> + install -m 644 "$$m" $(DESTDIR)$(mandir)/man$${m##*.}; \
> done
>
> .PHONY: install all
> --
> 2.7.4
>
>

> ------------------------------------------------------------------------

> This email has been scanned for email related threats and delivered
> safely by Mimecast.
> For more information please visit http://www.mimecast.com

> <https://urldefense.proofpoint.com/v2/url?u=http-3A__www.mimecast.com&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=4CpS6FJc8M22NggcEPobxbdGMgVqSu2Cidp3Vu5TvWg&s=5M312PgoYylWdBFlLgKJoJQ8f0G3wyILPu4gao7sRTM&e=>
>
> ------------------------------------------------------------------------
>
> --
> You received this message because you are subscribed to the Google
> Groups "opkg-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to opkg-devel+...@googlegroups.com
> <mailto:opkg-devel+...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/opkg-devel/1559156195-16281-1-git-send-email-jdeweese%40hennypenny.com
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__groups.google.com_d_msgid_opkg-2Ddevel_1559156195-2D16281-2D1-2Dgit-2Dsend-2Demail-2Djdeweese-2540hennypenny.com-3Futm-5Fmedium-3Demail-26utm-5Fsource-3Dfooter&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=4CpS6FJc8M22NggcEPobxbdGMgVqSu2Cidp3Vu5TvWg&s=QeXM5tJqewPUjsN8DR4uisXwJm0WRlF0YXlmjLqeLfQ&e=>.
> For more options, visit https://groups.google.com/d/optout
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__groups.google.com_d_optout&d=DwMFaQ&c=I_0YwoKy7z5LMTVdyO6YCiE2uzI1jjZZuIPelcSjixA&r=wNcrL2akRn6jfxhHaKavUrJB_C9JAMXtynjLd8ZzgXQ&m=4CpS6FJc8M22NggcEPobxbdGMgVqSu2Cidp3Vu5TvWg&s=cQIHiAIPWss128sWrswoPioCNgN5oXD1UV7rQSlmn4o&e=>.

--
Cheers,

Alejandro