Is this expected behavior?

[Don Morrison]

Ιn game/game.setup.js I changed setup.debug to

setup.debug = false;

But still, when a potential user timed out in the waiting room they were shown

| DEBUG mode: client-side error detected.
|
| | 0.0.0@10:11:12>
http://localhost:8080/javascripts/nodegame-full.min.js 1,263554:
Uncaught Error: GameTimer.removeHook: gameTimer marked as destroyed:
VisualTimer_8568347
|
| Open the DevTools in your browser for details.
| This message will not be shown in production mode.

But all is well if I also in node.setup(’nodegame’,… in public/js/index.js set

debug : true,

However, I’m surprised I have to do this, as the latter is preceded by
the comment

// All these properties will be overwritten
// by remoteSetup from server.

Is this expected behavior? To turn off debug mode do we have to do it
in both places? Or is there some third place I should be doing it that
will override both of these, or something like that?

Thanks!


--
Don Morrison <d...@ringing.org>
“Easter Island is, of course, the most remote place on earth,
famous for being farther from anywhere than anywhere else is.
Which is why it is odd that I ended up there completely by
accident. …Ι learned a very important lesson from this, which
was — read your ticket.” – Douglas Adams, /The Salmon of Doubt/

[Stefano Balietti]

Hi,

You should set the debug variable in game/game.setup.js.

However, I believe that error was fixed in 7.1.x. Are you on the latest version?

Best,

Stefano

--
You received this message because you are subscribed to the Google Groups "nodeGame" group.
To unsubscribe from this group and stop receiving emails from it, send an email to nodegame+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/nodegame/CAO9hiFViAGRSsyktk7JON1LcKGeKWmpvh8KJh_xD2aS2uSdspg%40mail.gmail.com.

[Don Morrison]

On Mon, Apr 11, 2022 at 12:26 PM Stefano Balietti <futur...@gmail.com> wrote:
> You should set the debug variable in game/game.setup.js.
>
> However, I believe that error was fixed in 7.1.x. Are you on the latest version?

I’m running 7.1.0 (at least that’s what the directory name says; is
there a better way to check?). The installer appears to claim that
this is the latest stable version.


--
Don Morrison <d...@ringing.org>
“Nothing is wholly obvious without becoming enigmatic. Reality itself
is too obvious to be true.” – Jean Baudrillard, /The Perfect Crime/

[Stefano Balietti]

Ok, could you please check if it happens also with the dev version? It is still 7.1.0, but it has -dev at the end of the folder name.

--
You received this message because you are subscribed to the Google Groups "nodeGame" group.
To unsubscribe from this group and stop receiving emails from it, send an email to nodegame+u...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/nodegame/CAO9hiFVz-qc1uD%3D%3Dr4B8i4eV9vNrP%2BHAGhy8dzmXPwR%3Dce9i7g%40mail.gmail.com.

[Don Morrison]

On Mon, Apr 11, 2022 at 1:52 PM Stefano Balietti <futur...@gmail.com> wrote:
> Ok, could you please check if it happens also with the dev version?
> It is still 7.1.0, but it has -dev at the end of the folder name.

Afraid it still happens in the dev version (that is, even with debug
false in game.setup.js when a player times out in the waiting room a
debug screen is put up instead of the more benign one).

Also, in struggling to get the dev version installed I stumbled upon
the following:

If I install nodegame (either dev or stable) in /tmp/, when I try to do

bin/nodegame create-game foobar

I get

bash: bin/nodegame: Permission denied

For some reason when installed in /tmp the target of that link appears
to not be getting execute permission. If I fix that with

chmod a+x chmod a+x
/tmp/nodegame-v7.1.0-dev/node_modules/nodegame-generator/bin/nodegame

and try to create a game again I get

bash: bin/nodegame: /usrng/bin/env: bad interpreter: No such file or directory

Looks like maybe a typo in that path, which should perhaps be
/usr/bin/env? I’ve confirmed that it does indeed say “/usrng/” in the
shebang line of
/tmp/nodegame-v7.1.0-dev/node_modules/nodegame-generator/bin/nodegame.

I ended up just cloning an existing game from elsewhere into the new
installation to play with.


--
Don Morrison <d...@ringing.org>
“Science explained people, but could not understand them.”
– E M Forster, /Howards End/

[Stefano Balietti]

I checked and the dev version is still affected, however that timer issue is fixed in another branch not yet merged in master. 

I now realize why setting debug: false in game.setup does not help. That is the setup of the game, but the error happens in the waiting room, where that setting is not applied yet. It would require a little overhaul to apply consistently the debug setting, for now you have to change it manually in both places. Sorry about that! I opened a Github issue to remember about it.

--
You received this message because you are subscribed to the Google Groups "nodeGame" group.
To unsubscribe from this group and stop receiving emails from it, send an email to nodegame+u...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/nodegame/CAO9hiFXOaiY0BMZfncKqC6GmMpGi4Sfn_4VNGqYLmLtF6EGc8w%40mail.gmail.com.