Your feedback wanted for flatten-maven-plugin and "Maven CI Friendly Versions"

35 views
Skip to first unread message

Jörg Hohwiller

unread,
Dec 13, 2018, 4:28:03 PM12/13/18
to mojohaus-dev
Hi there,

ever seen this before:

here is my review on the according PR to flatten-maven-plugin:

Your feedback would be highly appreciated.
IMHO this is somewhat flawed design, but I do not want to be harsh and would love to hear other oppinions.

Cheers
  Jörg

Mirko Friedenhagen

unread,
Dec 14, 2018, 1:14:49 AM12/14/18
to mojoha...@googlegroups.com
Hello Jörg,

I agree with you that sha1 and changelist might be confusing, however they are out on the street (die Katze ist aus dem Sack) now for almost two years now, so I think they need to be supported in flatten as well.

Best Regards
Mirko Friedenhagen

Sent from my mobile

Am 13.12.18 um 22:28 schrieb 'Jörg Hohwiller' via mojohaus-dev
> --
> You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
> To post to this group, send email to mojoha...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/a4cb7c43-8308-4d26-90f6-4f72211c94b4%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Reply all
Reply to author
Forward
0 new messages