Release please?

[Stephanie Wang]

Hi,

We're hoping to use flatten-maven-plugin in our project with https://github.com/mojohaus/flatten-maven-plugin/pull/134 (bug fix) rolled out. Could we please do a release?

Thanks,

Stephanie Wang and Ray Tsang

[Lasse Lindqvist]

I will try to find time to do it today or tomorrow.

[Stephanie Wang]

Thank you!

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/2faf35d4-6efb-4cc7-b163-4210fad27981%40googlegroups.com.

--

Stephanie Wang stephwang@google.com Developer Programs Engineer BigQuery, Java

[Stephanie Wang]

Friendly ping on this. Thank you!

[Lasse Lindqvist]

Sorry but the tests were failing https://github.com/mojohaus/flatten-maven-plugin/issues/136 so unless somebody beats me to it, I will take a look at it during the weekend.

[Olivier Lamy]

fixed.

Now you can release.

Enjoy :) 

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/2deb4749-3df1-4088-94fb-de7e620d3975%40googlegroups.com.

--

Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

[Stephanie Wang]

Thank you for your help!

Please let us know if release is blocked by anything. Otherwise, this is a gentle ping. 

Thanks!

[Lasse Lindqvist]

Sorry but the test failure still reproduces in my environment, so I cannot release yet. See https://github.com/mojohaus/flatten-maven-plugin/issues/140 for the situation. Hopefully we can resolve this soon.

[Olivier Lamy]

Ok I will try to release it.

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/5d21616a-a641-4f96-92a1-a1f9b19b48aa%40googlegroups.com.

[Lasse Lindqvist]

I kind of meant "I would not like to release" more than "I cannot". The fact is that it has a failing test, maybe it is a regression, maybe not. If the test does not work on Windows, for example, does it mean that the functionality is broken on Windows, or just the test?

tiistai 31. maaliskuuta 2020 4.07.39 UTC+3 Olivier Lamy kirjoitti:

Ok I will try to release it.

To unsubscribe from this group and stop receiving emails from it, send an email to mojoha...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/5d21616a-a641-4f96-92a1-a1f9b19b48aa%40googlegroups.com.

[Olivier Lamy]

On Tue, 31 Mar 2020 at 14:00, Lasse Lindqvist <lasse.k....@gmail.com> wrote:

I kind of meant "I would not like to release" more than "I cannot". The fact is that it has a failing test, maybe it is a regression, maybe not. If the test does not work on Windows, for example, does it mean that the functionality is broken on Windows, or just the test?

not sure. But it's not a regression as it concerns a new feature and the IT only fail for windows.

So I do not consider this as blocker 

 

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/a9219e7e-3e6c-41db-bc2f-050fd66b037b%40googlegroups.com.

[Stephanie Wang]

Thank you for the release!

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqRopSKPy5rTKnrKrK%3DRHpkv20icGKRSp4wNE%3DvQ50iwOw%40mail.gmail.com.

[Stephanie Wang]

Looks like maven central still doesn't have version 1.2.2. Any idea why it's taking so long this time? I see the artifact in sonatype. Does it usually take this long? Thanks!

[Olivier Lamy]

Hi 

The procedure has a vote phase which is 72h from the start of the vote. https://groups.google.com/d/msg/mojohaus-dev/SUpfz0L1_cc/s2_pqGwEBAAJ  

So we still need to wait 48h (I know it's weird but it's probably some "heritage" from the past :) ) 

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/a8cf615d-eadd-451e-80c1-b23bcc5ea07f%40googlegroups.com.

[Stephanie Wang]

Ah - understood. Thanks. Will check back in 48h.

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqTus0_RhXt9aAR%2Bzkw_VXUS3W8HP60%3D5CRiVbFoYrhE5w%40mail.gmail.com.

[Hervé Boutemy]

you can also participate to the vote = test the staged artifact and confirm it's working as expected, so Olivier can publish the release in 48h with more confidence than only his own conviction

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAFzfq_6DG%2B1SPAi4QDNWugO3yVqfN5HVwvnRRKB08Nhrji%3D3rg%40mail.gmail.com.

[Stephanie Wang]

+1

Thanks for the pointer. 

I tried the staged artifact by using the <version> and <profile> below and it worked as expected with resolution order and missing artifact issues fixed.

<plugin>

          <groupId>org.codehaus.mojo</groupId>

          <artifactId>flatten-maven-plugin</artifactId>

          <version>1.2.2</version>

          ...

</plugin>

<profiles>

    <profile>

      <id>staged-releases</id>

      <pluginRepositories>

        <pluginRepository>

          <id>staged-releases</id>

          <url>https://oss.sonatype.org/content/repositories/orgcodehausmojo-1164/</url>

        </pluginRepository>

      </pluginRepositories>

    </profile>

</profiles>

Thank you.