CJ: My Assignment This Week

[Kyle Johnson]

I will be in contact with you in regards to my assignment this week. 

My assignment is to move the tests that are in mathpiper4/src/org/mathpiper/scripts4/lists/lists_tests.mpws into the files of the procedures they test. After all of the tests have been moved, I am to delete this file.

If you are in this file let me know and we can distribute work load.

Thanks!

Kyle

[Christopher McCormick]

Kyle,

Thanks for the heads up! I was working in a few of the scripts4/lists mpws files.

BuildList, Contains, Count, Difference, and Drop have had their examples converted from the *E.G. format to the *EXAMPLES format. This is only on my local repo, but will be included in my next pull request.

Additionally, I had not realized there was a lists_tests.mpws file testing all of the list procedures. I had added automatic tests to those five files and they have been merged. If you want to leave them as is, I think they are testing fine now, but you can also feel free to replace with the tests in the lists_test.mpws file if they are a better fit. 

CJ

[Ted Kosan]

I just quickly looked through scripts4, and the following files also
contain tests that need to be moved into the files of the procedures
they test:

scripts4/a_initialization/miscellaneous/issues_tests.mpws
scripts4/a_initialization/stdarith/arithmetic_test.mpws

There may or may not be more files like this.

Ted

> --
> You received this message because you are subscribed to the Google Groups "mathpiper-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to mathpiper-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/mathpiper-dev/2f8f5a4a-4a3c-4d5b-9319-3da882b3da69%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Kyle Johnson]

Ted, you may have to decline my most recent pull request as I forgot to close the VarList automatic_test fold. Does it look like I added the automatic test correctly to that file though outside of that mistake?

On Friday, May 31, 2019 at 4:20:03 PM UTC-4, tkosan wrote:

I just quickly looked through scripts4, and the following files also
contain tests that need to be moved into the files of the procedures
they test:

scripts4/a_initialization/miscellaneous/issues_tests.mpws
scripts4/a_initialization/stdarith/arithmetic_test.mpws

There may or may not be more files like this.

Ted

On Fri, May 31, 2019 at 2:17 PM Christopher McCormick
<cjmcco...@gmail.com> wrote:
>
> Kyle,
>
> Thanks for the heads up! I was working in a few of the scripts4/lists mpws files.
>
> BuildList, Contains, Count, Difference, and Drop have had their examples converted from the *E.G. format to the *EXAMPLES format. This is only on my local repo, but will be included in my next pull request.
>
> Additionally, I had not realized there was a lists_tests.mpws file testing all of the list procedures. I had added automatic tests to those five files and they have been merged. If you want to leave them as is, I think they are testing fine now, but you can also feel free to replace with the tests in the lists_test.mpws file if they are a better fit.
>
> CJ
>
> --
> You received this message because you are subscribed to the Google Groups "mathpiper-dev" group.

> To unsubscribe from this group and stop receiving emails from it, send an email to mathpi...@googlegroups.com.

[Ted Kosan]

Kyle,

Did your changes pass the test suite (after rebuilding MathPiper)?

Ted

> To unsubscribe from this group and stop receiving emails from it, send an email to mathpiper-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/mathpiper-dev/1d349c38-d823-4d7f-9b3f-a044c0b5ac04%40googlegroups.com.