RFC: possible new review rules

[Ron Minnich]

code is in cmds/exp, either existing or new (can't change packages)
it does not reduce our code quality, i.e. it passes all tests and we
still get an A+ (how do we find that out)
it has tests and has > 80% coverage with either new or changed code
If there are no objections in 7 days, then any approver can approve it
and any submitter can submit it *without doing a review*

If requests are made, and the person makes the changes, we restart
at first condition above.

[Ryan O'Leary]

I like the idea. Can these rules also apply to doing a "dep update"?

--
You received this message because you are subscribed to the Google Groups "linuxboot" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linuxboot+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/linuxboot/CAPAv03NGw-hwChUKTa1FgtJt9V9ysbNakdtkEEQVsGaNLmp2ig%40mail.gmail.com.

[Ron Minnich]

yes. Where can we put the rules? In the README.md?

[Ryan O'Leary]

For oreboot, we're using auto-merge. You can see this as an example: https://github.com/oreboot/oreboot/blob/master/.github/auto-merge.yml

However, I don't see a setting to wait for 7 days.