Query about Lemaker LCD 3.5 patch

[destroyedlolo]

Hello,

I'm trying to upgrade my BananaPI to latest 5.x kernel. Unfortunately, it doesn't support 3.5 LCD display as per it's DTS.

A found a patch from Paul Kocialkowski : https://lkml.org/lkml/2018/11/7/980

But despite responses saying patches have been committed, as said the DTS doesn't contain LCD entries and I can even apply sources code :

As example, in drivers/gpu/drm/sun4i/sun4i_tcon.c some patch's code are included but some other not :(

How can I provide support to this LCD screen ?

Thanks

Laurent

[Clément Péron]

Hi Laurent,

If it's not already done you can also ask to the Author of the commit.
I have added him in CC to this mail maybe he has a branch with the
patch up-to-date.

I didn't check myself but Maintainers reply in latest version v3: that
patches are applied.
https://patchwork.kernel.org/cover/10672823/

Which Kernel 5.x are you talking about? And which BananaPi do you have?

Except patch 7 and 8 which are marked as "NOT,FOR,MERGE".
If you are on 5.6 normally you just have to download patch 7 and 8
and apply them.
v3 patch 7/8 : https://patchwork.kernel.org/patch/10672845/
v3 patch 8/8: https://patchwork.kernel.org/patch/10672857/

Regards,
Clement

>
> Thanks
>
> Laurent
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi...@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/b184feb1-f6e7-4eec-8541-e1d4078ae825%40googlegroups.com.

[destroyedlolo]

Hi Clement and thanks for your reply.

I sent a mail to Paul :)

I'm using the 1st BananaPI released by LeMaker.

I downloaded on Friday the latest stable kernel from kernel.org (using the git clone command from Sunxi website).

I'll will try to apply provided fixes (links doesn't work but I found them :) ).

Why are they marked "Not for merge" ? Does it mean I'll have to reapply them for next kernel updgrade ?

Thanks

Laurent

[Priit Laes]

"Not for merge" is used for hardware that is not integrated by default with
the devices and are only used for demonstration purposes to show how the
functionality works.

Those patches should be either applied by users of this hardware themselves
either by patching kernel or using devicetree overlays.

>
> Thanks
>
> Laurent
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi...@googlegroups.com.

> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/a0d4ce79-63b5-478b-beb8-35eb1d3eb373%40googlegroups.com.

[destroyedlolo]

Hi,

Unfortunately, patches doesn't work as they are.

For exemple :

https://patchwork.kernel.org/patch/10672845/

The patch is expecting in arch/arm/boot/dts/sun7i-a20.dtsi, around line 811, something link

mmc0_pins_a: mmc0@0 {

but mmc0_pins_a doesn't exist. Instead, I got 
mmc0_pins: mmc0-pins { ...

Anyway, I'll try to apply patches manually.

Bye

Laurent

[Clément Péron]

Hi Laurent,

On Mon, 6 Apr 2020 at 21:33, 'destroyedlolo' via linux-sunxi
<linux...@googlegroups.com> wrote:
>
> Hi,
>
> Unfortunately, patches doesn't work as they are.
> For exemple :
> https://patchwork.kernel.org/patch/10672845/
>
> The patch is expecting in arch/arm/boot/dts/sun7i-a20.dtsi, around line 811, something link
>

You can use "patch -p1 < 7/8.patch"
patch is more tolerant than "git am"

Regards,
Clement

> mmc0_pins_a: mmc0@0 {
>
> but mmc0_pins_a doesn't exist. Instead, I got
> mmc0_pins: mmc0-pins { ...
>
> Anyway, I'll try to apply patches manually.
>
> Bye
>
> Laurent
>

> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi...@googlegroups.com.

> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/a27654e7-08fe-48f6-8d21-f9ebedda1874%40googlegroups.com.

[Igor Pecovnik]

Here https://forum.armbian.com/topic/7233-bananapi-pro-7-touchlcd-with-debian-buster-and-mainline-kernel-5xxxx/ you have step by step guide for 7" which is almost identical display.

Dne ponedeljek, 06. april 2020 01.00.25 UTC+2 je oseba destroyedlolo napisala:

[destroyedlolo]

Hi Igor,

Nice to see U here :)

I did applied the patch manually and was able to compile the DTS.

As soon as I finished to work, I'll reinstall my bPI system to test and let the group knows if it's working.

Anyway, are you sure GPIO are the sames ? As far I remind, the FEX are different, no ?

Bye

Laurent

[Igor Pecovnik]

Hi,

Well, I am not sure but in should not be much of a difference between 3.5" and 7". Its a good reference point if nothing else.

Good luck,

Igor

Dne torek, 07. april 2020 16.10.30 UTC+2 je oseba destroyedlolo napisala:

[destroyedlolo]

Hello,

So I've been able to compile both the kernel and the patched DTS ... but I got only framebuffer which is the HDMI one.

# cat /proc/fb
0 simple

and in DMEG 

Saisissez le code itorchwood /proc # dmesg | grep frame
[    0.055836] simple-framebuffer 7fb00000.framebuffer: framebuffer at 0x7fb00000, 0x500000 bytes, mapped to 0x(ptrval)
[    0.055856] simple-framebuffer 7fb00000.framebuffer: format=x8r8g8b8, mode=1280x1024x32, linelength=5120
[    0.077938] Console: switching to colour frame buffer device 160x64
[    0.099423] simple-framebuffer 7fb00000.framebuffer: fb0: simplefb registered!
ci...

Do I have anything to add to enable the second framebuffer ?

Thanks

Laurent

[destroyedlolo]

Hello,

I did some additional test : I was thinking the problem was because some modules are missing.

So I rebuilt my kernel with additional config :

> CONFIG_DRM_PANEL_SIMPLE=y
> CONFIG_BACKLIGHT_CLASS_DEVICE=y
> CONFIG_BACKLIGHT_GENERIC=y
> CONFIG_BACKLIGHT_PWM=y
> CONFIG_BACKLIGHT_GPIO=y

but after reboot, I'm still having only the HDMI detected but I lost /dev/dri directory, only /dev/fb0

Here the dmesg without DRM activated : http://dpaste.com/1TJJJ22

Here the dmesg with DRM activated : http://dpaste.com/0WRK2ZR

Any clue ?

Thanks

Laurent

[destroyedlolo]

Well, trying to boot with the patched DTS even with the original kernel is disabling DRM (no /dev/dri, no mention to DRM in dmesg :( )

[destroyedlolo]

Several tests today again ... with the same result.

I even did a try with the HDMI display disconnected in case it will disable the LCD : same result.

Something coming to my mind : is the TCON relying on touchscreen to load ?

Thanks