[PATCH] NTB: ntb_hw_idt: Set NTB_TOPO_SWITCH topology

11 views
Skip to first unread message

Serge Semin

unread,
Nov 30, 2017, 4:41:10 PM11/30/17
to jdm...@kudzu.us, dave....@intel.com, Allen...@emc.com, Shyam-su...@amd.com, Xiangl...@amd.com, Sergey...@t-platforms.ru, linu...@googlegroups.com, linux-...@vger.kernel.org, Serge Semin
Since Switchtec patch there has been a new topology added to
the NTB API. It's called NTB_TOPO_SWITCH and dedicated for
PCIe switch chips. Even though topo field isn't used within the
IDT driver much, lets set it for the sake of unification.

Signed-off-by: Serge Semin <fancer...@gmail.com>
Acked-by: Serge Semin <fancer...@gmail.com>
---
drivers/ntb/hw/idt/ntb_hw_idt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c
index d87dbd4bc82c..27fdd14e0dca 100644
--- a/drivers/ntb/hw/idt/ntb_hw_idt.c
+++ b/drivers/ntb/hw/idt/ntb_hw_idt.c
@@ -2070,7 +2070,7 @@ static int idt_register_device(struct idt_ntb_dev *ndev)

/* Initialize the rest of NTB device structure and register it */
ndev->ntb.ops = &idt_ntb_ops;
- ndev->ntb.topo = NTB_TOPO_PRI;
+ ndev->ntb.topo = NTB_TOPO_SWITCH;

ret = ntb_register_device(&ndev->ntb);
if (ret != 0) {
--
2.12.0

Logan Gunthorpe

unread,
Nov 30, 2017, 5:06:18 PM11/30/17
to Serge Semin, jdm...@kudzu.us, dave....@intel.com, Allen...@emc.com, Shyam-su...@amd.com, Xiangl...@amd.com, Sergey...@t-platforms.ru, linu...@googlegroups.com, linux-...@vger.kernel.org


On 30/11/17 02:41 PM, Serge Semin wrote:
> Since Switchtec patch there has been a new topology added to
> the NTB API. It's called NTB_TOPO_SWITCH and dedicated for
> PCIe switch chips. Even though topo field isn't used within the
> IDT driver much, lets set it for the sake of unification.
>
> Signed-off-by: Serge Semin <fancer...@gmail.com>
> Acked-by: Serge Semin <fancer...@gmail.com>

You don't need to Ack your own patches ;)

Reviewed-by: Logan Gunthorpe <log...@deltatee.com>

Serge Semin

unread,
Nov 30, 2017, 5:14:31 PM11/30/17
to Logan Gunthorpe, jdm...@kudzu.us, dave....@intel.com, Allen...@emc.com, Shyam-su...@amd.com, Xiangl...@amd.com, Sergey...@t-platforms.ru, linu...@googlegroups.com, linux-...@vger.kernel.org
On Thu, Nov 30, 2017 at 03:06:15PM -0700, Logan Gunthorpe <log...@deltatee.com> wrote:
>
>
> On 30/11/17 02:41 PM, Serge Semin wrote:
> >Since Switchtec patch there has been a new topology added to
> >the NTB API. It's called NTB_TOPO_SWITCH and dedicated for
> >PCIe switch chips. Even though topo field isn't used within the
> >IDT driver much, lets set it for the sake of unification.
> >
> >Signed-off-by: Serge Semin <fancer...@gmail.com>
> >Acked-by: Serge Semin <fancer...@gmail.com>
>
> You don't need to Ack your own patches ;)
>

It goes to the subsystem maintained by me. I tested the change, so am responsible
for the results.

> Reviewed-by: Logan Gunthorpe <log...@deltatee.com>
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+...@googlegroups.com.
> To post to this group, send email to linu...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/05386287-e0c2-5dd3-4e9b-6f64c61f8405%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.

Logan Gunthorpe

unread,
Nov 30, 2017, 5:27:58 PM11/30/17
to Serge Semin, jdm...@kudzu.us, dave....@intel.com, Allen...@emc.com, Shyam-su...@amd.com, Xiangl...@amd.com, Sergey...@t-platforms.ru, linu...@googlegroups.com, linux-...@vger.kernel.org


On 30/11/17 03:14 PM, Serge Semin wrote:
>>> Signed-off-by: Serge Semin <fancer...@gmail.com>
>>> Acked-by: Serge Semin <fancer...@gmail.com>
>>
>> You don't need to Ack your own patches ;)
>>
>
> It goes to the subsystem maintained by me. I tested the change, so am responsible
> for the results.

Yes, but it goes without saying that a patch you wrote, you ack.

Logan
Reply all
Reply to author
Forward
0 new messages