[PATCH] Documentation: kunit: correct KUNIT_VERY_SLOW to KUNIT_SPEED_VERY_SLOW

4 views
Skip to first unread message

Kemeng Shi

unread,
Mar 20, 2024, 4:18:11 AMMar 20
to brendan...@linux.dev, davi...@google.com, rm...@google.com, cor...@lwn.net, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linu...@vger.kernel.org, linux-...@vger.kernel.org
There is no KUNIT_VERY_SLOW, I guess we mean KUNIT_SPEED_VERY_SLOW.

Signed-off-by: Kemeng Shi <shik...@huaweicloud.com>
---
Documentation/dev-tools/kunit/running_tips.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst
index bd689db6fdd2..482f598d141c 100644
--- a/Documentation/dev-tools/kunit/running_tips.rst
+++ b/Documentation/dev-tools/kunit/running_tips.rst
@@ -294,7 +294,7 @@ macro to define the test case instead of ``KUNIT_CASE(test_name)``.
.. code-block:: c

static const struct kunit_attributes example_attr = {
- .speed = KUNIT_VERY_SLOW,
+ .speed = KUNIT_SPEED_VERY_SLOW,
};

static struct kunit_case example_test_cases[] = {
@@ -311,7 +311,7 @@ suite definition.
.. code-block:: c

static const struct kunit_attributes example_attr = {
- .speed = KUNIT_VERY_SLOW,
+ .speed = KUNIT_SPEED_VERY_SLOW,
};

static struct kunit_suite example_test_suite = {
--
2.30.0

David Gow

unread,
Mar 22, 2024, 12:12:26 AMMar 22
to Kemeng Shi, brendan...@linux.dev, rm...@google.com, cor...@lwn.net, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linu...@vger.kernel.org, linux-...@vger.kernel.org
On Wed, 20 Mar 2024 at 16:18, Kemeng Shi <shik...@huaweicloud.com> wrote:
>
> There is no KUNIT_VERY_SLOW, I guess we mean KUNIT_SPEED_VERY_SLOW.
>
> Signed-off-by: Kemeng Shi <shik...@huaweicloud.com>
> ---

Nice catch, thanks!

Reviewed-by: David Gow <davi...@google.com>

Cheers,
-- David

> Documentation/dev-tools/kunit/running_tips.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst
> index bd689db6fdd2..482f598d141c 100644
> --- a/Documentation/dev-tools/kunit/running_tips.rst
> +++ b/Documentation/dev-tools/kunit/running_tips.rst
> @@ -294,7 +294,7 @@ macro to define the test case instead of ``KUNIT_CASE(test_name)``.
> .. code-block:: c
>
> static const struct kunit_attributes example_attr = {
> - .speed = KUNIT_VERY_SLOW,
> + .speed = KUNIT_SPEED_VERY_SLOW,
> };
>
> static struct kunit_case example_test_cases[] = {
> @@ -311,7 +311,7 @@ suite definition.
> .. code-block:: c
>
> static const struct kunit_attributes example_attr = {
> - .speed = KUNIT_VERY_SLOW,
> + .speed = KUNIT_SPEED_VERY_SLOW,
> };
>
> static struct kunit_suite example_test_suite = {
> --
> 2.30.0
>
> --
> You received this message because you are subscribed to the Google Groups "KUnit Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kunit-dev+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/20240320171424.6536-1-shikemeng%40huaweicloud.com.

Jonathan Corbet

unread,
Apr 2, 2024, 12:15:32 PMApr 2
to David Gow, Kemeng Shi, brendan...@linux.dev, rm...@google.com, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linu...@vger.kernel.org, linux-...@vger.kernel.org
David Gow <davi...@google.com> writes:

> On Wed, 20 Mar 2024 at 16:18, Kemeng Shi <shik...@huaweicloud.com> wrote:
>>
>> There is no KUNIT_VERY_SLOW, I guess we mean KUNIT_SPEED_VERY_SLOW.
>>
>> Signed-off-by: Kemeng Shi <shik...@huaweicloud.com>
>> ---
>
> Nice catch, thanks!
>
> Reviewed-by: David Gow <davi...@google.com>

Let me know if you'd like me to pick this up; otherwise I'm assuming it
will go via the kunit path.

Thanks,

jon
Reply all
Reply to author
Forward
0 new messages