[PATCH v1] kunit: tool: update riscv QEMU config with new serial dependency

1 view
Skip to first unread message

Brendan Higgins

unread,
May 11, 2022, 8:30:39 PM5/11/22
to sh...@kernel.org, davi...@google.com, dlat...@google.com, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linux-...@vger.kernel.org, Brendan Higgins
The config for the serial console for riscv,
CONFIG_SERIAL_EARLYCON_RISCV_SBI, added a dependency,
CONFIG_RISCV_SBI_V01, at some point, so add that in to the base arch
config.

Signed-off-by: Brendan Higgins <brendan...@google.com>
---
tools/testing/kunit/qemu_configs/riscv.py | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/testing/kunit/qemu_configs/riscv.py b/tools/testing/kunit/qemu_configs/riscv.py
index 9e528087cd7c..a7a4ab8093b1 100644
--- a/tools/testing/kunit/qemu_configs/riscv.py
+++ b/tools/testing/kunit/qemu_configs/riscv.py
@@ -21,6 +21,7 @@ CONFIG_SOC_VIRT=y
CONFIG_SERIAL_8250=y
CONFIG_SERIAL_8250_CONSOLE=y
CONFIG_SERIAL_OF_PLATFORM=y
+CONFIG_RISCV_SBI_V01=y
CONFIG_SERIAL_EARLYCON_RISCV_SBI=y''',
qemu_arch='riscv64',
kernel_path='arch/riscv/boot/Image',

base-commit: feb9c5e19e913b53cb536a7aa7c9f20107bb51ec
--
2.36.0.550.gb090851708-goog

David Gow

unread,
May 12, 2022, 9:24:16 AM5/12/22
to Brendan Higgins, Shuah Khan, Daniel Latypov, open list:KERNEL SELFTEST FRAMEWORK, KUnit Development, Linux Kernel Mailing List
On Thu, May 12, 2022 at 8:30 AM 'Brendan Higgins' via KUnit
Development <kuni...@googlegroups.com> wrote:
>
> The config for the serial console for riscv,
> CONFIG_SERIAL_EARLYCON_RISCV_SBI, added a dependency,
> CONFIG_RISCV_SBI_V01, at some point, so add that in to the base arch
> config.
>
> Signed-off-by: Brendan Higgins <brendan...@google.com>
> ---

Thanks! I actually hit this issue looking at rust stuff the other day,
but didn't have a chance to look into it properly.

This looks good, and works for me.

Reviewed-by: David Gow <davi...@google.com>

-- David


> tools/testing/kunit/qemu_configs/riscv.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/kunit/qemu_configs/riscv.py b/tools/testing/kunit/qemu_configs/riscv.py
> index 9e528087cd7c..a7a4ab8093b1 100644
> --- a/tools/testing/kunit/qemu_configs/riscv.py
> +++ b/tools/testing/kunit/qemu_configs/riscv.py
> @@ -21,6 +21,7 @@ CONFIG_SOC_VIRT=y
> CONFIG_SERIAL_8250=y
> CONFIG_SERIAL_8250_CONSOLE=y
> CONFIG_SERIAL_OF_PLATFORM=y
> +CONFIG_RISCV_SBI_V01=y
> CONFIG_SERIAL_EARLYCON_RISCV_SBI=y''',
> qemu_arch='riscv64',
> kernel_path='arch/riscv/boot/Image',
>
> base-commit: feb9c5e19e913b53cb536a7aa7c9f20107bb51ec
> --
> 2.36.0.550.gb090851708-goog
>
> --
> You received this message because you are subscribed to the Google Groups "KUnit Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kunit-dev+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/20220512003026.3413497-1-brendanhiggins%40google.com.
Reply all
Reply to author
Forward
0 new messages