Re: [code-organization] Extracting hyperkube

12 views
Skip to first unread message

Lubomir I. Ivanov

unread,
Aug 11, 2019, 2:49:33 PM8/11/19
to Davanum Srinivas, kubernetes-sig-architecture, kubernetes-sig-cluster-lifecycle
AFAIK, SAP have claimed to use hyperkube in production.
should / can we mark the image as deprecated in 1.16 and possibly
remove in 1.17?

lubomir
--

On Sat, 10 Aug 2019 at 01:22, Davanum Srinivas <dav...@gmail.com> wrote:
>
> Team,
>
> Do we know who is using hyperkube? We had an old issue where we were trying to transition everything to hyperkube[1], but i guess it feel out of favor and most folks just use the binaries. Right?
>
> Can we get rid of hyperkube binary and image from release artifacts?
>
> Why am i asking this? when revisiting all the cloud provider dependencies that we drag in, it turns out we don't really need to ship cloud-controller-manager as we will have external providers that have their own controller manager. To remove cloud-controller-manager, we first have to remove it from hyperkube (deprecation in [2]). Then the question was, do we really need hyperkube?
>
> Given that it's easy to just create a separate repo for hyperkube (prototype [3]). Do we have a set of folks who can sign up for this work? (Also there's k3s already! for the same use case).
>
> Note that the only hiccup in this prototype was that we don't check in generated code for openapi which i have a fix we can debate on in [4].
>
> WDYT? Can we give hyperkube images and binary the boot?
>
> Thanks,
> Dims
>
> [1] https://github.com/kubernetes/kubernetes/issues/16508
> [2] https://github.com/kubernetes/kubernetes/pull/81219
> [3] https://github.com/dims/hyperkube
> [4] https://github.com/kubernetes/kubernetes/pull/81239
>
>
> --
> Davanum Srinivas :: https://twitter.com/dims
>
> --
> You received this message because you are subscribed to the Google Groups "kubernetes-sig-architecture" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-sig-arch...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-sig-architecture/CANw6fcE%3DCyzCTRqA6LY6u-Ypoj%3DQLOho3_Kbc6n-7Nks7iwFPA%40mail.gmail.com.

Jason D Detiberus

unread,
Aug 11, 2019, 2:53:25 PM8/11/19
to Lubomir I. Ivanov, Davanum Srinivas, kubernetes-si...@googlegroups.com, kubernetes-sig-cluster-lifecycle
I believe the Talos project (https://github.com/talos-systems/talos) uses Hyperkube as well. 

You received this message because you are subscribed to the Google Groups "kubernetes-sig-cluster-lifecycle" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-sig-cluster...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-sig-cluster-lifecycle/CAGDbWi_SqGqWk_GtusJbW6xn8sUbUaUXah%2BNg%2BEOXNC9AXdHtw%40mail.gmail.com.

Vallery Lancey

unread,
Aug 11, 2019, 3:37:21 PM8/11/19
to Lubomir I. Ivanov, Davanum Srinivas, kubernetes-sig-architecture, kubernetes-sig-cluster-lifecycle
Maybe mark as depreciated with tentative/gentle timeline, and try to gauge usage. I’m not sure what the cleanup benefit vs user cost is.

Davanum Srinivas

unread,
Aug 11, 2019, 5:16:39 PM8/11/19
to Vallery Lancey, Lubomir I. Ivanov, kubernetes-sig-architecture, kubernetes-sig-cluster-lifecycle
Vallery, Jason,

Please note that interested parties can maintain it in another repo. See prototype:


-- Dims

Andrew Rynhard

unread,
Aug 11, 2019, 5:53:10 PM8/11/19
to Lubomir I. Ivanov, Davanum Srinivas, kubernetes-sig-architecture, kubernetes-sig-cluster-lifecycle
As Jason pointed out, Talos does indeed use hyperkube. That being said I have been looking for a good reason to get away from it. The main reason we do this is because we use musl instead of glibc and IIRC kubelet is linked against glibc.
> You received this message because you are subscribed to the Google Groups "kubernetes-sig-cluster-lifecycle" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-sig-cluster...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-sig-cluster-lifecycle/CAGDbWi_SqGqWk_GtusJbW6xn8sUbUaUXah%2BNg%2BEOXNC9AXdHtw%40mail.gmail.com.

Davanum Srinivas

unread,
Aug 11, 2019, 5:55:38 PM8/11/19
to Andrew Rynhard, Lubomir I. Ivanov, kubernetes-sig-architecture, kubernetes-sig-cluster-lifecycle
Andrew,

Ack. If we move just hyperkube support to another repo, you can have custom Makefile/scripts for the musl use case as well :)

Andrew Rynhard

unread,
Aug 11, 2019, 5:56:20 PM8/11/19
to Davanum Srinivas, Lubomir I. Ivanov, kubernetes-sig-architecture, kubernetes-sig-cluster-lifecycle
Sounds good to me.

Stephen Augustus

unread,
Aug 11, 2019, 5:57:52 PM8/11/19
to Davanum Srinivas, Andrew Rynhard, Lubomir I. Ivanov, kubernetes-sig-architecture, kubernetes-sig-cluster-lifecycle, kubernetes-sig-release
(looks like the threads forked off, so adding SIG Release back)

I'm in favor of moving hyperkube out of tree.

-- Stephen

David Eads

unread,
Aug 12, 2019, 7:59:12 AM8/12/19
to Stephen Augustus, Davanum Srinivas, Andrew Rynhard, Lubomir I. Ivanov, kubernetes-sig-architecture, kubernetes-sig-cluster-lifecycle, kubernetes-sig-release
I like the idea of moving away from hyperkube.  I'm less sure that an out of tree hyperkube is practical long term if the mono-repo is someday divided.

Reply all
Reply to author
Forward
0 new messages